You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-30] [$250] The QAB for Expenses - "Expensify US" reads "Scan receipt" but it opens to the Manual option for submitting instead. #53866
Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@JmillsExpensify Slack conversation (hyperlinked to channel name): migrate
Action Performed:
Prerequisite: User already submitted expense by scanning to a particular workspace
Tap the Green fab
Observe the QAB
Tap the QAB
Expected Result:
Opens the scan receipt open
Actual Result:
QAB reads as "Scan receipt" but it opens to the Manual option for submitting instead.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Edited by proposal-police: This proposal was edited at 2024-12-11 05:15:48 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
Request-type state is passed as undefined to quick actions here, hence most recent request-type is used for the quick-action irrespective of actual request-type associated with the quick-action.
Screen.Recording.2024-12-11.at.10.53.49.AM.mp4
### What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
This component would update rarely, and there is not much complicated going on here so no need for automated test.
What alternative solutions did you explore? (Optional)
Alternative way to handle the same case.
let requestType;
switch(quickAction?.action) {
case CONST.QUICK_ACTIONS.REQUEST_MANUAL:
case CONST.QUICK_ACTIONS.SPLIT_MANUAL:
case CONST.QUICK_ACTIONS.TRACK_MANUAL:
requestType = CONST.IOU.REQUEST_TYPE.MANUAL;
break;
case CONST.QUICK_ACTIONS.REQUEST_SCAN:
case CONST.QUICK_ACTIONS.SPLIT_SCAN:
case CONST.QUICK_ACTIONS.TRACK_SCAN:
requestType = CONST.IOU.REQUEST_TYPE.SCAN;
break;
case CONST.QUICK_ACTIONS.REQUEST_DISTANCE:
case CONST.QUICK_ACTIONS.SPLIT_DISTANCE:
case CONST.QUICK_ACTIONS.TRACK_DISTANCE:
requestType = CONST.IOU.REQUEST_TYPE.DISTANCE;
break;
default:
requestType = undefined;
}
switch (quickAction?.action) {
case CONST.QUICK_ACTIONS.REQUEST_MANUAL:
case CONST.QUICK_ACTIONS.REQUEST_SCAN:
case CONST.QUICK_ACTIONS.REQUEST_DISTANCE:
selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.SUBMIT, quickActionReportID, requestType, true), true);
return;
case CONST.QUICK_ACTIONS.SPLIT_MANUAL:
case CONST.QUICK_ACTIONS.SPLIT_SCAN:
case CONST.QUICK_ACTIONS.SPLIT_DISTANCE:
selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, quickActionReportID, requestType, true), true);
return;
case CONST.QUICK_ACTIONS.SEND_MONEY:
selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.PAY, quickActionReportID, undefined, true), false);
return;
case CONST.QUICK_ACTIONS.ASSIGN_TASK:
selectOption(() => Task.startOutCreateTaskQuickAction(isValidReport ? quickActionReportID : '', quickAction.targetAccountID ?? -1), false);
break;
case CONST.QUICK_ACTIONS.TRACK_MANUAL:
case CONST.QUICK_ACTIONS.TRACK_SCAN:
case CONST.QUICK_ACTIONS.TRACK_DISTANCE:
selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK, quickActionReportID, requestType, true), false);
break;
default:
}
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Heads up, I will be offline until Wednesday, December 18, 2024, and will not actively watch over this GitHub during that period.
If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.
changed the title [-][$250] The QAB for Expenses - "Expensify US" reads "Scan receipt" but it opens to the Manual option for submitting instead.[/-][+][HOLD for payment 2024-12-30] [$250] The QAB for Expenses - "Expensify US" reads "Scan receipt" but it opens to the Manual option for submitting instead.[/+]on Dec 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allroundexperts@alexpensify@allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Contributor: @ChavdaSachin paid $250 via Upwork -- all set, I paid a day early
Contributor+: @allroundexperts $250 via NewDot
@allroundexperts, please submit a payment request in Chat. Since I'm out of the office until January 3, I'll close and work on the QA step when I'm back online.
Activity
melvin-bot commentedon Dec 10, 2024
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Dec 10, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
ChavdaSachin commentedon Dec 11, 2024
Edited by proposal-police: This proposal was edited at 2024-12-11 05:15:48 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx
Lines 262 to 285 in f8f12c2
What changes do you think we should make in order to solve the problem?
Pass appropriate request-type for each case here.
App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx
Lines 262 to 285 in f8f12c2
Result
Screen.Recording.2024-12-11.at.10.53.49.AM.mp4
What alternative solutions did you explore? (Optional)
Alternative way to handle the same case.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
ChavdaSachin commentedon Dec 11, 2024
For reproduction steps
Screen.Recording.2024-12-11.at.10.50.48.AM.mp4
ChavdaSachin commentedon Dec 11, 2024
Updated Proposal
Added alternate pseudo code and added result.
allroundexperts commentedon Dec 12, 2024
I can reproduce this using @ChavdaSachin's steps here.
Screen.Recording.2024-12-12.at.6.14.23.PM.mov
allroundexperts commentedon Dec 12, 2024
@alexpensify Please assign this to me for C+.
14 remaining items
ChavdaSachin commentedon Dec 13, 2024
@allroundexperts PR is Ready for review.
alexpensify commentedon Dec 15, 2024
Heads up, I will be offline until Wednesday, December 18, 2024, and will not actively watch over this GitHub during that period.
If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.
[-][$250] The QAB for Expenses - "Expensify US" reads "Scan receipt" but it opens to the Manual option for submitting instead.[/-][+][HOLD for payment 2024-12-30] [$250] The QAB for Expenses - "Expensify US" reads "Scan receipt" but it opens to the Manual option for submitting instead.[/+]melvin-bot commentedon Dec 23, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 23, 2024
@allroundexperts @alexpensify @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
allroundexperts commentedon Dec 25, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/51057/files#r1897461065
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
N/A
Test:
Verify that the request-type tab is on scan.
Do we agree 👍 or 👎
alexpensify commentedon Dec 30, 2024
Payment due date: 2024-12-30
Contributor: @ChavdaSachin paid $250 via Upwork -- all set, I paid a day early
Contributor+: @allroundexperts $250 via NewDot
@allroundexperts, please submit a payment request in Chat. Since I'm out of the office until January 3, I'll close and work on the QA step when I'm back online.
JmillsExpensify commentedon Jun 10, 2025
$250 approved for @allroundexperts