Repository navigation
[$250] Incorrect Environment Attribute Sent for Staging Sessions #53892
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @anmurali
Slack conversation (hyperlinked to channel name): expensify_convert
Action Performed:
- Access a session where the user email matches the staging format: fullstory+anythinghere@applause.expensifail.com.
- Review the session details in FullStory.
- Observe the environment attribute.
Expected Result:
The environment attribute should accurately reflect the session's environment
Actual Result:
The environment attribute is incorrectly sent as production for users in the staging environment.
Full story session 1: https://app.fullstory.com/ui/o-1WN56P-na1/session/7395325973731847182:3405186692023031824!2964539090019794224
Full story session 2: https://app.fullstory.com/ui/o-1WN56P-na1/session/7395325973731847182:3405186692023031824!5533265545364867276
Segment in FS: https://app.fullstory.com/ui/o-1WN56P-na1/segments/h0mEJnfRoBYS/people/0?template=watch-sessions&completeSessions=false
( found 6600 in the last 30 days.)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021866822636661001653
- Upwork Job ID: 1866822636661001653
- Last Price Increase: 2024-12-11
Metadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Dec 10, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Dec 10, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
melvin-bot commentedon Dec 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021866822636661001653
[-]Incorrect Environment Attribute Sent for Staging Sessions[/-][+][$250] Incorrect Environment Attribute Sent for Staging Sessions[/+]melvin-bot commentedon Dec 11, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)42 remaining items
greg-schroeder commentedon Jan 13, 2025
Bump @anmurali :)
greg-schroeder commentedon Jan 16, 2025
I'll ping in the room
anmurali commentedon Jan 16, 2025
610 users in last 30 days
https://app.fullstory.com/ui/o-1WN56P-na1/segments/h0mEJnfRoBYS/people/0?completeSessions=false
melvin-bot commentedon Jan 20, 2025
@danieldoglas, @greg-schroeder, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
danieldoglas commentedon Jan 20, 2025
oh I think I figured out.
Once we set a property, it never changes unless we manually change it. The
properties.environmentwas deprecated, and now we should be using onlyenvironment. If you look forenvironmentonly, then you'll see that only the test account is being listed with it.But for all users that used the old version of the app,
properties.environmentis still filled with old values. That means that any user that hadstagingas their environment at that point would still show as staging, but their currentenvironmentis showing production.I think we can safely close this!
ZhenjaHorbach commentedon Jan 20, 2025
@danieldoglas
Maybe we need to fix this ? 😀
#53892 (comment)
danieldoglas commentedon Jan 20, 2025
I don't think that's needed, we have control over that expensifail.com domain.