You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-20] Search - Submit button is not disabled in Search when "Prevent self-approvals" is enabled #53989
Version Number: 9.0.75-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+kh1311020@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Search
Action Performed:
Precondition:
Delayed submission is enabled.
Admin is the approver.
"Prevent self-approvals" is enabled.
Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense.
Note that Submit button is disabled.
Go to Search.
Click Submit button on the same expense in Step 3.
Expected Result:
Submit button should also be disabled in Search when "Prevent self-approvals" is enabled.
Actual Result:
Submit button is not disabled in Search when "Prevent self-approvals" is enabled.
User can still submit expenses in Search.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon Dec 12, 2024
Triggered auto assignment to @mjasikowski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 12, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 12, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 12, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Dec 12, 2024
Not repro on production
bandicam.2024-12-12.06-31-56-649.mp4
mjasikowski commentedon Dec 12, 2024
Looking into it
daledah commentedon Dec 12, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Submit button is not disabled in Search when "Prevent self-approvals" is enabled.
User can still submit expenses in Search.
What is the root cause of that problem?
We only disabled the button while offline
App/src/components/SelectionList/Search/ActionCell.tsx
Line 113 in bf38806
What changes do you think we should make in order to solve the problem?
isDisabledButtontoActionCellcomponentgetButtonInnerStylesfunctionApp/src/components/SelectionList/Search/ActionCell.tsx
Lines 55 to 62 in bf38806
isDisabledButtonfromTransactionListItemRowand pass it toExpenseItemHeaderNarrow->ActionCellWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Like we did in MoneyReportHeader here, we can add new props
shouldShowButtonand add new variableshouldShowSubmitButtoninTransactionListItemRowApp/src/components/MoneyReportHeader.tsx
Lines 146 to 152 in bf38806
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
20 remaining items
melvin-bot commentedon Dec 20, 2024
Payment Summary
Upwork Job
BugZero Checklist (@sakluger)
allgandalf commentedon Dec 23, 2024
♻️ Pending payment...
melvin-bot commentedon Dec 23, 2024
@mjasikowski, @sakluger, @luacmartins, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!
allgandalf commentedon Dec 24, 2024
Checklist ✅ ♻️ Pending payment...
sakluger commentedon Dec 24, 2024
Sorry @allgandalf for the delay, I was OOO the past few days due to holiday travel.
Here's the Upwork contract: https://www.upwork.com/nx/wm/offer/105455673. Please let me know once you've accepted the contract and I will complete payment. Thanks!
allgandalf commentedon Dec 25, 2024
Accepted, thank you so much 😄 and happy holidays 🎁 🎄
sakluger commentedon Dec 27, 2024
All paid, thanks again!