You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After giving the solution in #52569 a try, we've realized that it creates a confusing situation in the Inbox, which is:
Workspace chat is GBRed
Report has a grey Approved button
So in short, our solution for approve and pay (specifically with a report that has some held expenses and some unheld expenses) ends up breaking GBR.
As a result, we're going to revert the PR from #52569. That restores GBR to the Inbox and workspace chat. In addition, for the Search page specifically, we are going to disable the Approve button for this case, just like we landed on doing for Pay.
@JmillsExpensify The expectation is that we revert the PR, and then disable Approve button as well as Pay as a new requirement? Would it be a single PR or two PRs - one revert and then second to disable Approve?
changed the title [-][Due for payment 2025-02-10] [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Revert #52569[/-][+][Due for payment 2025-02-10] Revert #52569[/+]on Feb 10, 2025
Activity
melvin-bot commentedon Dec 12, 2024
Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.
mananjadhav commentedon Dec 15, 2024
@JmillsExpensify The expectation is that we revert the PR, and then disable Approve button as well as Pay as a new requirement? Would it be a single PR or two PRs - one revert and then second to disable Approve?
I can help with the review on this one if needed.
melvin-bot commentedon Dec 16, 2024
@JmillsExpensify, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
luacmartins commentedon Dec 16, 2024
I think we want to:
luacmartins commentedon Dec 16, 2024
@mananjadhav you're welcome to work on the PRs too if you'd like
mananjadhav commentedon Dec 17, 2024
Yes, I can pick this.
95 remaining items
parasharrajat commentedon Feb 10, 2025
Payment requested #54054 (comment)
[-][Due for payment 2025-02-10] [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Revert #52569[/-][+][Due for payment 2025-02-10] Revert #52569[/+]mananjadhav commentedon Feb 11, 2025
@JmillsExpensify Waiting for the payout summary on this one.
melvin-bot commentedon Feb 12, 2025
@JmillsExpensify, @mananjadhav, @luacmartins, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
luacmartins commentedon Feb 12, 2025
Just waiting on payment
sakluger commentedon Feb 12, 2025
Summarizing payment on this issue:
Contributor+: @mananjadhav $250, please request on NewDot
Contributor+: @parasharrajat $250, please request on NewDot
garrettmknight commentedon Feb 12, 2025
$250 approved for @mananjadhav
mananjadhav commentedon Feb 12, 2025
Thanks @sakluger @garrettmknight for taking care of this.
mananjadhav commentedon Feb 13, 2025
Once @parasharrajat's payout is approved, we can close this one out.
parasharrajat commentedon Feb 13, 2025
We can close this. Mine is usually delayed and I am tracking the payment.
luacmartins commentedon Feb 13, 2025
We're done!
JmillsExpensify commentedon Feb 15, 2025
$250 approved for @parasharrajat