Skip to content

[Due for payment 2025-02-10] Revert #52569 #54054

Closed

Description

@JmillsExpensify

After giving the solution in #52569 a try, we've realized that it creates a confusing situation in the Inbox, which is:

  • Workspace chat is GBRed
  • Report has a grey Approved button

So in short, our solution for approve and pay (specifically with a report that has some held expenses and some unheld expenses) ends up breaking GBR.

As a result, we're going to revert the PR from #52569. That restores GBR to the Inbox and workspace chat. In addition, for the Search page specifically, we are going to disable the Approve button for this case, just like we landed on doing for Pay.

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 12, 2024
  2. melvin-bot commented on Dec 12, 2024

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

  3. mananjadhav commented on Dec 15, 2024

    @mananjadhav
    Collaborator

    @JmillsExpensify The expectation is that we revert the PR, and then disable Approve button as well as Pay as a new requirement? Would it be a single PR or two PRs - one revert and then second to disable Approve?

    I can help with the review on this one if needed.

  4. melvin-bot commented on Dec 16, 2024

    @melvin-bot

    @JmillsExpensify, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. luacmartins commented on Dec 16, 2024

    @luacmartins
    Contributor

    I think we want to:

    1. Revert the behavior of changing the button colors.
    2. On Search, disable the option in the bulk action dropdown if any selected items are on hold
  6. luacmartins commented on Dec 16, 2024

    @luacmartins
    Contributor

    @mananjadhav you're welcome to work on the PRs too if you'd like

  7. mananjadhav commented on Dec 17, 2024

    @mananjadhav
    Collaborator

    Yes, I can pick this.

  8. 95 remaining items

  9. parasharrajat commented on Feb 10, 2025

    @parasharrajat
    Member

    Payment requested #54054 (comment)

  10. changed the title [-][Due for payment 2025-02-10] [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Revert #52569[/-] [+][Due for payment 2025-02-10] Revert #52569[/+] on Feb 10, 2025
  11. mananjadhav commented on Feb 11, 2025

    @mananjadhav
    Collaborator

    @JmillsExpensify Waiting for the payout summary on this one.

  12. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    @JmillsExpensify, @mananjadhav, @luacmartins, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  13. luacmartins commented on Feb 12, 2025

    @luacmartins
    Contributor

    Just waiting on payment

  14. sakluger commented on Feb 12, 2025

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor+: @mananjadhav $250, please request on NewDot
    Contributor+: @parasharrajat $250, please request on NewDot

  15. garrettmknight commented on Feb 12, 2025

    @garrettmknight
    Contributor

    $250 approved for @mananjadhav

  16. mananjadhav commented on Feb 12, 2025

    @mananjadhav
    Collaborator

    Thanks @sakluger @garrettmknight for taking care of this.

  17. mananjadhav commented on Feb 13, 2025

    @mananjadhav
    Collaborator

    Once @parasharrajat's payout is approved, we can close this one out.

  18. parasharrajat commented on Feb 13, 2025

    @parasharrajat
    Member

    We can close this. Mine is usually delayed and I am tracking the payment.

  19. luacmartins commented on Feb 13, 2025

    @luacmartins
    Contributor

    We're done!

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Feb 13, 2025
  21. JmillsExpensify commented on Feb 15, 2025

    @JmillsExpensify
    ContributorAuthor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions