Skip to content

[HOLD for payment 2025-01-15] [$500] Make it possible to click the element the product training tooltip is pointing to. #54068

Closed

Description

@ishpaul777

Part of the Migrate Existing Users to NewDot project

Main issue: https://github.com/Expensify/Expensify/issues/437980
Doc section: https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.yh89nmhpipyt
Project:

Feature Description

Make it possible to click the element the product training tooltip is pointing to.

Ideal Expected Behaviour:

  1. you should be able to interact with anything on the screen. The presence of a tooltip shouldn't change what you can do
  2. you should be able to click the element the tooltip is pointing to
  3. the tooltip should remain until you click that element. So if you click something else that's fine, we allow you. But the tooltip isn't dismissed as a result

Manual tests scenario:

  1. Tooltip pointing to Concierge chat in LHN shows.
  2. Click on conceirge chat, tooltip should disappear.
  3. if user clicks on any other chat than Concierge, tooltip should disappear but when user goes back to LHN Tooltip should appear again.

Note: None of the tooltips should be autodismissed after few seconds

We have 4 tooltips at this time see list here and other 4 will be added in #54064 this should be the expected behavior for all tooltips

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021867697197444537249
  • Upwork Job ID: 1867697197444537249
  • Last Price Increase: 2024-12-27
  • Automatic offers:
    • ishpaul777 | Reviewer | 105520989
    • rayane-djouah | Contributor | 105520990
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    on Dec 13, 2024
  2. changed the title [-]Make it possible to click the element the product training tooltip is pointing to.[/-] [+][$250] Make it possible to click the element the product training tooltip is pointing to.[/+] on Dec 13, 2024
  3. melvin-bot commented on Dec 13, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 13, 2024
  5. melvin-bot commented on Dec 13, 2024

    @melvin-bot

    Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

  6. melvin-bot commented on Dec 13, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  7. 51 remaining items

  8. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  9. twisterdotcom commented on Jan 14, 2025

    @twisterdotcom
    Contributor

    Okay, sorry for missing this folks. The regression messages certainly caused a bit of confusion. @puneetlath / @iwiznia are we worried about the regressions here enough to reduce payment? Or, now that everything is resolved, can we go ahead with paying out the existing offers?

  10. iwiznia commented on Jan 14, 2025

    @iwiznia
    Contributor

    I thought all regressions reduced payments, if that's not the case, then I am not sure what the logic is for reducing payment.

  11. rayane-d commented on Jan 14, 2025

    @rayane-d
  12. rayane-d commented on Jan 15, 2025

    @rayane-d
    Contributor

    Note: My eligibility for NewDot payments began on December 28th, and I was assigned to this GitHub issue on December 31st

  13. rayane-d commented on Jan 15, 2025

    @rayane-d
    Contributor

    Regression Test Proposal

    
    - Sign in with a new account and complete the onboarding flow.
    
    ### For all product training tooltips (Concierge chat, FAB, QAB, Workspace chat, Filters button, Inbox Icon, Saved search three dots, "+" button tooltip in invited workspace chat):
    1. You should be able to interact with any element on the screen. The presence of a tooltip should not restrict interactions.
    2. You should be able to click the element the tooltip is pointing to.
    3. The tooltip should remain visible until you click the element it is pointing to. Interacting with other elements should not dismiss the tooltip except for modals.
    4. Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
    5. Verify that after clicking the element the tooltip is pointing to, the tooltip is dismissed and does not show again.
    
    

    Do we agree 👍 or 👎

  14. twisterdotcom commented on Jan 16, 2025

    @twisterdotcom
    Contributor

    This seems fine to me: #54068 (comment)

  15. twisterdotcom commented on Jan 16, 2025

    @twisterdotcom
    Contributor

    Payment Summary:

  16. moved this from First Cohort - CRITICAL to Done in [#whatsnext] #migrateon Jan 16, 2025
  17. garrettmknight commented on Jan 29, 2025

    @garrettmknight
    Contributor

    $500 approved for @rayane-djouah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions