You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-19] [$125] Reports - Chat filter is missing "In" field #54172
Version Number: 9.0.76-6 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+kh04120001@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Windows 11 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Open any chat.
Click on the search icon on the top right.
Click "Search in" (make sure the search query is type:chat).
Type anything and hit Enter.
Click Filters.
Expected Result:
There should be "In" field because the search query is "in:x" (previously there was "In" row for chat filter, which can be seen in this issue #52924).
Also, if the "To" filter isn't expected for Chats, then we can remove it. Because currently, "To" filter only shows results if we select ourself. Looks like "To" filters any chat that is sent to the user selected on the filter, and we can only do it for ourself.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
The filter key is a CONST object, so not sure if testing the content of a const is necessary, but we can definitely add it if needed..
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@eVoloshchak@kadiealexander@eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not a critical regression
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Regression test isn't needed
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Dec 15, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Dec 16, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat filter missing In filter field.
What is the root cause of that problem?
This happens after this PR. In that PR, a new filter "To" is added, but "In" filter is removed.
App/src/pages/Search/AdvancedSearchFilters.tsx
Lines 208 to 211 in 653af04
What changes do you think we should make in order to solve the problem?
If the removal of "In" filter isn't expected, then we can re-add it to the array.
App/src/pages/Search/AdvancedSearchFilters.tsx
Lines 208 to 211 in 653af04
Also, if the "To" filter isn't expected for Chats, then we can remove it. Because currently, "To" filter only shows results if we select ourself. Looks like "To" filters any chat that is sent to the user selected on the filter, and we can only do it for ourself.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
The filter key is a CONST object, so not sure if testing the content of a const is necessary, but we can definitely add it if needed..
[-]Reports - Chat filter is missing "In" field[/-][+][$250] Reports - Chat filter is missing "In" field[/+]melvin-bot commentedon Dec 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021868866663488600849
melvin-bot commentedon Dec 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Dec 20, 2024
@eVoloshchak, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Dec 24, 2024
@eVoloshchak, @kadiealexander Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Dec 24, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
39 remaining items
melvin-bot commentedon Feb 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 12, 2025
@eVoloshchak @kadiealexander @eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
bernhardoj commentedon Feb 19, 2025
Requested in ND.
melvin-bot commentedon Feb 19, 2025
Payment Summary
Upwork Job
BugZero Checklist (@kadiealexander)
eVoloshchak commentedon Feb 19, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/52938/files#r1962220125
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not a critical regression
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Regression test isn't needed
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
eVoloshchak commentedon Feb 19, 2025
@kadiealexander, which amount should it be, $125 or $250?
kadiealexander commentedon Feb 20, 2025
Updated, thanks for flagging @eVoloshchak
JmillsExpensify commentedon Feb 20, 2025
$125 approved for @bernhardoj
JmillsExpensify commentedon Mar 3, 2025
$125 approved for @eVoloshchak