Skip to content

[Due for payment 2025-02-19] [$125] Reports - Chat filter is missing "In" field #54172

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.76-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh04120001@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open any chat.
  3. Click on the search icon on the top right.
  4. Click "Search in" (make sure the search query is type:chat).
  5. Type anything and hit Enter.
  6. Click Filters.

Expected Result:

There should be "In" field because the search query is "in:x" (previously there was "In" row for chat filter, which can be seen in this issue #52924).

Actual Result:

Chat filter is missing "In" field.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6695119_1734294578695.bandicam_2024-12-16_04-24-56-619.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021868866663488600849
  • Upwork Job ID: 1868866663488600849
  • Last Price Increase: 2025-01-28
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 15, 2024
  2. melvin-bot commented on Dec 15, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. bernhardoj commented on Dec 16, 2024

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Chat filter missing In filter field.

    What is the root cause of that problem?

    This happens after this PR. In that PR, a new filter "To" is added, but "In" filter is removed.

    [CONST.SEARCH.DATA_TYPES.CHAT]: [
    [CONST.SEARCH.SYNTAX_FILTER_KEYS.KEYWORD, CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM, CONST.SEARCH.SYNTAX_FILTER_KEYS.TO],
    [CONST.SEARCH.SYNTAX_FILTER_KEYS.DATE],
    ],

    What changes do you think we should make in order to solve the problem?

    If the removal of "In" filter isn't expected, then we can re-add it to the array.

    [CONST.SEARCH.DATA_TYPES.CHAT]: [
    [CONST.SEARCH.SYNTAX_FILTER_KEYS.KEYWORD, CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM, CONST.SEARCH.SYNTAX_FILTER_KEYS.TO],
    [CONST.SEARCH.SYNTAX_FILTER_KEYS.DATE],
    ],

    Also, if the "To" filter isn't expected for Chats, then we can remove it. Because currently, "To" filter only shows results if we select ourself. Looks like "To" filters any chat that is sent to the user selected on the filter, and we can only do it for ourself.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    The filter key is a CONST object, so not sure if testing the content of a const is necessary, but we can definitely add it if needed..

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 17, 2024
  5. changed the title [-]Reports - Chat filter is missing "In" field[/-] [+][$250] Reports - Chat filter is missing "In" field[/+] on Dec 17, 2024
  6. melvin-bot commented on Dec 17, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 17, 2024
  8. melvin-bot commented on Dec 17, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  9. melvin-bot commented on Dec 20, 2024

    @melvin-bot

    @eVoloshchak, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    @eVoloshchak, @kadiealexander Still overdue 6 days?! Let's take care of this!

  11. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  12. 39 remaining items

  13. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @eVoloshchak requires payment through NewDot Manual Requests
    • @bernhardoj requires payment through NewDot Manual Requests
  15. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    @eVoloshchak @kadiealexander @eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. bernhardoj commented on Feb 19, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  17. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@kadiealexander)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1868866663488600849/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  18. eVoloshchak commented on Feb 19, 2025

    @eVoloshchak
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/52938/files#r1962220125

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: not a critical regression

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Regression test isn't needed

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  19. eVoloshchak commented on Feb 19, 2025

    @eVoloshchak
    Contributor

    @kadiealexander, which amount should it be, $125 or $250?

  20. kadiealexander commented on Feb 20, 2025

    @kadiealexander
    Contributor

    Updated, thanks for flagging @eVoloshchak

  21. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Feb 20, 2025
  22. JmillsExpensify commented on Feb 20, 2025

    @JmillsExpensify
    Contributor

    $125 approved for @bernhardoj

  23. JmillsExpensify commented on Mar 3, 2025

    @JmillsExpensify
    Contributor

    $125 approved for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions