Skip to content

Investigate workflow job failing on main: typecheck / typecheck #54194

Closed

Description

@github-actions

🚨 Failure Summary 🚨:

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named typecheck / typecheck.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

Activity

  1. MariaHCD commented on Dec 16, 2024

    @MariaHCD
    Contributor
  2. MariaHCD commented on Dec 16, 2024

    @MariaHCD
    Contributor

    From the check on main:

    Screenshot 2024-12-16 at 5 24 33 PM

  3. MariaHCD commented on Dec 16, 2024

    @MariaHCD
    Contributor

    Ah, route is still used here:

    if (isPrivateDomain && !onboardingPurposeSelected) {
    Navigation.navigate(ROUTES.ONBOARDING_PRIVATE_DOMAIN.getRoute(route.params?.backTo));
    return;
    }
    completeOnboarding(firstName, lastName);
    },
    [isPrivateDomain, onboardingPurposeSelected, route.params?.backTo, completeOnboarding],

  4. MariaHCD commented on Dec 16, 2024

    @MariaHCD
    Contributor

    Revert: #54198

  5. MariaHCD commented on Dec 16, 2024

    @MariaHCD
    Contributor

    Resolved via: #54198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions