Skip to content

[HOLD for payment 2025-01-17] [$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero #54204

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.76-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+855069@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace is connected to Xero.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Tags.
  3. Click 3-dot menu.
  4. Click Import spreadsheet.

Expected Result:

Import spreadsheet option should be hidden when there is connection in the workspace, as the tags are imported from the connection (the same option is hidden in Categories page).

Actual Result:

Import spreadsheet option is available in Tags page when workspace is connected to Xero.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6695620_1734356008046.20241216_213054ug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021871236546261689933
  • Upwork Job ID: 1871236546261689933
  • Last Price Increase: 2025-01-06
  • Automatic offers:
    • mkzie2 | Contributor | 105582064
    • shubham1206agra | Contributor | 105599297
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 16, 2024
  2. melvin-bot commented on Dec 16, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mkzie2 commented on Dec 16, 2024

    @mkzie2
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-12-16 14:52:38 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Import spreadsheet option is available in Tags page when workspace is connected to Xero.

    What is the root cause of that problem?

    We always show the import option without checking we have a connection or not.

    {
    icon: Expensicons.Table,
    text: translate('spreadsheet.importSpreadsheet'),
    onSelected: () => {

    What changes do you think we should make in order to solve the problem?

    We should use the same check here

    const menuItems: PopoverMenuItem[] = [];
    if (!PolicyUtils.hasAccountingConnections(policy)) {
        menuItems.push({
            icon: Expensicons.Table,
            text: translate('spreadsheet.importSpreadsheet'),
            onSelected: () => {
                if (isOffline) {
                    Modal.close(() => setIsOfflineModalVisible(true));
                    return;
                }
                Navigation.navigate(isQuickSettingsFlow ? ROUTES.SETTINGS_TAGS_IMPORT.getRoute(policyID, backTo) : ROUTES.WORKSPACE_TAGS_IMPORT.getRoute(policyID));
            },
        });
    }
    

    {
    icon: Expensicons.Table,
    text: translate('spreadsheet.importSpreadsheet'),
    onSelected: () => {

    Optional: We also need to display not found page in ImportTagsPage if we have a connection like the same here

    if (hasAccountingConnections) {

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Dec 20, 2024

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. mallenexpensify commented on Dec 23, 2024

    @mallenexpensify
    Contributor

    Was able to reproduce
    Snagit 2024 2024-12-23 11 46 20

    Going to make it External, my guess/hope is that we just need to hide the option. @zanyrenney @lakchote , do you know if more is needed?

  6. changed the title [-]Import tags - Import spreadsheet option is available when workspace is connected to Xero[/-] [+][$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/+] on Dec 23, 2024
  7. melvin-bot commented on Dec 23, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 23, 2024
  9. 31 remaining items

  10. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 10, 2025
  12. changed the title [-][$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/-] [+][HOLD for payment 2025-01-17] [$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/+] on Jan 10, 2025
  13. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-17. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    @shubham1206agra @mallenexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. shubham1206agra commented on Jan 15, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/48877/files#r1917048190

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Workspace is connected to any integration (Example - Xero, NetSuite, etc.).

    Test:

    1. Go to the workspace > tags
    2. Click on the three-dot icon
    3. Verify that the import sheet option doesn't appear

    Do we agree 👍 or 👎

  17. mallenexpensify commented on Jan 17, 2025

    @mallenexpensify
    Contributor

    Contributor: @mkzie2 paid $250 via Upwork
    Contributor+: @shubham1206agra paid $250 via Upwork.

    Test Rail - https://github.com/Expensify/Expensify/issues/462296

    Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions