You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-17] [$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero #54204
Version Number: 9.0.76-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+855069@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace is connected to Xero.
Go to staging.new.expensify.com
Go to workspace settings > Tags.
Click 3-dot menu.
Click Import spreadsheet.
Expected Result:
Import spreadsheet option should be hidden when there is connection in the workspace, as the tags are imported from the connection (the same option is hidden in Categories page).
Actual Result:
Import spreadsheet option is available in Tags page when workspace is connected to Xero.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Import tags - Import spreadsheet option is available when workspace is connected to Xero[/-][+][$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/+]on Dec 23, 2024
📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
changed the title [-][$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/-][+][HOLD for payment 2025-01-17] [$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/+]on Jan 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@shubham1206agra@mallenexpensify@shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Workspace is connected to any integration (Example - Xero, NetSuite, etc.).
Test:
Go to the workspace > tags
Click on the three-dot icon
Verify that the import sheet option doesn't appear
Activity
melvin-bot commentedon Dec 16, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Dec 16, 2024
Edited by proposal-police: This proposal was edited at 2024-12-16 14:52:38 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Import spreadsheet option is available in Tags page when workspace is connected to Xero.
What is the root cause of that problem?
We always show the import option without checking we have a connection or not.
App/src/pages/workspace/tags/WorkspaceTagsPage.tsx
Lines 297 to 300 in b8579b1
What changes do you think we should make in order to solve the problem?
We should use the same check here
App/src/pages/workspace/tags/WorkspaceTagsPage.tsx
Lines 297 to 300 in b8579b1
Optional: We also need to display not found page in
ImportTagsPageif we have a connection like the same hereApp/src/pages/workspace/categories/ImportCategoriesPage.tsx
Line 23 in b8579b1
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Dec 20, 2024
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Dec 23, 2024
Was able to reproduce

Going to make it
External, my guess/hope is that we just need to hide the option. @zanyrenney @lakchote , do you know if more is needed?[-]Import tags - Import spreadsheet option is available when workspace is connected to Xero[/-][+][$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/+]melvin-bot commentedon Dec 23, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021871236546261689933
31 remaining items
melvin-bot commentedon Jan 7, 2025
📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
[-][$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/-][+][HOLD for payment 2025-01-17] [$250] Import tags - Import spreadsheet option is available when workspace is connected to Xero[/+]melvin-bot commentedon Jan 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 10, 2025
@shubham1206agra @mallenexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
shubham1206agra commentedon Jan 15, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/48877/files#r1917048190
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
mallenexpensify commentedon Jan 17, 2025
Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @shubham1206agra paid $250 via Upwork.
Test Rail - https://github.com/Expensify/Expensify/issues/462296
Thx!