Skip to content

Mark down - Link is not underlined, heading text is not bold #54301

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.77-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Send a link (google.com).
  4. Send a heading markdown.

Expected Result:

Link will be underlined.
Heading text will be bold.

Actual Result:

Link is not underlined.
Heading text is not bold.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6698058_1734533728776.20241218_212210.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 18, 2024
  2. melvin-bot commented on Dec 18, 2024

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 18, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Dec 18, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. amyevans commented on Dec 18, 2024

    @amyevans
    Contributor

    I'm suspicious of the changes to react-native-render-html or react-native-live-markdown but haven't done any testing yet, will undertake that now.

  7. amyevans commented on Dec 18, 2024

    @amyevans
    Contributor

    Alright confirmed it's the react-native-render-html change.

    PR: #52917

    With PR merged to main, testing locally:
    Screenshot 2024-12-18 at 11 47 23 AM

    After stopping the dev server and reverting the PR I did:

    rm -rf node_modules/
    npm i
    npm run web
    

    With PR reverted, testing locally:

    Screenshot 2024-12-18 at 11 56 27 AM

    So I'll open a revert PR, I think that's the best thing to do to unblock deploy.

  8. amyevans commented on Dec 18, 2024

    @amyevans
    Contributor

    Updated revert PR since we had 2 open: #54309

    Once it's on staging I'll double check the issue is gone and close this out

  9. amyevans commented on Dec 18, 2024

    @amyevans
    Contributor

    PR has been CP'ed, and I verified the result in staging:

    Screenshot 2024-12-18 at 3 13 45 PM

    Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions