You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[BZ Checklist][$250] Rules - "days" is not displayed In Max expense age page #54363
Version Number: v 9.77-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):htad26+2@gmail.com Issue reported by: Applause Internal Team Device used: iPhone 13/iOS 18.0 App Component: Workspace Settings
Action Performed:
Prerequisite
A workspace with rules enabled
Navigate to workspace settings
Navigate to rules > Max expense age
Observe the end of the input field in "Max expense age"
Expected Result:
"days" is displayed at the end of the input field.
Actual Result:
"days" is not displayed at the end of the input field, which is not consistent with the behavior on other platforms
Edited by proposal-police: This proposal was edited at 2024-12-19 14:32:42 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Rules - "days" is not displayed In Max expense age page
What is the root cause of that problem?
We use InputWrapper to render the input. This component wraps BaseTextInput, which is split into two files: index.native.ts and index.ts files. However, the suffix handling logic is implemented only for non-native platforms and is missing for native platforms.
This appears to have been missed during the migration in #47409.
changed the title [-]Rules - "days" is not displayed In Max expense age page[/-][+][$125] Rules - "days" is not displayed In Max expense age page[/+]on Dec 23, 2024
@Ollyws@mallenexpensify@Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Hi @mallenexpensify it looks like the PR has been deployed to production without any regressions after 7 days. Could you please assist with the payment?
@Ollyws it looks like the BZ checklist didn't populate, can you fill it out plz?
BugZero Checklist:
[Contributor] Classify the bug:
Bug classification
Source of bug:
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
changed the title [-][HOLD for payment 2025-01-13] [$250] Rules - "days" is not displayed In Max expense age page[/-][+][BZ Check][$250] Rules - "days" is not displayed In Max expense age page[/+]on Jan 14, 2025
changed the title [-][BZ Check][$250] Rules - "days" is not displayed In Max expense age page[/-][+][BZ Checklist][$250] Rules - "days" is not displayed In Max expense age page[/+]on Jan 14, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
1. Navigate to workspace settings
2. Navigate to rules > Max expense age
3. Observe the end of the input field in "Max expense age"
4. Additional: Navigate to rules > Random report audit > Observe the end of the input field
Activity
melvin-bot commentedon Dec 19, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.linhvovan29546 commentedon Dec 19, 2024
Edited by proposal-police: This proposal was edited at 2024-12-19 14:32:42 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Rules - "days" is not displayed In Max expense age page
What is the root cause of that problem?
We use
InputWrapperto render the input. This component wrapsBaseTextInput, which is split into two files: index.native.ts and index.ts files. However, the suffix handling logic is implemented only for non-native platforms and is missing for native platforms.This appears to have been missed during the migration in #47409.
App/src/pages/workspace/rules/RulesMaxExpenseAgePage.tsx
Lines 73 to 78 in e42622c
App/src/components/TextInput/BaseTextInput/index.tsx
Lines 414 to 423 in e42622c
What changes do you think we should make in order to solve the problem?
Copy the suffix handling logic from index.ts to index.native.ts
POC
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-19.at.21.13.46.mp4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
linhvovan29546 commentedon Dec 19, 2024
This issue also appears on the Rules - "Random report audit" page
Detail
melvin-bot commentedon Dec 23, 2024
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Rules - "days" is not displayed In Max expense age page[/-][+][$125] Rules - "days" is not displayed In Max expense age page[/+]melvin-bot commentedon Dec 23, 2024
melvin-bot commentedon Dec 23, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021871267339195943980
melvin-bot commentedon Dec 23, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)23 remaining items
melvin-bot commentedon Jan 6, 2025
@Ollyws @mallenexpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
linhvovan29546 commentedon Jan 14, 2025
Hi @mallenexpensify it looks like the PR has been deployed to production without any regressions after 7 days. Could you please assist with the payment?
mallenexpensify commentedon Jan 14, 2025
Contributor: @linhvovan29546 paid $250 via Upwork
Contributor+: @Ollyws due $250
@Ollyws it looks like the BZ checklist didn't populate, can you fill it out plz?
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
[-][HOLD for payment 2025-01-13] [$250] Rules - "days" is not displayed In Max expense age page[/-][+][BZ Check][$250] Rules - "days" is not displayed In Max expense age page[/+][-][BZ Check][$250] Rules - "days" is not displayed In Max expense age page[/-][+][BZ Checklist][$250] Rules - "days" is not displayed In Max expense age page[/+]melvin-bot commentedon Jan 16, 2025
@iwiznia @Ollyws @mallenexpensify @linhvovan29546 this issue is now 4 weeks old, please consider:
Thanks!
Ollyws commentedon Jan 16, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/47409/files#r1918170777
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/462302
Regression Test Proposal
Precondition:
Create a workspace with rules enabled
Test:
Do we agree 👍 or 👎
Ollyws commentedon Jan 16, 2025
Requested in ND.
mallenexpensify commentedon Jan 17, 2025
Thanks @Ollyws. Test case created
garrettmknight commentedon Jan 21, 2025
$250 approved for @Ollyws