Skip to content

[BZ Checklist][$250] Rules - "days" is not displayed In Max expense age page #54363

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v 9.77-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): htad26+2@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 13/iOS 18.0
App Component: Workspace Settings

Action Performed:

Prerequisite
A workspace with rules enabled

  1. Navigate to workspace settings
  2. Navigate to rules > Max expense age
  3. Observe the end of the input field in "Max expense age"

Expected Result:

"days" is displayed at the end of the input field.

Actual Result:

"days" is not displayed at the end of the input field, which is not consistent with the behavior on other platforms

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6698973_1734615244485!img_0116

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021871267339195943980
  • Upwork Job ID: 1871267339195943980
  • Last Price Increase: 2024-12-23
  • Automatic offers:
    • linhvovan29546 | Contributor | 105454335
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 19, 2024
  2. melvin-bot commented on Dec 19, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. linhvovan29546 commented on Dec 19, 2024

    @linhvovan29546
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-12-19 14:32:42 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Rules - "days" is not displayed In Max expense age page

    What is the root cause of that problem?

    We use InputWrapper to render the input. This component wraps BaseTextInput, which is split into two files: index.native.ts and index.ts files. However, the suffix handling logic is implemented only for non-native platforms and is missing for native platforms.
    This appears to have been missed during the migration in #47409.

    <InputWrapper
    InputComponent={TextInput}
    inputID={INPUT_IDS.MAX_EXPENSE_AGE}
    label={translate('workspace.rules.individualExpenseRules.maxAge')}
    suffixCharacter={translate('common.days')}
    suffixStyle={styles.colorMuted}

    {!!suffixCharacter && (
    <View style={[styles.textInputSuffixWrapper, suffixContainerStyle]}>
    <Text
    tabIndex={-1}
    style={[styles.textInputSuffix, !hasLabel && styles.pv0, styles.pointerEventsNone, suffixStyle]}
    dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
    >
    {suffixCharacter}
    </Text>
    </View>

    What changes do you think we should make in order to solve the problem?

    Copy the suffix handling logic from index.ts to index.native.ts

    POC
    Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-19.at.21.13.46.mp4

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    N/A

  4. linhvovan29546 commented on Dec 19, 2024

    @linhvovan29546
    Contributor

    This issue also appears on the Rules - "Random report audit" page

    Detail
    Before After
  5. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. changed the title [-]Rules - "days" is not displayed In Max expense age page[/-] [+][$125] Rules - "days" is not displayed In Max expense age page[/+] on Dec 23, 2024
  7. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 23, 2024
  9. melvin-bot commented on Dec 23, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 23, 2024
  11. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  12. 23 remaining items

  13. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @Ollyws @mallenexpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. linhvovan29546 commented on Jan 14, 2025

    @linhvovan29546
    Contributor

    Hi @mallenexpensify it looks like the PR has been deployed to production without any regressions after 7 days. Could you please assist with the payment?

  15. mallenexpensify commented on Jan 14, 2025

    @mallenexpensify
    Contributor

    Contributor: @linhvovan29546 paid $250 via Upwork
    Contributor+: @Ollyws due $250

    @Ollyws it looks like the BZ checklist didn't populate, can you fill it out plz?

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  16. changed the title [-][HOLD for payment 2025-01-13] [$250] Rules - "days" is not displayed In Max expense age page[/-] [+][BZ Check][$250] Rules - "days" is not displayed In Max expense age page[/+] on Jan 14, 2025
  17. changed the title [-][BZ Check][$250] Rules - "days" is not displayed In Max expense age page[/-] [+][BZ Checklist][$250] Rules - "days" is not displayed In Max expense age page[/+] on Jan 14, 2025
  18. melvin-bot commented on Jan 16, 2025

    @melvin-bot

    @iwiznia @Ollyws @mallenexpensify @linhvovan29546 this issue is now 4 weeks old, please consider:

    • Finding a contributor to fix the bug
    • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
    • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

    Thanks!

  19. Ollyws commented on Jan 16, 2025

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/47409/files#r1918170777

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Create a workspace with rules enabled

    Test:

    1. Navigate to workspace settings
    2. Navigate to rules > Max expense age
    3. Observe the end of the input field in "Max expense age"
    4. Additional: Navigate to rules > Random report audit > Observe the end of the input field
    

    Do we agree 👍 or 👎

  20. Ollyws commented on Jan 16, 2025

    @Ollyws
    Contributor

    Requested in ND.

  21. mallenexpensify commented on Jan 17, 2025

    @mallenexpensify
    Contributor
  22. garrettmknight commented on Jan 21, 2025

    @garrettmknight
    Contributor

    $250 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions