Skip to content

[Due for payment 2025-02-19] [HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle #54436

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.76-12
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Workspace is connected to QBO.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Accounting.
  3. Click Export.
  4. Click Export company card expenses as.
  5. Click Export as.
  6. Select Vendor bill.

Expected Result:

The hint text for Vendor bill is below the toggle (PR #43973) (this is also the same behavior in Advanced page).

Actual Result:

The hint text for Vendor bill is not below the toggle.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4
bug

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021876342286796656020
  • Upwork Job ID: 1876342286796656020
  • Last Price Increase: 2025-01-06
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 20, 2024
  2. melvin-bot commented on Dec 20, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mkzie2 commented on Dec 20, 2024

    @mkzie2
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-12-20 20:35:53 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The hint text for Vendor bill is not below the toggle.

    What is the root cause of that problem?

    We don't pass shouldPlaceSubtitleBelowSwitch to ToggleSettingOptionRow then the hint text is not displayed below the toggle. This happens after this PR where we missed this prop when implementing the offline pattern

    {!shouldPlaceSubtitleBelowSwitch && subtitle && subTitleView}

    What changes do you think we should make in order to solve the problem?

    Pass shouldPlaceSubtitleBelowSwitch here

    We can check other places that use ToggleSettingOptionRow and pass the same prop if we want the hint text is also displayed below the toggle in this place.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. melvin-bot commented on Dec 26, 2024

    @melvin-bot

    @isabelastisser Huh... This is 4 days overdue. Who can take care of this?

  6. melvin-bot commented on Dec 30, 2024

    @melvin-bot

    @isabelastisser Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  7. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    @isabelastisser 10 days overdue. Is anyone even seeing these? Hello?

  8. melvin-bot commented on Jan 3, 2025

    @melvin-bot

    @isabelastisser this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  9. melvin-bot commented on Jan 3, 2025

    @melvin-bot

    @isabelastisser 12 days overdue. Walking. Toward. The. Light...

  10. shubham1206agra commented on Jan 6, 2025

    @shubham1206agra
    Contributor

    Since I have creds to the QBO connection, it has not been updated for 2 weeks for some reason. Let me take over this issue as a reviewer.

    @mkzie2's proposal looks good to me.

    🎀👀🎀 C+ reviewed

  11. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  12. 38 remaining items

  13. changed the title [-][HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle[/-] [+][Due for payment 2025-02-19] [HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle[/+] on Feb 12, 2025
  14. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @shubham1206agra requires payment (Needs manual offer from BZ)
    • @mkzie2 requires payment (Needs manual offer from BZ)
  16. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    @shubham1206agra @isabelastisser @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. mkzie2 commented on Aug 18, 2025

    @mkzie2
    Contributor

    Payments are processed in Upwork. all set!

    @isabelastisser The contract for me seems still unpaid, would you mind paying it out, thanks!

  18. isabelastisser commented on Aug 18, 2025

    @isabelastisser
    Contributor

    Hey @mkzie2, it shows that you're hired in Upwork. Do you have an option to accept the offer? Can you please get a screenshot of what you see on your end? Thanks!

  19. mkzie2 commented on Aug 20, 2025

    @mkzie2
    Contributor

    Do you have an option to accept the offer?

    No, as I accepted it before

    @isabelastisser The contract started but it was not paid out. Here's what I see.

    Image
  20. isabelastisser commented on Aug 21, 2025

    @isabelastisser
    Contributor

    Hi @mkzie2, the payment is now processed in Upwork, thanks!

    Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions