You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-19] [HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle #54436
Version Number: 9.0.76-12 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Workspace is connected to QBO.
Go to staging.new.expensify.com
Go to workspace settings > Accounting.
Click Export.
Click Export company card expenses as.
Click Export as.
Select Vendor bill.
Expected Result:
The hint text for Vendor bill is below the toggle (PR #43973) (this is also the same behavior in Advanced page).
Actual Result:
The hint text for Vendor bill is not below the toggle.
Edited by proposal-police: This proposal was edited at 2024-12-20 20:35:53 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The hint text for Vendor bill is not below the toggle.
What is the root cause of that problem?
We don't pass shouldPlaceSubtitleBelowSwitch to ToggleSettingOptionRow then the hint text is not displayed below the toggle. This happens after this PR where we missed this prop when implementing the offline pattern
We can check other places that use ToggleSettingOptionRow and pass the same prop if we want the hint text is also displayed below the toggle in this place.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@isabelastisser this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
changed the title [-][HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle[/-][+][Due for payment 2025-02-19] [HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle[/+]on Feb 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@shubham1206agra@isabelastisser@shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Hey @mkzie2, it shows that you're hired in Upwork. Do you have an option to accept the offer? Can you please get a screenshot of what you see on your end? Thanks!
Activity
melvin-bot commentedon Dec 20, 2024
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Dec 20, 2024
Edited by proposal-police: This proposal was edited at 2024-12-20 20:35:53 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The hint text for Vendor bill is not below the toggle.
What is the root cause of that problem?
We don't pass
shouldPlaceSubtitleBelowSwitchtoToggleSettingOptionRowthen the hint text is not displayed below the toggle. This happens after this PR where we missed this prop when implementing the offline patternApp/src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx
Line 70 in 01c0ad9
App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Line 167 in 01c0ad9
What changes do you think we should make in order to solve the problem?
Pass
shouldPlaceSubtitleBelowSwitchhereApp/src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx
Line 70 in 01c0ad9
We can check other places that use
ToggleSettingOptionRowand pass the same prop if we want the hint text is also displayed below the toggle in this place.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Dec 24, 2024
@isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Dec 26, 2024
@isabelastisser Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Dec 30, 2024
@isabelastisser Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
melvin-bot commentedon Jan 1, 2025
@isabelastisser 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Jan 3, 2025
@isabelastisser this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Jan 3, 2025
@isabelastisser 12 days overdue. Walking. Toward. The. Light...
shubham1206agra commentedon Jan 6, 2025
Since I have creds to the QBO connection, it has not been updated for 2 weeks for some reason. Let me take over this issue as a reviewer.
@mkzie2's proposal looks good to me.
🎀👀🎀 C+ reviewed
melvin-bot commentedon Jan 6, 2025
Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
38 remaining items
[-][HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle[/-][+][Due for payment 2025-02-19] [HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle[/+]melvin-bot commentedon Feb 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 12, 2025
@shubham1206agra @isabelastisser @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mkzie2 commentedon Aug 18, 2025
@isabelastisser The contract for me seems still unpaid, would you mind paying it out, thanks!
isabelastisser commentedon Aug 18, 2025
Hey @mkzie2, it shows that you're
hiredin Upwork. Do you have an option to accept the offer? Can you please get a screenshot of what you see on your end? Thanks!mkzie2 commentedon Aug 20, 2025
No, as I accepted it before
@isabelastisser The contract started but it was not paid out. Here's what I see.
isabelastisser commentedon Aug 21, 2025
Hi @mkzie2, the payment is now processed in Upwork, thanks!