Skip to content

[HOLD for payment 2025-01-15] Android - Chat - Emoji picker is jumpy when opened from context menu #54453

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.77-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component: Chat Report View

Action Performed:

  1. Launch ND or hybrid app
  2. Open DM
  3. Send a message to the DM if there is no message
  4. Tap on the composer if keyboard is not up
  5. Long tap on the message while keyboard is up
  6. Tap Add reaction button
  7. Might need to repeat Step 4 to 6 if the emoji picker is not jumpy

Expected Result:

Emoji picker will not be jumpy when opened from context menu when keyboard is opened

Actual Result:

Emoji picker is jumpy when opened from context menu when keyboard is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6700988_1734891250375.Screen_Recording_20241223_021231_Expensify.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Dec 22, 2024

    @melvin-bot

    Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Dec 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Dec 22, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. lanitochka17 commented on Dec 22, 2024

    @lanitochka17
    Author

    Production:

    Uploading Screenrecorder-2024-12-22-20-33-16-287.mp4…

  5. techievivek commented on Dec 23, 2024

    @techievivek
    Contributor

    Doesn't seem to be a backend bug so removing the Deployblocker label from it.

  6. 25 remaining items

  7. arosiclair commented on Jan 8, 2025

    @arosiclair
    Contributor

    @parasharrajat was the C+ for this

  8. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. parasharrajat commented on Jan 15, 2025

    @parasharrajat
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Not needed as it is a improvement over existing code.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/462308

    Regression Test Proposal

    Test:

    1. Launch ND or hybrid app
    2. Open DM
    3. Send a message to the DM if there is no message
    4. Tap on the composer if keyboard is not up
    5. Long tap on the message while keyboard is up
    6. Tap Add reaction button
    7. repeat Step 4 to 6 and be sure the emoji picker is not jumpy
    8. tap on Search field and make sure bottom sheet has an animated transition (for keyboard avoidance)

    Do we agree 👍 or 👎

  10. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    @arosiclair, @mallenexpensify, @kirillzyusko, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. kirillzyusko commented on Jan 17, 2025

    @kirillzyusko
    Contributor

    @danstepanov is working on this to fix 👀

  12. parasharrajat commented on Jan 17, 2025

    @parasharrajat
    Member

    This one is fixed. @kirillzyusko That is a different issue

  13. mallenexpensify commented on Jan 17, 2025

    @mallenexpensify
    Contributor
  14. parasharrajat commented on Jan 19, 2025

    @parasharrajat
    Member

    Payment requested as per #54453 (comment)

  15. JmillsExpensify commented on Jan 22, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions