Skip to content

[HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Icons are decolorized in security  #54480

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.78-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

  1. Open settings > Security, > observe the icon on top left

Expected Result:

Icons are displayed in color

Actual Result:

Icons are decolorized in security

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screenshot 2024-12-24 at 2 49 25 AM

Screenshot 2024-12-24 at 2 50 18 AM

Recording.863.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @anmurali

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 23, 2024
  2. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Dec 23, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 23, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. parasharrajat commented on Dec 23, 2024

    @parasharrajat
    Member

    This PR #52823 caused this issue.

    Here this line https://github.com/Expensify/App/pull/52823/files#diff-3ea703b86598917b6d2bd0c62d7489450ad5d73328aedb4596694419fcccc77eR185 we are now passing the default theme.icon to iconFill which overrides the color values.

  7. parasharrajat commented on Dec 23, 2024

    @parasharrajat
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Wrong color is shown for header icons.

    What is the root cause of that problem?

    We are not assigning a default value of theme.icon to all icons on Header via

    fill={iconFill ?? theme.icon}
    .

    THis change was added in #52823 to color TripDetails Page.

    What changes do you think we should make in order to solve the problem?

    1. We should remove the default value theme.icon from this prop at
      fill={iconFill ?? theme.icon}

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  8. allgandalf commented on Dec 24, 2024

    @allgandalf
    Contributor

    Proposal makes sense to me 👍

  9. 24 remaining items

  10. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@anmurali)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    @anmurali, @parasharrajat, @aldo-expensify Eep! 4 days overdue now. Issues have feelings too...

  12. parasharrajat commented on Jan 7, 2025

    @parasharrajat
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [vip-travel] Create Trip Details Screen #52823 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not needed

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Open settings.
    2. Open other settings pages e.g Security, Profile etc.
    3. Observe the icon on top left icon on the header.
    4. Icon should be colored.

    Do we agree 👍 or 👎

  13. anmurali commented on Jan 8, 2025

    @anmurali

    Payment Summary

  14. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    @anmurali, @parasharrajat, @aldo-expensify Eep! 4 days overdue now. Issues have feelings too...

  15. parasharrajat commented on Jan 13, 2025

    @parasharrajat
    Member

    @anmurali Please close this. I will request it later.

  16. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    @anmurali, @parasharrajat, @aldo-expensify Still overdue 6 days?! Let's take care of this!

  17. parasharrajat commented on Jan 19, 2025

    @parasharrajat
    Member

    Payment requested as per #54480 (comment)

  18. JmillsExpensify commented on Jan 22, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions