Skip to content

[HOLD for payment 2025-01-30] [$250] Trip - No "Cancellation policy" field in the car trip details #54536

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.78-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+0948501@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11
App Component: Other

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to trip room.
  3. Go to trip thread.
  4. Click View trip details.

Expected Result:

There should be a "Cancellation policy" field in the car trip details (it shows free cancellation on the travel site).

Actual Result:

There is no "Cancellation policy" field in the car trip details.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6701793_1735046264090.bandicam_2024-12-24_21-12-10-610.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021880243921286668938
  • Upwork Job ID: 1880243921286668938
  • Last Price Increase: 2025-01-17
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 24, 2024
  2. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 24, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. jasperhuangg commented on Dec 24, 2024

    @jasperhuangg
    Contributor

    This feature is locked behind a beta, so there's no need to block deploy on it. Assigning @blazejkustra to fix this since they worked on the PR introducing trip details.

  7. 88 remaining items

  8. changed the title [-][$250] Trip - No "Cancellation policy" field in the car trip details[/-] [+][HOLD for payment 2025-01-30] [$250] Trip - No "Cancellation policy" field in the car trip details[/+] on Jan 23, 2025
  9. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-30. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    @shubham1206agra @Christinadobrzyn @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. Christinadobrzyn commented on Jan 29, 2025

    @Christinadobrzyn
    Contributor

    Payment coming up - @shubham1206agra do we need a regression test for this?

  12. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@Christinadobrzyn)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1880243921286668938/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. Christinadobrzyn commented on Jan 30, 2025

    @Christinadobrzyn
    Contributor

    @shubham1206agra do you want to be paid through ND when you're eligible (looks like that's soon)?

    Do we need a regression test?

  14. shubham1206agra commented on Jan 30, 2025

    @shubham1206agra
    Contributor

    do you want to be paid through ND when you're eligible (looks like that's soon)?

    Nope, I have to be paid via upwork for this issue.

  15. shubham1206agra commented on Jan 30, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    Regression Test Proposal

    Precondition:

    Test:

    1. Go to App
    2. Go to trip room.
    3. Go to trip thread.
    4. Click View trip details.
    5. Verify that 'Free cancellation' is displayed in on details page

    Do we agree 👍 or 👎

  16. Christinadobrzyn commented on Jan 30, 2025

    @Christinadobrzyn
    Contributor

    Thanks @shubham1206agra can you please accept my Upwork offer - https://www.upwork.com/nx/wm/offer/105929364

  17. shubham1206agra commented on Jan 31, 2025

    @shubham1206agra
    Contributor

    @Christinadobrzyn Offer accepted

  18. Christinadobrzyn commented on Jan 31, 2025

    @Christinadobrzyn
    Contributor

    Thanks @shubham1206agra! This is paid out based on this payment summary - #54536 (comment)

    Closing as complete. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions