You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-30] [$250] Trip - No "Cancellation policy" field in the car trip details #54536
Version Number: 9.0.78-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+0948501@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Windows 11 App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This feature is locked behind a beta, so there's no need to block deploy on it. Assigning @blazejkustra to fix this since they worked on the PR introducing trip details.
changed the title [-][$250] Trip - No "Cancellation policy" field in the car trip details[/-][+][HOLD for payment 2025-01-30] [$250] Trip - No "Cancellation policy" field in the car trip details[/+]on Jan 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@shubham1206agra@Christinadobrzyn@shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Dec 24, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 24, 2024
Triggered auto assignment to @aldo-expensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 24, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 24, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
jasperhuangg commentedon Dec 24, 2024
This feature is locked behind a beta, so there's no need to block deploy on it. Assigning @blazejkustra to fix this since they worked on the PR introducing trip details.
88 remaining items
[-][$250] Trip - No "Cancellation policy" field in the car trip details[/-][+][HOLD for payment 2025-01-30] [$250] Trip - No "Cancellation policy" field in the car trip details[/+]melvin-bot commentedon Jan 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 23, 2025
@shubham1206agra @Christinadobrzyn @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Christinadobrzyn commentedon Jan 29, 2025
Payment coming up - @shubham1206agra do we need a regression test for this?
melvin-bot commentedon Jan 30, 2025
Payment Summary
Upwork Job
BugZero Checklist (@Christinadobrzyn)
Christinadobrzyn commentedon Jan 30, 2025
@shubham1206agra do you want to be paid through ND when you're eligible (looks like that's soon)?
Do we need a regression test?
shubham1206agra commentedon Jan 30, 2025
Nope, I have to be paid via upwork for this issue.
shubham1206agra commentedon Jan 30, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/52823/files#r1936078618
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/465877
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Christinadobrzyn commentedon Jan 30, 2025
Thanks @shubham1206agra can you please accept my Upwork offer - https://www.upwork.com/nx/wm/offer/105929364
shubham1206agra commentedon Jan 31, 2025
@Christinadobrzyn Offer accepted
Christinadobrzyn commentedon Jan 31, 2025
Thanks @shubham1206agra! This is paid out based on this payment summary - #54536 (comment)
Closing as complete. Thanks everyone!