Skip to content

[HOLD for payment 2025-01-24] Trip - Modify trip and Trip support button open the same page #54545

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.78-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #52823
Email or phone of affected tester (no customers): applausetester+0948501@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11
App Component: Other

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to trip room.
  3. Go to trip thread.
  4. Click View trip details.
  5. Click Modify trip.
  6. Click Trip support.

Expected Result:

Modify trip and Trip support button will open different page.

Actual Result:

Modify trip and Trip support button open the same page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6701783_1735045665139.bandicam_2024-12-24_21-04-29-350.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 24, 2024
  2. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 24, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 24, 2024
  7. 42 remaining items

  8. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-24. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    @shubham1206agra @Christinadobrzyn @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. Christinadobrzyn commented on Jan 23, 2025

    @Christinadobrzyn
    Contributor

    Payment day is coming up - Do we need a regression test @shubham1206agra?

  11. melvin-bot commented on Jan 24, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@Christinadobrzyn)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. Christinadobrzyn commented on Jan 24, 2025

    @Christinadobrzyn
    Contributor

    Ready for payment - is this a regression from #52823?

    @blazejkustra @shubham1206agra

  13. shubham1206agra commented on Jan 24, 2025

    @shubham1206agra
    Contributor

    @Christinadobrzyn Not really
    Since this was a design modification made later after the PR got merged

  14. Christinadobrzyn commented on Jan 24, 2025

    @Christinadobrzyn
    Contributor

    Awesome, thanks! Do we need a regression test?

  15. Christinadobrzyn commented on Jan 24, 2025

    @Christinadobrzyn
    Contributor
  16. shubham1206agra commented on Jan 24, 2025

    @shubham1206agra
    Contributor

    @Christinadobrzyn offer accepted

  17. shubham1206agra commented on Jan 24, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: Design spec changes

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    Regression Test Proposal

    Precondition:

    Test:

    1. Open App
    2. Go to trip room.
    3. Go to trip thread.
    4. Click View trip details.
    5. Click Modify trip.
    6. Verify that trip page opens in TravelDot.
    7. Click Trip support.
    8. Verify that trip support opens in TravelDot.

    Do we agree 👍 or 👎

  18. Christinadobrzyn commented on Jan 24, 2025

    @Christinadobrzyn
    Contributor

    Thank you @shubham1206agra! I created the regression test and paid this out based on this summary - #54545 (comment)

    Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions