Skip to content

[HOLD for payment 2025-01-13] Expense - Inconsistency in category and tax change system message when editing category #54559

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1012020@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Rules and Taxes are enabled.
  • There are two tax rates - A and B.
  • Tax rate A belongs to Workspace and Foreign currency default.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Categories.
  3. Click Advertising category.
  4. Click Default tax rate.
  5. Select Tax rate B.
  6. Go to workspace chat.
  7. Submit an expense without category.
  8. Go to transaction thread.
  9. Click Category and select Advertising.
  10. Note that the system message starts with tax rate first, then category.
  11. Click Category and select any other category.
  12. Note that the system message starts with category first, then tax rate.
  13. Click Category and click on the same category to unselect it.
  14. Note that the system message starts with tax rate first, then category.

Expected Result:

In Step 10, 12 and 14, when setting, changing and removing category from the expense, the system message should be consistent.

Actual Result:

When setting category (step 10), the system message starts with tax rate first, then category. The messages appear in two lines.

When changing category (step 12), the system message starts with category first, then tax rate. Both messages appear in one line.

When removing category (step 14), the system message starts with tax rate first, then category. The messages appear in two lines.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6701996_1735111142157.20241225_151152.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 25, 2024
  2. melvin-bot commented on Dec 25, 2024

    @melvin-bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Dec 25, 2024

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Dec 25, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 25, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Beamanator commented on Dec 25, 2024

    @Beamanator
    Contributor

    commented in the slack thread about the PR i think is responsible - prooobs this doesn't need to be a blocker 🤔

    cc @bernhardoj @MonilBhavsar in case y'all can take a look

  7. allgandalf commented on Dec 25, 2024

    @allgandalf
    Contributor

    prooobs this doesn't need to be a blocker

    Agree, functionality isn't affected by this regression !

  8. melvin-bot commented on Dec 25, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. 6 remaining items

  10. self-assigned this
    on Dec 26, 2024
  11. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @Beamanator, @MonilBhavsar, @bfitzexpensify Huh... This is 4 days overdue. Who can take care of this?

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 6, 2025
  13. changed the title [-]Expense - Inconsistency in category and tax change system message when editing category[/-] [+][HOLD for payment 2025-01-13] Expense - Inconsistency in category and tax change system message when editing category[/+] on Jan 6, 2025
  14. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-13. 🎊

  16. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @Beamanator / @MonilBhavsar @bfitzexpensify @Beamanator / @MonilBhavsar The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions