You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-13] Expense - Inconsistency in category and tax change system message when editing category #54559
Version Number: 9.0.78-2 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+kh1012020@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Rules and Taxes are enabled.
There are two tax rates - A and B.
Tax rate A belongs to Workspace and Foreign currency default.
Go to staging.new.expensify.com
Go to workspace settings > Categories.
Click Advertising category.
Click Default tax rate.
Select Tax rate B.
Go to workspace chat.
Submit an expense without category.
Go to transaction thread.
Click Category and select Advertising.
Note that the system message starts with tax rate first, then category.
Click Category and select any other category.
Note that the system message starts with category first, then tax rate.
Click Category and click on the same category to unselect it.
Note that the system message starts with tax rate first, then category.
Expected Result:
In Step 10, 12 and 14, when setting, changing and removing category from the expense, the system message should be consistent.
Actual Result:
When setting category (step 10), the system message starts with tax rate first, then category. The messages appear in two lines.
When changing category (step 12), the system message starts with category first, then tax rate. Both messages appear in one line.
When removing category (step 14), the system message starts with tax rate first, then category. The messages appear in two lines.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Expense - Inconsistency in category and tax change system message when editing category[/-][+][HOLD for payment 2025-01-13] Expense - Inconsistency in category and tax change system message when editing category[/+]on Jan 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Beamanator / @MonilBhavsar@bfitzexpensify@Beamanator / @MonilBhavsar The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Dec 25, 2024
Triggered auto assignment to @Beamanator (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 25, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 25, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 25, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Beamanator commentedon Dec 25, 2024
commented in the slack thread about the PR i think is responsible - prooobs this doesn't need to be a blocker 🤔
cc @bernhardoj @MonilBhavsar in case y'all can take a look
allgandalf commentedon Dec 25, 2024
Agree, functionality isn't affected by this regression !
melvin-bot commentedon Dec 25, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
6 remaining items
melvin-bot commentedon Jan 6, 2025
@Beamanator, @MonilBhavsar, @bfitzexpensify Huh... This is 4 days overdue. Who can take care of this?
[-]Expense - Inconsistency in category and tax change system message when editing category[/-][+][HOLD for payment 2025-01-13] Expense - Inconsistency in category and tax change system message when editing category[/+]melvin-bot commentedon Jan 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-13. 🎊
melvin-bot commentedon Jan 6, 2025
@Beamanator / @MonilBhavsar @bfitzexpensify @Beamanator / @MonilBhavsar The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jan 13, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.