Repository navigation
[HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Login - Infinite loading and no error message when typing wrong Magic Code. #54698
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+131@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Other
Action Performed:
- Open the staging.new.expensify.com website.
- Insert an account.
- Tap on "Continue"
- Wait for a Magic Code to be received.
- Type an incorrect Magic Code.
Expected Result:
An error message should be automatically displayed when typing an incorrect Magic Code on login screen.
Actual Result:
Infinite loading and no error message displayed when typing an incorrect Magic Code on login screen.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @marcaaron (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 1, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 1, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
daledah commentedon Jan 1, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Infinite loading and no error message displayed when typing an incorrect Magic Code on login screen.
What is the root cause of that problem?
Regression from: #52822
After login and enter the wrong magic code, we'll trigger update the failureData in
App/src/libs/actions/OnyxUpdates.ts
Line 55 in e5108a1
the failureData should update the isLoading to false
The
queuedOnyxUpdatescontains the Onyx.merge foraccountdata, but at that time, currentAccountID is undefined, so we will filter out all key exceptpreservedKeys. Unfortunately,preservedKeysdoesn't containaccountApp/src/libs/actions/QueuedOnyxUpdates.ts
Line 39 in e5108a1
so we still see the loading state
What changes do you think we should make in order to solve the problem?
accounttopreservedKeysaccountconditionally when account.isLoading is true (that means the user is logging in)What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We should update QueuedOnyxUpdatesTest.ts to cover this case.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Result
daledah commentedon Jan 1, 2025
@marcaaron @bfitzexpensify What do you think about my proposal? I can raise the quick PR.
melvin-bot commentedon Jan 1, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
28 remaining items
bfitzexpensify commentedon Jan 15, 2025
Offer sent @huult
@getusha, please complete the BZ checklist
bfitzexpensify commentedon Jan 17, 2025
Bump @getusha
melvin-bot commentedon Jan 21, 2025
@Beamanator, @huult, @bfitzexpensify, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jan 23, 2025
@Beamanator, @huult, @bfitzexpensify, @getusha Huh... This is 4 days overdue. Who can take care of this?
bfitzexpensify commentedon Jan 23, 2025
Another bump @getusha
melvin-bot commentedon Jan 27, 2025
@Beamanator, @huult, @bfitzexpensify, @getusha 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
getusha commentedon Jan 27, 2025
No need for payments here, it was a regression from #52822
I don't think we need a regression test since the changes in the PR that fix the issue are unlikely to be modified in a way that would reintroduce the issue.
melvin-bot commentedon Jan 31, 2025
@Beamanator, @huult, @bfitzexpensify, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!
Beamanator commentedon Feb 3, 2025
makes sense to me! closing this out 🙏