Skip to content

[HOLD for payment 2025-01-15] PR - Tooltip - The educational tooltip for a new account is wrong #54701

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54344
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 14.6.1
App Component: Other

Action Performed:

1.Log in as User A, an account that owns a workspace
2.Create a new account B
3.On A, Invite B to the workspace
4.On B, open the workspace chat

Expected Result:

The tooltip shows over the composer's Create button saying "Get started! Submit your first expense"

Actual Result:

The educational tooltip for a new account over the composer's Create button says "Submit your expense" instead of "Get started! Submit your first expense"

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704693_1735686882683.Recording__322.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 1, 2025
  2. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. huult commented on Jan 1, 2025

    @huult
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The educational tooltip for a new account is wrong

    What is the root cause of that problem?

    We are using the WORKSPACE_CHAT_CREATE name to render the composer

    const {renderProductTrainingTooltip, hideProductTrainingTooltip, shouldShowProductTrainingTooltip} = useProductTrainingContext(
    CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.WORKSAPCE_CHAT_CREATE,
    shouldShowEducationalTooltip,
    );

    [WORKSAPCE_CHAT_CREATE]: {
    content: [
    {text: 'productTrainingTooltip.workspaceChatCreate.part1', isBold: true},
    {text: 'productTrainingTooltip.workspaceChatCreate.part2', isBold: false},
    ],
    onHideTooltip: () => dismissProductTraining(WORKSAPCE_CHAT_CREATE),
    name: WORKSAPCE_CHAT_CREATE,
    priority: 1100,
    shouldShow: () => true,
    },

    and value text is Submit your and expenses

    App/src/languages/en.ts

    Lines 5593 to 5597 in e5108a1

    workspaceChatCreate: {
    part1: 'Submit your',
    part2: ' expenses',
    part3: ' here!',
    },

    What changes do you think we should make in order to solve the problem?

    To resolve this issue, we just need to update the translation as expected in this ticket.

    App/src/languages/en.ts

    Lines 5593 to 5597 in e5108a1

    workspaceChatCreate: {
    part1: 'Submit your',
    part2: ' expenses',
    part3: ' here!',
    },

            workspaceChatCreate: {
                part1: 'Get started! Submit your',
                part2: ' first expense',
                part3: ' here!',
            },
    Screenshot 2025-01-01 at 13 24 10

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    This is a translation issue; no unit test is needed

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. parasharrajat commented on Jan 1, 2025

    @parasharrajat
    Member

    Looks like a regression from #54263 cc: @ishpaul777

  5. ishpaul777 commented on Jan 2, 2025

    @ishpaul777
    Contributor

    @rayane-djouah fixed this in this PR #54710

  6. rayane-d commented on Jan 3, 2025

    @rayane-d
    Contributor

    Fixed in b7d5186

  7. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

  8. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. mallenexpensify commented on Jan 8, 2025

    @mallenexpensify
    Contributor

    Confirming I see the tooltip, so closing. If a regression penalty is owed from this, please comment on the Issue from the associated PR that caused it. Thx
    image

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 8, 2025
  14. changed the title [-]PR - Tooltip - The educational tooltip for a new account is wrong[/-] [+][HOLD for payment 2025-01-15] PR - Tooltip - The educational tooltip for a new account is wrong[/+] on Jan 8, 2025
  15. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-15. 🎊

  16. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions