Skip to content

[$250] Wallet -Order of bank & account holder fields is different on individual page and confirm page #54709

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+394034@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: User Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Wallet.
  3. Click Add bank account.
  4. Enter all the info and reach the confirmation page.

Expected Result:

The order of bank details and account holder details should be consistent on the individual page and confirmation page.

Actual Result:

On bank details page, the order of fields is Bank Name, Bank Address then Bank City.
On confirmation page, the order of fields is Bank Name, Bank City then Bank Address.

On account holder details page, the order of fields is Name, Address, City, then Country.
On confirmation page, the order of fields is Name, Country, Address, then City.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704721_1735699090299!Screenshot_2025-01-01_at_10 36 51
Bug6704721_1735699090321.20250101_103055.mp4
Bug6704721_1735699090319!Screenshot_2025-01-01_at_10 36 34 Bug6704721_1735699090324!Screenshot_2025-01-01_at_10 31 39

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021874487081797948415
  • Upwork Job ID: 1874487081797948415
  • Last Price Increase: 2025-01-01
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jan 1, 2025
  2. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 1, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. parasharrajat commented on Jan 1, 2025

    @parasharrajat
    Member

    Edited by proposal-police: This proposal was edited at 2025-01-01 12:43:01 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    1. We are not applying any sorting on both Step pages and Confirmation page. Code is using for...in and Object.values to loop through fields which does not maintain order.

    What changes do you think we should make in order to solve the problem?

    1. We can apply a simple sorting to corpayFields?.formFields in getFieldsMap before grouping for each step. Sorting can be done on label key.
      return (corpayFields?.formFields ?? []).reduce((acc, field) => {

    This will preserve the order across pages.

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. 5 remaining items

  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 1, 2025
  9. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  10. shubham1206agra commented on Jan 2, 2025

    @shubham1206agra
    Contributor

    @MonilBhavsar Please assign this to me too. I will also take this in cleanup issue.

  11. parasharrajat commented on Jan 2, 2025

    @parasharrajat
    Member

    Main PR was reverted so this issue is no more present.

  12. MitchExpensify commented on Jan 3, 2025

    @MitchExpensify
    Contributor

    Are you saying this can be closed @parasharrajat ?

  13. parasharrajat commented on Jan 3, 2025

    @parasharrajat
    Member

    Yeah, it should be after retesting.

  14. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    @carlosmiceli, @hoangzinh, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. hoangzinh commented on Jan 7, 2025

    @hoangzinh
    Contributor

    Agreed the offending PR was reverted. @shubham1206agra already added this issue into his todo list. We can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions