You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Wallet -Order of bank & account holder fields is different on individual page and confirm page #54709
Version Number: 9.0.80-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+394034@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: User Settings
Action Performed:
Go to staging.new.expensify.com
Go to Account settings > Wallet.
Click Add bank account.
Enter all the info and reach the confirmation page.
Expected Result:
The order of bank details and account holder details should be consistent on the individual page and confirmation page.
Actual Result:
On bank details page, the order of fields is Bank Name, Bank Address then Bank City.
On confirmation page, the order of fields is Bank Name, Bank City then Bank Address.
On account holder details page, the order of fields is Name, Address, City, then Country.
On confirmation page, the order of fields is Name, Country, Address, then City.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Edited by proposal-police: This proposal was edited at 2025-01-01 12:43:01 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We are not applying any sorting on both Step pages and Confirmation page. Code is using for...in and Object.values to loop through fields which does not maintain order.
What changes do you think we should make in order to solve the problem?
We can apply a simple sorting to corpayFields?.formFields in getFieldsMap before grouping for each step. Sorting can be done on label key.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 1, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 1, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
parasharrajat commentedon Jan 1, 2025
Edited by proposal-police: This proposal was edited at 2025-01-01 12:43:01 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
for...inandObject.valuesto loop through fields which does not maintain order.What changes do you think we should make in order to solve the problem?
corpayFields?.formFieldsingetFieldsMapbefore grouping for each step. Sorting can be done onlabelkey.App/src/pages/settings/Wallet/InternationalDepositAccount/utils.ts
Line 16 in e5108a1
This will preserve the order across pages.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
5 remaining items
melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)shubham1206agra commentedon Jan 2, 2025
@MonilBhavsar Please assign this to me too. I will also take this in cleanup issue.
parasharrajat commentedon Jan 2, 2025
Main PR was reverted so this issue is no more present.
MitchExpensify commentedon Jan 3, 2025
Are you saying this can be closed @parasharrajat ?
parasharrajat commentedon Jan 3, 2025
Yeah, it should be after retesting.
melvin-bot commentedon Jan 7, 2025
@carlosmiceli, @hoangzinh, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
hoangzinh commentedon Jan 7, 2025
Agreed the offending PR was reverted. @shubham1206agra already added this issue into his todo list. We can close this issue