You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
iOS - Edit composer is hidden behind keyboard when editing message #54712
Version Number: 9.0.80-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+394034@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.2 App Component: Chat Report View
Action Performed:
Launch ND or hybrid app.
Go to any chat that is scrollable.
Send a message.
Swipe down on the composer to dismiss the keyboard.
Long tap on the message > Edit comment.
Expected Result:
The edit composer will scroll to above the keyboard so that the edit composer is visible when editing the message.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This logic is intended to scroll to the editing message after the keyboard is displayed. However, using InteractionManager.runAfterInteractions does not guarantee that the keyboard is fully visible before calling reportScrollManager.scrollToIndex(index, true).
The bug occurs inconsistently and is not easily reproducible.
What changes do you think we should make in order to solve the problem?
We can wait for the keyboard to be fully displayed before scrolling. To achieve this, we can use:
We could consider applying the logic separately for web and native platforms. On the web, we can retain the current logic, while for native, we could implement the updated approach. However, since editing on the web does not involve scrolling, it seems unnecessary to make any changes there.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
On spending some more time on testing, I notice that the edit composer does get covered to some extent although I do not see it covered completely as described in the issue. But seems like solving it would also solve the issue here. Also, I notice quick jump up and down instead of a smooth one. @kirillzyusko Do you also notice this?
Activity
melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @Beamanator (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 1, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 1, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Beamanator commentedon Jan 1, 2025
Seems likely that this is related to #42143 🤔 - posted in slack thread
rojiphil commentedon Jan 1, 2025
Just checked but It does not look like it is related to this and I cannot reproduce it as well. Or maybe we need more information to reproduce.
42143-ios-st-no-rep.mp4
truph01 commentedon Jan 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/pages/home/report/ReportActionItemMessageEdit.tsx
Lines 528 to 532 in 754817d
This logic is intended to scroll to the editing message after the keyboard is displayed. However, using
InteractionManager.runAfterInteractionsdoes not guarantee that the keyboard is fully visible before callingreportScrollManager.scrollToIndex(index, true).What changes do you think we should make in order to solve the problem?
instead of the current logic.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
rojiphil commentedon Jan 2, 2025
On spending some more time on testing, I notice that the edit composer does get covered to some extent although I do not see it covered completely as described in the issue. But seems like solving it would also solve the issue here. Also, I notice quick jump up and down instead of a smooth one.
@kirillzyusko Do you also notice this?
42143-ios-st-rep.mp4
kirillzyusko commentedon Jan 2, 2025
@rojiphil In my case it's reproducible only in release variant. In debug everything works well 🤷♂️
Will try to search for a solution 👀
Beamanator commentedon Jan 2, 2025
Seems like the PR was reverted 😅
kirillzyusko commentedon Jan 2, 2025
Unfortunately 😔
Beamanator commentedon Jan 2, 2025
Can't reproduce anymore due to revert 👍 🤷