You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Invoice - The Add bank account button is not displayed in the invoice report #54723
Version Number: 9.0.80-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#54138 Issue reported by: Applause Internal Team Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14 App Component: Other
Action Performed:
Go to staging.new.expensify.com
Create a workspace if needed
Go to More features, scroll down and enable Invoices
Click green plus, Send invoice
Send an invoice to User B
As User B, go to invoice chat and pay the invoice as business > Pay elsewhere
As User A, go to invoice report
Expected Result:
The Add bank account button is displayed in the invoice report.
Actual Result:
The Add bank account button is not displayed in the invoice report on User A end.
Hmm, I’m wondering if this is even a bug.. If the invoice is marked as Paid elsewhere or settled, it might not make sense to display the Add bank account button. We should confirm the expected behavior for this scenario.
@ikevin127 Looks like you PR is contradicting with this issue #53802.
@parasharrajat Weird, we should have somebody from the team chime in and tell us what's the expected behaviour according to design doc, because the Expected result of issue:
No GBR should appear for "Add a bank account" if:
The invoice was marked as "Paid elsewhere."
Bank accounts are already configured in the workspace.
whereas this issue is asking for a revert of that, which to me doesn't make much sense.
cc @cristipaval@garrettmknight from the other issue, maybe you can help us with a decision regarding this confusion, or call-in somebody with more context on the matter
I don't agree with the Expected result in this issue. There's no pending money reimbursement to the payee, since the invoice is paid elsewhere, so no bank account need to be added. We'll solve this issue when we finish the Invoice payments with Stripe.
Activity
melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.ijmalik commentedon Jan 1, 2025
Related PR: Fix: Remove GBR and 'Add a bank account' for paid invoices #53802
The current issue appears to be linked to the changes introduced in this PR.
parasharrajat commentedon Jan 1, 2025
@ikevin127 Looks like you PR is contradicting with this issue #53802.
Shahidullah-Muffakir commentedon Jan 1, 2025
Hmm, I’m wondering if this is even a bug.. If the invoice is marked as Paid elsewhere or settled, it might not make sense to display the Add bank account button. We should confirm the expected behavior for this scenario.
hokkekyo commentedon Jan 1, 2025
I was able to reproduce the PR, but the steps were not exact.
5 .Send an invoice to User B
Fix_new_individual_invoice_after_one_is_paid_as_a_business__54138.mp4
ikevin127 commentedon Jan 1, 2025
@parasharrajat Weird, we should have somebody from the team chime in and tell us what's the expected behaviour according to design doc, because the Expected result of issue:
clearly stated:
whereas this issue is asking for a revert of that, which to me doesn't make much sense.
cc @cristipaval @garrettmknight from the other issue, maybe you can help us with a decision regarding this confusion, or call-in somebody with more context on the matter
cristipaval commentedon Jan 2, 2025
I don't agree with the Expected result in this issue. There's no pending money reimbursement to the payee, since the invoice is paid elsewhere, so no bank account need to be added. We'll solve this issue when we finish the Invoice payments with Stripe.