Skip to content

Invoice - The Add bank account button is not displayed in the invoice report #54723

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #54138
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace if needed
  3. Go to More features, scroll down and enable Invoices
  4. Click green plus, Send invoice
  5. Send an invoice to User B
  6. As User B, go to invoice chat and pay the invoice as business > Pay elsewhere
  7. As User A, go to invoice report

Expected Result:

The Add bank account button is displayed in the invoice report.

Actual Result:

The Add bank account button is not displayed in the invoice report on User A end.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704799_1735743493413.No_Add_bank_account_button.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 1, 2025
  2. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. ijmalik commented on Jan 1, 2025

    @ijmalik
    Contributor

    Related PR: Fix: Remove GBR and 'Add a bank account' for paid invoices #53802

    The current issue appears to be linked to the changes introduced in this PR.

  4. parasharrajat commented on Jan 1, 2025

    @parasharrajat
    Member

    @ikevin127 Looks like you PR is contradicting with this issue #53802.

  5. Shahidullah-Muffakir commented on Jan 1, 2025

    @Shahidullah-Muffakir
    Contributor

    Hmm, I’m wondering if this is even a bug.. If the invoice is marked as Paid elsewhere or settled, it might not make sense to display the Add bank account button. We should confirm the expected behavior for this scenario.

  6. hokkekyo commented on Jan 1, 2025

    @hokkekyo

    I was able to reproduce the PR, but the steps were not exact.

    1. Go to staging.new.expensify.com
    2. Create a workspace if needed
    3. Go to More features, scroll down and enable Invoices
    4. Click green plus, Send invoice
      5 .Send an invoice to User B
    5. As User B Go to invoice chat and pay the invoice as business
    6. [User A] Go to invoice report (It is not possible to execute)
    7. [User A] Click Add bank account (It is not possible to execute)
    8. [User A] In settings Add bank account (It is not possible to execute)
    9. Go to Settings > WS > Click on the WS > Invoices > Click on the bank account for invoicing and choose to make it the default
    10. Click the green plus, send a $2 to user B
    11. Open the invoice report and verify it loads successfully
    Fix_new_individual_invoice_after_one_is_paid_as_a_business__54138.mp4
  7. ikevin127 commented on Jan 1, 2025

    @ikevin127
    Contributor

    @ikevin127 Looks like you PR is contradicting with this issue #53802.

    @parasharrajat Weird, we should have somebody from the team chime in and tell us what's the expected behaviour according to design doc, because the Expected result of issue:

    clearly stated:

    No GBR should appear for "Add a bank account" if:
    The invoice was marked as "Paid elsewhere."
    Bank accounts are already configured in the workspace.

    whereas this issue is asking for a revert of that, which to me doesn't make much sense.

    cc @cristipaval @garrettmknight from the other issue, maybe you can help us with a decision regarding this confusion, or call-in somebody with more context on the matter

  8. cristipaval commented on Jan 2, 2025

    @cristipaval
    Contributor

    I don't agree with the Expected result in this issue. There's no pending money reimbursement to the payee, since the invoice is paid elsewhere, so no bank account need to be added. We'll solve this issue when we finish the Invoice payments with Stripe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions