Skip to content

[$250] Wallet - Excluded countries and their currencies are shown #54741

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.80-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #52322
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: User Settings

Action Performed:

  1. Login to NewDot.
  2. Go to Settings > Wallet > Add bank account.
  3. Click Add bank account.
  4. Notice you are able to select excluded countries like Iran, Cuba, Syria, Ukraine, North Korea
  5. Click Next.
  6. Go to currency selector page.
    Notice IRR, SYP, KPW, CUP, and UAH currencies are shown

Based on Step 4 and 13 on the QA Document
Iran, Cuba, Syria, Ukraine, North Korea are not shown in country selector page and IRR, SYP, KPW, CUP, and UAH currencies are not shown in the currency selector page

Expected Result:

Iran, Cuba, Syria, Ukraine, North Korea are not shown in country selector page and IRR, SYP, KPW, CUP, and UAH currencies are not shown in the currency selector page

Actual Result:

Iran, Cuba, Syria, Ukraine, North Korea are shown in country selector page and IRR, SYP, KPW, CUP, and UAH currencies are shown in the currency selector page

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704920_1735783957336.Screen_Recording_2025-01-02_at_5.03.20_at_night.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @parasharrajat
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021877293134217416084
  • Upwork Job ID: 1877293134217416084
  • Last Price Increase: 2025-01-09

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 2, 2025
  2. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 2, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. laurenreidexpensify commented on Jan 2, 2025

    @laurenreidexpensify
    Contributor

    @madmax330 I don't think this is a real deploy blocker right?

  7. Beamanator commented on Jan 2, 2025

    @Beamanator
    Contributor

    Agreed 👍 I will help demote

  8. 5 remaining items

  9. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @madmax330, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    @madmax330, @laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?

  11. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 9, 2025
  12. changed the title [-] Wallet - Excluded countries and their currencies are shown[/-] [+][$250] Wallet - Excluded countries and their currencies are shown[/+] on Jan 9, 2025
  13. melvin-bot commented on Jan 9, 2025

    @melvin-bot
  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 9, 2025
  15. melvin-bot commented on Jan 9, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  16. shubham1206agra commented on Jan 9, 2025

    @shubham1206agra
    Contributor

    Umm. This is awkward. But this is already being fixed.

  17. madmax330 commented on Jan 9, 2025

    @madmax330
    Contributor

    Can you link the issue, then we can close this?

  18. shubham1206agra commented on Jan 9, 2025

    @shubham1206agra
    Contributor
  19. madmax330 commented on Jan 9, 2025

    @madmax330
    Contributor
  20. JustFocus99 commented on Jan 9, 2025

    @JustFocus99

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Some invalid countries and their currencies are displayed when the user selects the bank account.

    What is the root cause of that problem?

    This issue is displayed because these countries and currencies information are included the code such as CONST.ts and currencyList.json.

    What changes do you think we should make in order to solve the problem?

    These countries information need to delete in the CONST.ts file, and then their currencies information need to delete in the currencyList.json.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions