Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.80-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #52322
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: User Settings
Action Performed:
- Login to NewDot.
- Go to Settings > Wallet > Add bank account.
- Click Add bank account.
- Notice you are able to select excluded countries like Iran, Cuba, Syria, Ukraine, North Korea
- Click Next.
- Go to currency selector page.
Notice IRR, SYP, KPW, CUP, and UAH currencies are shown
Based on Step 4 and 13 on the QA Document
Iran, Cuba, Syria, Ukraine, North Korea are not shown in country selector page and IRR, SYP, KPW, CUP, and UAH currencies are not shown in the currency selector page
Expected Result:
Iran, Cuba, Syria, Ukraine, North Korea are not shown in country selector page and IRR, SYP, KPW, CUP, and UAH currencies are not shown in the currency selector page
Actual Result:
Iran, Cuba, Syria, Ukraine, North Korea are shown in country selector page and IRR, SYP, KPW, CUP, and UAH currencies are shown in the currency selector page
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6704920_1735783957336.Screen_Recording_2025-01-02_at_5.03.20_at_night.mp4
Issue Owner
Current Issue Owner: @parasharrajatUpwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021877293134217416084
- Upwork Job ID: 1877293134217416084
- Last Price Increase: 2025-01-09
Activity
melvin-bot commentedon Jan 2, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 2, 2025
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 2, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 2, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
laurenreidexpensify commentedon Jan 2, 2025
@madmax330 I don't think this is a real deploy blocker right?
Beamanator commentedon Jan 2, 2025
Agreed 👍 I will help demote
5 remaining items
melvin-bot commentedon Jan 6, 2025
@madmax330, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jan 8, 2025
@madmax330, @laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?
[-] Wallet - Excluded countries and their currencies are shown[/-][+][$250] Wallet - Excluded countries and their currencies are shown[/+]melvin-bot commentedon Jan 9, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021877293134217416084
melvin-bot commentedon Jan 9, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)shubham1206agra commentedon Jan 9, 2025
Umm. This is awkward. But this is already being fixed.
madmax330 commentedon Jan 9, 2025
Can you link the issue, then we can close this?
shubham1206agra commentedon Jan 9, 2025
#54798
madmax330 commentedon Jan 9, 2025
cc @MonilBhavsar
JustFocus99 commentedon Jan 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Some invalid countries and their currencies are displayed when the user selects the bank account.
What is the root cause of that problem?
This issue is displayed because these countries and currencies information are included the code such as CONST.ts and currencyList.json.
What changes do you think we should make in order to solve the problem?
These countries information need to delete in the CONST.ts file, and then their currencies information need to delete in the currencyList.json.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A