Skip to content

[$250] Wallet - In offline mode, no full blocking view in country page, country & currency are editable #54746

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-3
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #52322
Email or phone of affected tester (no customers): applausetester+394034@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: User Settings

Action Performed:

Bug 1:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Wallet.
  3. Go offline.
  4. Click Add bank account.

Bug 2:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Wallet.
  3. Click Add bank account.
  4. Select a country > Next.
  5. Go offline.
  6. Click Currency.
  7. Select any currency.

Bug 3:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Wallet.
  3. Click Add bank account.
  4. Select a country > Next.
  5. Enter info and reach the confirmation page.
  6. Go offline.
  7. Click Country and Currency field.

Expected Result:

Acording to this doc https://docs.google.com/document/d/1H1hMnTcMrR8MT6BXz3fCE99eVIurgrHDtaxIH5aW8Ug/edit?tab=t.0,

Bug 1:
There will be full page pattern online blocking view.

Bug 2:
Currency field should be disabled because currency should not be editable in offline mode.

Bug 3:
Country and Currency field should be disabled on the confirmation page in offline mode.

Actual Result:

Bug 1:
RHP shows country list instead of full page pattern online blocking view.

Bug 2:
Currency field is not disabled and it loads infinitely when selecting a currency in offline mode.

Bug 3:
Country and Currency field are not disabled on the confirmation page in offline mode.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704992_1735808877702.20250102_165200.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021876246528156104323
  • Upwork Job ID: 1876246528156104323
  • Last Price Increase: 2025-01-06
  • Automatic offers:
    • DylanDylann | Reviewer | 105641591
    • shubham1206agra | Contributor | 105641593
Issue OwnerCurrent Issue Owner: @Ollyws

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 2, 2025
  2. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 2, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 2, 2025
  7. 35 remaining items

  8. melvin-bot commented on Jan 16, 2025

    @melvin-bot

    @Julesssss @Ollyws @sonialiap @shubham1206agra @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  9. melvin-bot commented on Jan 16, 2025

    @melvin-bot

    @Julesssss, @Ollyws, @sonialiap, @shubham1206agra, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

  10. Julesssss commented on Jan 16, 2025

    @Julesssss
    Contributor

    Not overdue

  11. shubham1206agra commented on Jan 16, 2025

    @shubham1206agra
    Contributor

    @shubham1206agra Let's also display no full blocking view on currency page if offline. Currently, if we select another currency offline, the infinity loading will happen
    Screen.Recording.2025-01-16.at.14.10.29.mov

    Done

  12. melvin-bot commented on Jan 20, 2025

    @melvin-bot

    @Julesssss, @Ollyws, @sonialiap, @shubham1206agra, @DylanDylann Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  13. Julesssss commented on Jan 21, 2025

    @Julesssss
    Contributor

    Hey @shubham1206agra, I'm struggling to find the PR here, would you mind sharing it? Thanks

  14. shubham1206agra commented on Jan 22, 2025

    @shubham1206agra
    Contributor
  15. melvin-bot commented on Jan 22, 2025

    @melvin-bot

    @Julesssss, @Ollyws, @sonialiap, @shubham1206agra, @DylanDylann 10 days overdue. I'm getting more depressed than Marvin.

  16. Julesssss commented on Jan 22, 2025

    @Julesssss
    Contributor

    #54798

    Thanks @shubham1206agra. Please confirm that we should as this issue to the list of fixed issues within that PR.

  17. melvin-bot commented on Jan 24, 2025

    @melvin-bot

    @Julesssss, @Ollyws, @sonialiap, @shubham1206agra, @DylanDylann 12 days overdue. Walking. Toward. The. Light...

  18. shubham1206agra commented on Jan 25, 2025

    @shubham1206agra
    Contributor

    @sonialiap @Julesssss Please close this issue. No payment required here.

  19. MonilBhavsar commented on Jan 25, 2025

    @MonilBhavsar
    Contributor

    Nice, thank you!

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions