Skip to content

Per diem - Confirmation page shows per diem confirm page when it is a manual expense #54830

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.81-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+2390223d@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace A does not have Per diem rates.
  • Workspace B has Per diem rates.

1.Go to staging.new.expensify.com
2.Go to workspace chat A.
3.Click + > Submit expense > Manual.
4. Enter amount > Next.
5.Note that the confirmation page is manual expense confirmation page.
6.Go to workspace chat B.
7. Click + > Submit expense > Per diem.
8. Select a country > Next.
9. Close the RHP.
10. Go back to workspace chat A.
11. Click + > Submit expense > Manual.
12. Enter amount > Next.

Expected Result:

The confirmation page should be the manual expense confirmation page.

Actual Result:

The confirmation page is per diem expense confirmation page when it is a manual expense.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6707505_1736190927509.20250107_024336.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 6, 2025
  2. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 6, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. francoisl commented on Jan 6, 2025

    @francoisl
    Contributor

    Sounds like it's likely coming from #54252 since it's the new per diem feature that just got merged.
    @shubham1206agra any idea?

  7. shubham1206agra commented on Jan 6, 2025

    @shubham1206agra
    Contributor

    Discussed here https://expensify.enterprise.slack.com/archives/C02NK2DQWUX/p1736099605071479?thread_ts=1736099605.071479&cid=C02NK2DQWUX

    The bug has already been patched in the upcoming PR.

    You can mark this as NAB as this feature is behind beta.

  8. francoisl commented on Jan 6, 2025

    @francoisl
    Contributor

    Sounds good, thanks!

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 6, 2025
  10. shubham1206agra commented on Jan 7, 2025

    @shubham1206agra
    Contributor

    Will be fixed in 35c0bd7

  11. greg-schroeder commented on Jan 9, 2025

    @greg-schroeder
    Contributor

    Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions