Skip to content

[HOLD for payment 2025-01-28] Per diem - Subrate quantity field has no limitation #54834

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.81-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54252
Email or phone of affected tester (no customers): applausetester+2390223d@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component: Money Requests

Action Performed:

Precondition:

  • Workspace has per diem rates
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Click + > Submit expense > Per diem
  4. Select a country, select valid date and time and click Next
  5. Select a subrate
  6. On quantity field, enter a lot of numbers
  7. Click Next

Expected Result:

There should be limitation on the quantity field

Actual Result:

There is limitation on the quantity field
When entering big number and reaching the next page, the quantity field shows xe+y format

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6707542_1736193313242.20250107_035124.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jan 6, 2025
  2. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Jan 6, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. aldo-expensify commented on Jan 6, 2025

    @aldo-expensify
    Contributor

    Was able to reproduce, but this seems more like a front end issue.
    It is not possible to create PerDiem expense in production yet.

  6. dangrous commented on Jan 6, 2025

    @dangrous
    Contributor

    @ishpaul777 @Gonals @c3024 @shubham1206agra I see you worked on the implementation of Per Diem expenses.

    Is this a big enough bug to block deploy, or can we move forward? (is the feature under beta?)

    Also, does one of you want to tackle this?

    Thanks!

  7. ishpaul777 commented on Jan 6, 2025

    @ishpaul777
    Contributor

    👋Hey @dangrous, I was not involved in the PR

  8. c3024 commented on Jan 7, 2025

    @c3024
    Contributor

    I don't think this is significant enough to block deploy. Moreover, this is behind a beta.

    We can restrict each subrate quantity to less than the trip length with getTimeDifferenceIntervals of PerDiemRequestUtils and validate it.

    @shubham1206agra , I think this can be changed in the follow-up PRs.

    @dangrous, please assign us. Thanks!

  9. shubham1206agra commented on Jan 7, 2025

    @shubham1206agra
    Contributor

    @c3024 I don't think restriction based on getTimeDifferenceIntervals is a good idea.

    I am going to introduce an upper bound limit of 12 digits. Since it will guarantee the number will be less than Number.MAX_SAFE_INTEGER, which will help us store lossless integers.

  10. shubham1206agra commented on Jan 7, 2025

    @shubham1206agra
    Contributor

    Will be fixed in c3688b4

  11. 12 remaining items

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 21, 2025
  13. changed the title [-]Per diem - Subrate quantity field has no limitation[/-] [+][HOLD for payment 2025-01-28] Per diem - Subrate quantity field has no limitation[/+] on Jan 21, 2025
  14. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @shubham1206agra requires payment (Needs manual offer from BZ)
    • @c3024 requires payment through NewDot Manual Requests
  16. shubham1206agra commented on Jan 25, 2025

    @shubham1206agra
    Contributor

    @Gonals Please close this issue. No payment required here.

  17. added
    ReviewingHas a PR in review
    and removed on Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions