You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-28] Per diem - Subrate quantity field has no limitation #54834
Version Number: 9.0.81-0 Reproducible in staging?: Y Reproducible in production?: Unable to check If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:#54252 Email or phone of affected tester (no customers):applausetester+2390223d@applause.expensifail.com Issue reported by: Applause - Internal Team Component: Money Requests
Action Performed:
Precondition:
Workspace has per diem rates
Go to staging.new.expensify.com
Go to workspace chat
Click + > Submit expense > Per diem
Select a country, select valid date and time and click Next
Select a subrate
On quantity field, enter a lot of numbers
Click Next
Expected Result:
There should be limitation on the quantity field
Actual Result:
There is limitation on the quantity field
When entering big number and reaching the next page, the quantity field shows xe+y format
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6707542_1736193313242.20250107_035124.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@c3024 I don't think restriction based on getTimeDifferenceIntervals is a good idea.
I am going to introduce an upper bound limit of 12 digits. Since it will guarantee the number will be less than Number.MAX_SAFE_INTEGER, which will help us store lossless integers.
changed the title [-]Per diem - Subrate quantity field has no limitation[/-][+][HOLD for payment 2025-01-28] Per diem - Subrate quantity field has no limitation[/+]on Jan 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Jan 6, 2025
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 6, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 6, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
aldo-expensify commentedon Jan 6, 2025
Was able to reproduce, but this seems more like a front end issue.
It is not possible to create PerDiem expense in production yet.
dangrous commentedon Jan 6, 2025
@ishpaul777 @Gonals @c3024 @shubham1206agra I see you worked on the implementation of Per Diem expenses.
Is this a big enough bug to block deploy, or can we move forward? (is the feature under beta?)
Also, does one of you want to tackle this?
Thanks!
ishpaul777 commentedon Jan 6, 2025
👋Hey @dangrous, I was not involved in the PR
c3024 commentedon Jan 7, 2025
I don't think this is significant enough to block deploy. Moreover, this is behind a beta.
We can restrict each subrate quantity to less than the trip length with
getTimeDifferenceIntervalsofPerDiemRequestUtilsand validate it.@shubham1206agra , I think this can be changed in the follow-up PRs.
@dangrous, please assign us. Thanks!
shubham1206agra commentedon Jan 7, 2025
@c3024 I don't think restriction based on
getTimeDifferenceIntervalsis a good idea.I am going to introduce an upper bound limit of 12 digits. Since it will guarantee the number will be less than
Number.MAX_SAFE_INTEGER, which will help us store lossless integers.shubham1206agra commentedon Jan 7, 2025
Will be fixed in c3688b4
12 remaining items
[-]Per diem - Subrate quantity field has no limitation[/-][+][HOLD for payment 2025-01-28] Per diem - Subrate quantity field has no limitation[/+]melvin-bot commentedon Jan 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-28. 🎊
For reference, here are some details about the assignees on this issue:
shubham1206agra commentedon Jan 25, 2025
@Gonals Please close this issue. No payment required here.