Skip to content

[Due for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves #54836

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.81-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+2390223d@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Invoice feature is enabled.
  1. Go to staging.new.expensify.com
  2. Go to FAB > Send invoice.
  3. Enter amount > Next.
  4. Select the contact under "Personal", which is yourself.
  5. Send the invoice.

Expected Result:

User should not be able to send the invoice to themselves (production behavior).

Actual Result:

User is able to send the invoice to themselves. The "invoice" is sent to self DM and becomes a track expense.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6707525_1736191985891.20250107_032904.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 6, 2025
  2. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 6, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. IuliiaHerets commented on Jan 6, 2025

    @IuliiaHerets
    Author

    Production behaviour

    bandicam.2025-01-06.23-12-25-825.mp4
  7. chiragsalian commented on Jan 6, 2025

    @chiragsalian
    Contributor

    I believe the issue has come from this PR - #53760
    I tested the revert PR locally and this issue was resolved. cc @JKobrynski @VickyStash @grgia @mountiny, do you guys want to investigate the proper fix? If we cannot fix it soon i will proceed to revert the PR to give us more time to test the fixes properly. Let me know.

  8. JKobrynski commented on Jan 7, 2025

    @JKobrynski
    Contributor

    Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

  9. 28 remaining items

  10. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-17. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    @chiragsalian / @grgia @RachCHopkins @JKobrynski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. JKobrynski commented on Jan 10, 2025

    @JKobrynski
    Contributor

    Update:

    I updated the PR, it's now ready for review!

  14. JKobrynski commented on Jan 16, 2025

    @JKobrynski
    Contributor

    Update:

    I fixed merge conflicts, lint issues and applied changes requested by reviewers. The PR is once again waiting for review.

  15. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  16. changed the title [-][HOLD for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves[/-] [+][Due for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves[/+] on Jan 20, 2025
  17. JKobrynski commented on Jan 20, 2025

    @JKobrynski
    Contributor

    Update:

    I applied a small change requested by @trjExpensify. Unfortunately new conflicts appeared right after that. They couldn't be fixed quickly as they directly influence the changes that I introduced in OptionsListUtils.ts. I will continue my work on it tomorrow.

  18. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    @chiragsalian, @RachCHopkins, @grgia, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions