You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves #54836
Version Number: 9.0.81-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+2390223d@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Invoice feature is enabled.
Go to staging.new.expensify.com
Go to FAB > Send invoice.
Enter amount > Next.
Select the contact under "Personal", which is yourself.
Send the invoice.
Expected Result:
User should not be able to send the invoice to themselves (production behavior).
Actual Result:
User is able to send the invoice to themselves. The "invoice" is sent to self DM and becomes a track expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I believe the issue has come from this PR - #53760
I tested the revert PR locally and this issue was resolved. cc @JKobrynski@VickyStash@grgia@mountiny, do you guys want to investigate the proper fix? If we cannot fix it soon i will proceed to revert the PR to give us more time to test the fixes properly. Let me know.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@chiragsalian / @grgia@RachCHopkins@JKobrynski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
changed the title [-][HOLD for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves[/-][+][Due for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves[/+]on Jan 20, 2025
I applied a small change requested by @trjExpensify. Unfortunately new conflicts appeared right after that. They couldn't be fixed quickly as they directly influence the changes that I introduced in OptionsListUtils.ts. I will continue my work on it tomorrow.
Activity
melvin-bot commentedon Jan 6, 2025
Triggered auto assignment to @chiragsalian (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 6, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 6, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 6, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Jan 6, 2025
Production behaviour
bandicam.2025-01-06.23-12-25-825.mp4
chiragsalian commentedon Jan 6, 2025
I believe the issue has come from this PR - #53760
I tested the revert PR locally and this issue was resolved. cc @JKobrynski @VickyStash @grgia @mountiny, do you guys want to investigate the proper fix? If we cannot fix it soon i will proceed to revert the PR to give us more time to test the fixes properly. Let me know.
JKobrynski commentedon Jan 7, 2025
Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.
28 remaining items
melvin-bot commentedon Jan 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 10, 2025
@chiragsalian / @grgia @RachCHopkins @JKobrynski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
JKobrynski commentedon Jan 10, 2025
Update:
I updated the PR, it's now ready for review!
JKobrynski commentedon Jan 16, 2025
Update:
I fixed merge conflicts, lint issues and applied changes requested by reviewers. The PR is once again waiting for review.
melvin-bot commentedon Jan 17, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
[-][HOLD for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves[/-][+][Due for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves[/+]JKobrynski commentedon Jan 20, 2025
Update:
I applied a small change requested by @trjExpensify. Unfortunately new conflicts appeared right after that. They couldn't be fixed quickly as they directly influence the changes that I introduced in
OptionsListUtils.ts. I will continue my work on it tomorrow.melvin-bot commentedon Jan 21, 2025
@chiragsalian, @RachCHopkins, @grgia, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!