You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt #54844
Version Number: 9.0.81-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+2390223d@applause.expensifail.com Issue reported by: Applause - Internal Team Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to DM
Click + > Submit expense > Manual
Enter amount > Next
Note that the green button on the confirmation page is "Create x expense"
Click 3-dot menu > Add receipt
Add a receipt.
Expected Result:
The green button on the confirmation page should remain "Create x expense" after adding a receipt
Actual Result:
The green button on the confirmation page changes from "Create x expense" to "Submit x" after adding a receipt
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6707604_1736198470216.20250107_051845.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
text = translate('iou.createExpenseWithAmount', {amount: formattedAmount});
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can add test to verify splitOrRequestOptions function to return createExpenseWithAmount in this case.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Here's the PR: #53760 which updates to use createExpenseWithAmount. But I'm sure we should consider it as the offending PR since it's not in the requirement.
changed the title [-][HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt[/-][+][HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt[/+]on Jan 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Jan 6, 2025
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 6, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 6, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
daledah commentedon Jan 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The green button on the confirmation page changes from "Create x expense" to "Submit x" after adding a receipt
What is the root cause of that problem?
When there's no receipt, we use
iou.createExpenseWithAmount, that showsCreate x expenseApp/src/components/MoneyRequestConfirmationList.tsx
Line 441 in 96280b8
But after users add the receipt, we use
iou.submitAmount, that showsSubmit xApp/src/components/MoneyRequestConfirmationList.tsx
Line 438 in 96280b8
What changes do you think we should make in order to solve the problem?
We should update this line
App/src/components/MoneyRequestConfirmationList.tsx
Line 438 in 96280b8
to
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can add test to verify
splitOrRequestOptionsfunction to returncreateExpenseWithAmountin this case.What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
dukenv0307 commentedon Jan 7, 2025
Here's the PR: #53760 which updates to use createExpenseWithAmount. But I'm sure we should consider it as the offending PR since it's not in the requirement.
dukenv0307 commentedon Jan 7, 2025
I can help take it as C+ if we want to fix this issue separately cc @jasperhuangg
melvin-bot commentedon Jan 7, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
grgia commentedon Jan 7, 2025
I can take this one @jasperhuangg
cc @JKobrynski
16 remaining items
fix Expensify#54844
JKobrynski commentedon Jan 9, 2025
Update:
Issue fixed in #54201, waiting for review.
[-][HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt[/-][+][HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt[/+]melvin-bot commentedon Jan 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-17. 🎊
JKobrynski commentedon Jan 10, 2025
Update:
The PR is waiting for review