Skip to content

[HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt #54844

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.81-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+2390223d@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to DM
  3. Click + > Submit expense > Manual
  4. Enter amount > Next
  5. Note that the green button on the confirmation page is "Create x expense"
  6. Click 3-dot menu > Add receipt
  7. Add a receipt.

Expected Result:

The green button on the confirmation page should remain "Create x expense" after adding a receipt

Actual Result:

The green button on the confirmation page changes from "Create x expense" to "Submit x" after adding a receipt

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6707604_1736198470216.20250107_051845.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Jan 6, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. daledah commented on Jan 7, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The green button on the confirmation page changes from "Create x expense" to "Submit x" after adding a receipt

    What is the root cause of that problem?

    When there's no receipt, we use iou.createExpenseWithAmount, that shows Create x expense

    const translationKey = isTypeSplit ? 'iou.splitAmount' : 'iou.createExpenseWithAmount';

    But after users add the receipt, we use iou.submitAmount, that shows Submit x

    text = translate('iou.submitAmount', {amount: formattedAmount});

    What changes do you think we should make in order to solve the problem?

    We should update this line

    text = translate('iou.submitAmount', {amount: formattedAmount});

    to

                    text = translate('iou.createExpenseWithAmount', {amount: formattedAmount});
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    We can add test to verify splitOrRequestOptions function to return createExpenseWithAmount in this case.

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. dukenv0307 commented on Jan 7, 2025

    @dukenv0307
    Contributor

    Here's the PR: #53760 which updates to use createExpenseWithAmount. But I'm sure we should consider it as the offending PR since it's not in the requirement.

  6. dukenv0307 commented on Jan 7, 2025

    @dukenv0307
    Contributor

    I can help take it as C+ if we want to fix this issue separately cc @jasperhuangg

  7. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. grgia commented on Jan 7, 2025

    @grgia
    Contributor

    I can take this one @jasperhuangg

    cc @JKobrynski

  9. assigned and unassigned on Jan 7, 2025
  10. 16 remaining items

  11. added a commit that references this issue on Jan 9, 2025
    e5101df
  12. JKobrynski commented on Jan 9, 2025

    @JKobrynski
    Contributor

    Update:

    Issue fixed in #54201, waiting for review.

  13. changed the title [-][HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt[/-] [+][HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt[/+] on Jan 10, 2025
  14. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-17. 🎊

  16. JKobrynski commented on Jan 10, 2025

    @JKobrynski
    Contributor

    Update:

    The PR is waiting for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions