Skip to content

[HOLD for payment 2025-01-28] [$250] Per diem - App still shows old subrate and quantity after changing subrate and quantity to new value #54884

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.81-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+2390223d@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace has per diem rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Submit expense > Per diem.
  4. Select a country, select valid date and time and click Save.
  5. Select a subrate and quantity > Save
  6. On confirmation page, click on the subrate field.
  7. Change to a new subrate and quantity > Save.
  8. On confirmation page, click RHP back button.

Expected Result:

Since the subrate and quantity is changed to new value in Step 7, app should display the new subrate and quantity when going back from confirmation page to subrate page.

Actual Result:

When subrate and quantity is changed to new value in Step 7, app still displays the old value in Step 5 when returning to subrate page from confirmation page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021876687121588096404
  • Upwork Job ID: 1876687121588096404
  • Last Price Increase: 2025-01-07
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 7, 2025
  2. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 7, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. vincdargento commented on Jan 7, 2025

    @vincdargento
    Author

    @joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. amyevans commented on Jan 7, 2025

    @amyevans
    Contributor

    Per diem is behind a beta and an incomplete feature at the moment, not a blocker.

    cc @Gonals @shubham1206agra let me know if you'd like to be assigned or if I should make it external

  8. 21 remaining items

  9. changed the title [-][$250] Per diem - App still shows old subrate and quantity after changing subrate and quantity to new value[/-] [+][HOLD for payment 2025-01-28] [$250] Per diem - App still shows old subrate and quantity after changing subrate and quantity to new value[/+] on Jan 21, 2025
  10. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-28. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    @shubham1206agra @joekaufmanexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. shubham1206agra commented on Jan 25, 2025

    @shubham1206agra
    Contributor

    @joekaufmanexpensify Please close this issue. No payment required here.

  14. joekaufmanexpensify commented on Jan 27, 2025

    @joekaufmanexpensify
    Contributor

    Done. TY!

  15. added
    ReviewingHas a PR in review
    and removed on Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions