You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-28] [HOLD for payment 2025-01-17] Reduce string unions in Route type #54893
Similarly, as we had to do in this PR #40418, we are again running into an issue with an excess of string unions in the Route type. You can see full explanation in the PR there.
### Solution
Update the types to reduce the number of unions so the TS is working fine.
changed the title [-][HOLD for payment 2025-01-17] Reduce string unions in Route type[/-][+][HOLD for payment 2025-01-28] [HOLD for payment 2025-01-17] Reduce string unions in Route type[/+]on Jan 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@eVoloshchak@isabelastisser@eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.fabioh8010 commentedon Jan 7, 2025
I'm Fábio from Callstack - expert agency contributor - and I would like to work on this issue.
fabioh8010 commentedon Jan 8, 2025
PR was merged, will proceed with the small follow up soon
14 remaining items
mountiny commentedon Jan 17, 2025
@fabioh8010 anymore left?
fabioh8010 commentedon Jan 17, 2025
For now, no. We're all set here!
mountiny commentedon Jan 17, 2025
$250 to @eVoloshchak
isabelastisser commentedon Jan 17, 2025
Offer sent to @eVoloshchak in Upwork. All set!
[-][HOLD for payment 2025-01-17] Reduce string unions in Route type[/-][+][HOLD for payment 2025-01-28] [HOLD for payment 2025-01-17] Reduce string unions in Route type[/+]melvin-bot commentedon Jan 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 21, 2025
@eVoloshchak @isabelastisser @eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
JmillsExpensify commentedon Mar 3, 2025
$250 approved for @eVoloshchak