Skip to content

[HOLD for payment 2025-01-28] [HOLD for payment 2025-01-17] Reduce string unions in Route type #54893

Closed

Description

@mountiny

Problem

Similarly, as we had to do in this PR #40418, we are again running into an issue with an excess of string unions in the Route type. You can see full explanation in the PR there.

### Solution

Update the types to reduce the number of unions so the TS is working fine.

Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 7, 2025
  2. self-assigned this
    on Jan 7, 2025
  3. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. fabioh8010 commented on Jan 7, 2025

    @fabioh8010
    Contributor

    I'm Fábio from Callstack - expert agency contributor - and I would like to work on this issue.

  5. added
    ReviewingHas a PR in review
    and removed on Jan 7, 2025
  6. fabioh8010 commented on Jan 8, 2025

    @fabioh8010
    Contributor

    PR was merged, will proceed with the small follow up soon

  7. 14 remaining items

  8. mountiny commented on Jan 17, 2025

    @mountiny
    ContributorAuthor

    @fabioh8010 anymore left?

  9. fabioh8010 commented on Jan 17, 2025

    @fabioh8010
    Contributor

    For now, no. We're all set here!

  10. mountiny commented on Jan 17, 2025

    @mountiny
    ContributorAuthor

    $250 to @eVoloshchak

  11. isabelastisser commented on Jan 17, 2025

    @isabelastisser
    Contributor

    Offer sent to @eVoloshchak in Upwork. All set!

  12. changed the title [-][HOLD for payment 2025-01-17] Reduce string unions in Route type[/-] [+][HOLD for payment 2025-01-28] [HOLD for payment 2025-01-17] Reduce string unions in Route type[/+] on Jan 21, 2025
  13. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-28. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    @eVoloshchak @isabelastisser @eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. JmillsExpensify commented on Mar 3, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions