Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.81-3
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54252
Issue reported by: Applause - Internal Team
Component: Money Requests
Action Performed:
Workspace has Per diem enabled and Per diem rates loaded
- Go to staging.new.expensify.com
- Go to FAB > Create expense > Per diem tab
- Select any country
- Select start and end dates
- Select any Subrate
- Enter any Quantity
- Click on Save
Expected Result:
Labels show quantities in plural when the quantity of days or hours is greater than 1 and in singular when the quantity is equal to 1
Actual Result:
Labels show quantities only in the plural. The behavior is similar in Spanish
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6708474_1736278830262.Quantities_in_plural.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021877030743068052884
- Upwork Job ID: 1877030743068052884
- Last Price Increase: 2025-01-08
Activity
melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 7, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 7, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
stitesExpensify commentedon Jan 7, 2025
part of #54252
aldo-expensify commentedon Jan 7, 2025
This translation seems to be defined here and it indeed seem to not handle singular vs plural:
App/src/languages/en.ts
Line 1096 in de492fc
I'll remove
DeployBlockerlabel to continue with the backend deploy.18 remaining items
[-][$250] Per diem - Labels show quantities only in the plural[/-][+][HOLD for payment 2025-01-28] [$250] Per diem - Labels show quantities only in the plural[/+]melvin-bot commentedon Jan 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-28. 🎊
For reference, here are some details about the assignees on this issue:
shubham1206agra commentedon Jan 25, 2025
@Gonals Please close this. No payment required here.
mvtglobally commentedon Jan 27, 2025
Issue not reproducible during KI retests. (First week)