Skip to content

[HOLD for payment 2025-01-28] [$250] Per diem - Labels show quantities only in the plural #54905

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.81-3
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54252
Issue reported by: Applause - Internal Team
Component: Money Requests

Action Performed:

Workspace has Per diem enabled and Per diem rates loaded

  1. Go to staging.new.expensify.com
  2. Go to FAB > Create expense > Per diem tab
  3. Select any country
  4. Select start and end dates
  5. Select any Subrate
  6. Enter any Quantity
  7. Click on Save

Expected Result:

Labels show quantities in plural when the quantity of days or hours is greater than 1 and in singular when the quantity is equal to 1

Actual Result:

Labels show quantities only in the plural. The behavior is similar in Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6708474_1736278830262.Quantities_in_plural.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021877030743068052884
  • Upwork Job ID: 1877030743068052884
  • Last Price Increase: 2025-01-08
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jan 7, 2025
  2. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 7, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Jan 7, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. stitesExpensify commented on Jan 7, 2025

    @stitesExpensify
    Contributor

    part of #54252

  6. aldo-expensify commented on Jan 7, 2025

    @aldo-expensify
    Contributor

    This translation seems to be defined here and it indeed seem to not handle singular vs plural:

    tripLengthText: ({days}: TripLengthTextParams) => `Trip: ${days} full days`,

    I'll remove DeployBlocker label to continue with the backend deploy.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 7, 2025
  8. 18 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 21, 2025
  10. changed the title [-][$250] Per diem - Labels show quantities only in the plural[/-] [+][HOLD for payment 2025-01-28] [$250] Per diem - Labels show quantities only in the plural[/+] on Jan 21, 2025
  11. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-28. 🎊

    For reference, here are some details about the assignees on this issue:

  13. shubham1206agra commented on Jan 25, 2025

    @shubham1206agra
    Contributor

    @Gonals Please close this. No payment required here.

  14. mvtglobally commented on Jan 27, 2025

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  15. added
    ReviewingHas a PR in review
    and removed on Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions