Skip to content

[HOLD for payment 2025-01-24] Group chat - First group member is highlighted in contact list and confirmation page #54932

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+080101kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open FAB > Start chat.
  3. Click Add to group on a few members.
  4. Click Next.
  5. Note that the first member is highlighted.

Expected Result:

The first group member will not be highlighted in contact list and confirmation page (production behavior).

Actual Result:

The first group member is highlighted in contact list and confirmation page.

The same issue also happens in contact list when inviting member to workspace.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6708758_1736311073680.20250108_123442.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021876949287872433556
  • Upwork Job ID: 1876949287872433556
  • Last Price Increase: 2025-01-08
  • Automatic offers:
    • DylanDylann | Contributor | 105680364
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 8, 2025
  2. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. srikarparsi commented on Jan 8, 2025

    @srikarparsi
    Contributor

    Might have something to do with this PR, will check locally

  7. srikarparsi commented on Jan 8, 2025

    @srikarparsi
    Contributor

    This revert PR did not do the trick
    image

  8. srikarparsi commented on Jan 8, 2025

    @srikarparsi
    Contributor

    Looking through BaseSelectionList code, going to add the external label in the meanwhile

  9. 25 remaining items

  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 13, 2025
  11. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  12. changed the title [-][$250] Group chat - First group member is highlighted in contact list and confirmation page[/-] [+]Group chat - First group member is highlighted in contact list and confirmation page[/+] on Jan 13, 2025
  13. srikarparsi commented on Jan 13, 2025

    @srikarparsi
    Contributor

    Just for clarification later, I don't believe this issue should receive payment since it is being fixed as a follow up from this PR.

  14. srikarparsi commented on Jan 14, 2025

    @srikarparsi
    Contributor

    Closing this issue since it has been fixed in this PR and it doesn't need payment since it was a regression.

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 17, 2025
  16. changed the title [-]Group chat - First group member is highlighted in contact list and confirmation page[/-] [+][HOLD for payment 2025-01-24] Group chat - First group member is highlighted in contact list and confirmation page[/+] on Jan 17, 2025
  17. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-24. 🎊

    For reference, here are some details about the assignees on this issue:

  19. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    @DylanDylann @strepanier03 @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions