You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-02-05] [$250] Workspace - "Default" label tooltip content is truncated when language is Spanish #54955
Version Number: 9.0.82-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):ojidojdmwowj22doj@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
App language is Spanish.
There is a default workspace.
Go to staging.new.expensify.com
Go to Account settings.
Go to Espacios de trabajo (Workspaces).
Hover over Predeterminado (Default).
Expected Result:
The tooltip content should not be truncated.
Actual Result:
"Default" label tooltip content is truncated when language is Spanish.
changed the title [-] Workspace - "Default" label tooltip content is truncated when language is Spanish[/-][+][$250] Workspace - "Default" label tooltip content is truncated when language is Spanish[/+]on Jan 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@thesahindia@CortneyOfstad@thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Jan 8, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon Jan 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - "Default" label tooltip content is truncated when language is Spanish
What is the root cause of that problem?
App/src/pages/workspace/WorkspacesListRow.tsx
Lines 149 to 152 in ab92780
What changes do you think we should make in order to solve the problem?
numberOfLineswith 4, 5 or any desired number as value.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NJ-2020 commentedon Jan 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - "Default" label tooltip content is truncated when language is Spanish
What is the root cause of that problem?
We do not pass numberOfLines 0 since the default is 3
App/src/pages/workspace/WorkspacesListRow.tsx
Lines 149 to 152 in ab92780
What changes do you think we should make in order to solve the problem?
We should pass numberOfLines 0, so the text would not get truncate
App/src/pages/workspace/WorkspacesListRow.tsx
Lines 149 to 152 in ab92780
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
[-] Workspace - "Default" label tooltip content is truncated when language is Spanish[/-][+][$250] Workspace - "Default" label tooltip content is truncated when language is Spanish[/+]melvin-bot commentedon Jan 13, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021878900636944444244
melvin-bot commentedon Jan 13, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)CortneyOfstad commentedon Jan 13, 2025
Hey @thesahindia! We have a couple of proposals for review when you have a chance — thank you!
25 remaining items
melvin-bot commentedon Jan 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 29, 2025
@thesahindia @CortneyOfstad @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
CortneyOfstad commentedon Feb 3, 2025
@thesahindia please complete the checklist as soon as you can so there is no delay in payment — thank you so much!
CortneyOfstad commentedon Feb 5, 2025
@thesahindia bump on the need for a regression test. Please complete by EOD. Thank you!
thesahindia commentedon Feb 10, 2025
We don't need a regression test.
thesahindia commentedon Feb 10, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/53048/files#r1949701642
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
melvin-bot commentedon Feb 11, 2025
@rlinoz, @CortneyOfstad, @thesahindia, @Krishna2323 Huh... This is 4 days overdue. Who can take care of this?
CortneyOfstad commentedon Feb 11, 2025
Payment Summary
@thesahindia — to be paid $250 via NewDot
@Krishna2323 — paid $250 via Upwork
Regression Test
Not needed, based on comment here
garrettmknight commentedon Apr 10, 2025
$250 approved for @thesahindia