Skip to content

[HOLD for payment 2025-02-05] [$250] Workspace - "Default" label tooltip content is truncated when language is Spanish #54955

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): ojidojdmwowj22doj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • App language is Spanish.
  • There is a default workspace.
  1. Go to staging.new.expensify.com
  2. Go to Account settings.
  3. Go to Espacios de trabajo (Workspaces).
  4. Hover over Predeterminado (Default).

Expected Result:

The tooltip content should not be truncated.

Actual Result:

"Default" label tooltip content is truncated when language is Spanish.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6708976_1736335746760!Screenshot_2025-01-08_at_19 22 58
Bug6708976_1736335746757.20250108_192238.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021878900636944444244
  • Upwork Job ID: 1878900636944444244
  • Last Price Increase: 2025-01-13
  • Automatic offers:
    • Krishna2323 | Contributor | 105696059
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 8, 2025
  2. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Krishna2323 commented on Jan 8, 2025

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace - "Default" label tooltip content is truncated when language is Spanish

    What is the root cause of that problem?

    • Number of lines is not specified here.

    <Tooltip
    maxWidth={variables.w184}
    text={translate('workspace.common.defaultNote')}
    >

    What changes do you think we should make in order to solve the problem?

    • We can pass numberOfLines with 4, 5 or any desired number as value.
    • Or we can increase the width of the tooltip.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?


    What alternative solutions did you explore? (Optional)

  4. NJ-2020 commented on Jan 8, 2025

    @NJ-2020
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace - "Default" label tooltip content is truncated when language is Spanish

    What is the root cause of that problem?

    We do not pass numberOfLines 0 since the default is 3

    <Tooltip
    maxWidth={variables.w184}
    text={translate('workspace.common.defaultNote')}
    >

    What changes do you think we should make in order to solve the problem?

    We should pass numberOfLines 0, so the text would not get truncate

    <Tooltip
    maxWidth={variables.w184}
    text={translate('workspace.common.defaultNote')}
    >

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?


    What alternative solutions did you explore? (Optional)

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 13, 2025
  6. changed the title [-] Workspace - "Default" label tooltip content is truncated when language is Spanish[/-] [+][$250] Workspace - "Default" label tooltip content is truncated when language is Spanish[/+] on Jan 13, 2025
  7. melvin-bot commented on Jan 13, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 13, 2025
  9. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  10. CortneyOfstad commented on Jan 13, 2025

    @CortneyOfstad
    Contributor

    Hey @thesahindia! We have a couple of proposals for review when you have a chance — thank you!

  11. 25 remaining items

  12. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-05. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    @thesahindia @CortneyOfstad @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. CortneyOfstad commented on Feb 3, 2025

    @CortneyOfstad
    Contributor

    @thesahindia please complete the checklist as soon as you can so there is no delay in payment — thank you so much!

  15. CortneyOfstad commented on Feb 5, 2025

    @CortneyOfstad
    Contributor

    @thesahindia bump on the need for a regression test. Please complete by EOD. Thank you!

  16. thesahindia commented on Feb 10, 2025

    @thesahindia
    Member

    We don't need a regression test.

  17. thesahindia commented on Feb 10, 2025

    @thesahindia
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/53048/files#r1949701642

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
  18. melvin-bot commented on Feb 11, 2025

    @melvin-bot

    @rlinoz, @CortneyOfstad, @thesahindia, @Krishna2323 Huh... This is 4 days overdue. Who can take care of this?

  19. CortneyOfstad commented on Feb 11, 2025

    @CortneyOfstad
    Contributor

    Payment Summary

    @thesahindia — to be paid $250 via NewDot
    @Krishna2323 — paid $250 via Upwork

    Regression Test

    Not needed, based on comment here

  20. garrettmknight commented on Apr 10, 2025

    @garrettmknight
    Contributor

    $250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions