Skip to content

[$250] [AWAITING CHECKLIST][Due for payment 2025-03-24] iOS - Chat - The mention suggestion list is slow to respond #54991

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.82-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, repro on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5428982&group_by=cases:section_id&group_id=292106&group_order=asc
Issue reported by: Applause Internal Team
Device used: iPhone 13
App Component: Chat Report View

Action Performed:

  1. Open the iOS Hybrid app
  2. Navigate to the 1:1 DM or room chat
  3. Send a message with a user mention

Expected Result:

The mention suggestion list is displayed after typing @

Actual Result:

The mention suggestion list is slow to respond

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6709437_1736370013886.ScreenRecording_01-08-2025_15-44-52_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021904230172310111816
  • Upwork Job ID: 1904230172310111816
  • Last Price Increase: 2025-03-24
  • Automatic offers:
    • DylanDylann | Contributor | 106649697

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 9, 2025
  2. melvin-bot commented on Jan 9, 2025

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 9, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. lakchote commented on Jan 9, 2025

    @lakchote
    Contributor

    Could it be #54805?

  7. ikevin127 commented on Jan 9, 2025

    @ikevin127
    Contributor

    I remember experiencing this issue myself specifically on iOS: Native when I was working on the mentioned PR, before applying the filtering logic and, noting that I was on a new account, meaning small suggestion list. I checked by replacing the added filtering here:

    // on staging server, in specific cases (see issue) BE returns duplicated personalDetails
    // entries with the same `login` which we need to filter out
    return array.findIndex((arrayDetail) => arrayDetail?.login === detail?.login) === index;

    with return true; as it was before the PR and the issue is still reproducible. I'm suspecting something related to reanimated given the recent react-native version upgrade, but nothing solid yet.

  8. 103 remaining items

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 24, 2025
  10. melvin-bot commented on Mar 24, 2025

    @melvin-bot
  11. changed the title [-][AWAITING CHECKLIST][Due for payment 2025-03-24] iOS - Chat - The mention suggestion list is slow to respond[/-] [+][$250] [AWAITING CHECKLIST][Due for payment 2025-03-24] iOS - Chat - The mention suggestion list is slow to respond[/+] on Mar 24, 2025
  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 24, 2025
  13. melvin-bot commented on Mar 24, 2025

    @melvin-bot

    Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

  14. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 24, 2025
  15. melvin-bot commented on Mar 24, 2025

    @melvin-bot

    📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  16. garrettmknight commented on Mar 24, 2025

    @garrettmknight
    Contributor

    @DylanDylann offer's out to you. Please accept and complete the checklist.

  17. DylanDylann commented on Mar 25, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: fix: Track seen logins to filter out duplicates in personal details #57459 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Authenticate with the Applause test account
    2. Open any chat or room with multiple participants (preferably a workspace with many members)
    3. Type @ in the composer
    4. Verify the mention suggestions menu appears smoothly without flickering and in a timely fashion
    5. Type additional characters to filter the suggestions
    6. Verify the menu updates smoothly without flickering or lag
    7. Select a suggestion and verify it's inserted correctly
    8. Verify that duplicate logins are still properly filtered out

    Do we agree 👍 or 👎

  18. garrettmknight commented on Mar 25, 2025

    @garrettmknight
    Contributor

    Looks good to me. @DylanDylann please accept the offer and I'll pay out.

  19. garrettmknight commented on Mar 27, 2025

    @garrettmknight
    Contributor

    All paid up!

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions