Repository navigation
[HOLD for payment 2025-02-07] [$250] Users can't submit a report that contains no reimbursable expenses #55086
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): #retain
Action Performed:
- Go to NewDot, create a workspace.
- Go to Settings > Workspaces > [Click the workspace] > Enable Workflows
- Go to Workflows > Enable delayed submission and set it to Manually > Enable approvals.
- Go to Members > invite a member to the workspace
- [Member] Click the green plus icon > Create expense > choose the workspace > confirm
- Observe the
Submitbutton on the report preview, in the report header, and on the search page. - [Member] Click Settings > Domains (to transition over to OldDot)
- [Member] Go to the Expenses page > click into the expense > uncheck the reimbursable checkmark
- [Member] open the NewDot tab > refresh
- Observe the
Submitbutton is no longer visible on the report preview, report header or search page.
Expected Result:
Users should be able to see the Submit button on an expense report that contains only non-reimbursable expenses, providing they aren't all pending transactions.
Actual Result:
There's no Submit button on an expense report that contains only non-reimbursable expenses.
Note: I think this line here is culprit. Perhaps it's also in a few other places where you see the submit button.
Workaround:
They can submit via OldDot.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
2025-01-10_18-28-51.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021877786460553153940
- Upwork Job ID: 1877786460553153940
- Last Price Increase: 2025-01-10
- Automatic offers:
- shubham1206agra | Contributor | 105671141
- ishpaul777 | Contributor | 105671147
Activity
melvin-bot commentedon Jan 10, 2025
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
[-]Users can't submit a report that contains no reimbursable expenses [/-][+][$250] Users can't submit a report that contains no reimbursable expenses [/+]melvin-bot commentedon Jan 10, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021877786460553153940
melvin-bot commentedon Jan 10, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)allroundexperts commentedon Jan 10, 2025
@trjExpensify Your clue is accurate.
allroundexperts commentedon Jan 10, 2025
We need to remove the condition here in the money report header as well. There's also a condition in the submission action that we need to remove.
allgandalf commentedon Jan 10, 2025
@trjExpensify is gonna take our job away !!!!!
54 remaining items
ishpaul777 commentedon Feb 6, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/51012/files#r1945412669
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
N/a
Test:
4.Go to Members > invite a member to the workspace
Expected Result:
Users should be able to see the Submit button on an expense report preview, report header or search page, providing they aren't all pending transactions.
Do we agree 👍 or 👎
trjExpensify commentedon Feb 7, 2025
Regression test request created.
Payment summary as follows:
Confirming you're both paid via Upwork still?
shubham1206agra commentedon Feb 7, 2025
@trjExpensify For this issue, yes
melvin-bot commentedon Feb 10, 2025
@trjExpensify, @lakchote, @shubham1206agra, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
ishpaul777 commentedon Feb 10, 2025
yes still via upwork
trjExpensify commentedon Feb 10, 2025
Great stuff! @ishpaul777 I've paid you, @shubham1206agra you need to accept the offer.
shubham1206agra commentedon Feb 11, 2025
@trjExpensify Offer accepted
trjExpensify commentedon Feb 11, 2025
Paid, closing!