[Awaiting checklist] [$250] When adding a direct card feed, we link you out to the bank to authenticate while offline

@joekaufmanexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): ts_external_expensify_convert

Action Performed:

Enable company cards in workspace settings
Click Add cards and select any bank
Select Direct and go offline
Click Next

When trying to assign card on direct feed specifically
The Assign card option is allowed when offline

Expected Result:

Authenticate via bank mode not displayed when User is in offline

Next button and the Assign card button in modal for direct feeds should be disabled when offline.

Using PAttern B is hard here as the connection expires often soon so there is high chance the call could fail

Actual Result:

Authenticate via bank mode displayed. Same result observed when you try to assign cards while offline and need to authenticate first.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

2025-01-10_12-01-43.mp4

2025-01-10_12-18-15.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021878570494468361150
Upwork Job ID: 1878570494468361150
Last Price Increase: 2025-02-19
Automatic offers:

huult | Contributor | 105707373

Issue Owner

Current Issue Owner: @rojiphil

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Edited by proposal-police: This proposal was edited at 2025-01-13 00:32:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Next button in the feed type selection is not disabled when the user is offline.
The Assign Card button is not disabled when the user is offline.

What is the root cause of that problem?

When the user is offline:

We did not disable the Next button in the feed type selection at the following locations:
- App/src/pages/workspace/companyCards/addNew/SelectFeedType.tsx
  
  Lines 91 to 92 in 15f0b50
  
  showConfirmButton
  
  confirmButtonText={translate('common.next')}
- App/src/components/SelectionList/BaseSelectionList.tsx
  
  Lines 862 to 864 in 15f0b50
  
  <Button
  
  success={!shouldUseDefaultTheme}
  
  large
We did not disable the Assign Card button at the following location:
- App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx
  
  Line 152 in 5ffe883
  
  isDisabledAssignCardButton={!selectedFeedData || !!selectedFeedData?.errors}

What changes do you think we should make in order to solve the problem?

Disable the Assign Card button when the user is offline:
- Add the || isOffline condition to the existing check at this location:
```
isDisabledAssignCardButton={!selectedFeedData || !!selectedFeedData?.errors || isOffline}
```

Disable the Next button in the feed type selection:

Add a new prop to BaseSelectionListProps called isConfirmButtonDisabled to convey the purpose clearly.

Pass isConfirmButtonDisabled={isOffline} at this location:

App/src/pages/workspace/companyCards/addNew/SelectFeedType.tsx

Lines 91 to 93 in 15f0b50

    
           showConfirmButton 
        
           confirmButtonText={translate('common.next')} 
        
           onConfirm={submit}

Update the button in BaseSelectionList to use the new prop by setting:
```
disabled={isConfirmButtonDisabled}
```

`

we may want to disable this Assign card button as well in WorkspaceCompanyCardsListHeaderButtons:

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

Lines 85 to 88 in c30c298

    
           {!!shouldShowAssignCardButton && ( 
        
               <Button 
        
                   success 
        
                   isDisabled={!currentFeedData || !!currentFeedData?.pending || !!currentFeedData?.errors}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

In the feed selection type, instead of disabling the next button, show the FullPageOfflineBlockingView by changing the following code in SelectFeedType.tsx as:

return (
    <ScreenWrapper
        testID={SelectFeedType.displayName}
        includeSafeAreaPaddingBottom={false}
        shouldEnablePickerAvoiding={false}
        shouldEnableMaxHeight
    >
        <HeaderWithBackButton
            title={translate('workspace.companyCards.addCards')}
            onBackButtonPress={handleBackButtonPress}
        />
        <FullPageOfflineBlockingView>

@mountiny

please assign me here, Probably not open for proposals , maybe CallStack would work on this as part of project , right @mountiny ?

Job added to Upwork: https://www.upwork.com/jobs/~021878570494468361150

@rojiphil

Payment Summary:

@rojiphil paid $250 via NewDot Manual Request
@huult paid $125 here (Contributor)

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

Test:

Navigate to Workspace Settings and enable Company Cards.
Click Add Cards and select any bank.
Choose Direct as the connection method and go offline.
Click the Next button.
Verify that the application displays the Offline Page for bank connection.
Go online and verify that the bank authentication is performed.
Go offline again and assign a card on a direct feed.
Verify that the Assign Card button invokes an offline modal for direct feeds

Do we agree 👍 or 👎

@mountiny

@mountiny Can we reset the compensation back to the default amount here i.e. $250? The reason being that we initially thought this was just a matter of disabling the buttons but we went ahead to implement using offline page/modal.
What do you think?

Upwork job price has been updated to $250

@rojiphil

@rojiphil Fair updated, but I think @twisterdotcom might have to update the pay to @huult

@mountiny

thank you, @mountiny

Requested in ND

@huult

Added a $125 bonus for @huult.

@rojiphil

$250 approved for @rojiphil

Navigation Menu

Repository navigation

[Awaiting checklist] [$250] When adding a direct card feed, we link you out to the bank to authenticate while offline #55096

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

36 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	showConfirmButton
	confirmButtonText={translate('common.next')}

	showConfirmButton
	confirmButtonText={translate('common.next')}
	onConfirm={submit}

	{!!shouldShowAssignCardButton && (
	<Button
	success
	isDisabled={!currentFeedData \|\| !!currentFeedData?.pending \|\| !!currentFeedData?.errors}

	<Button
	success={!shouldUseDefaultTheme}
	large

[Awaiting checklist] [$250] When adding a direct card feed, we link you out to the bank to authenticate while offline #55096

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 10, 2025

Shahidullah-Muffakir commented on Jan 10, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

allgandalf commented on Jan 11, 2025

melvin-bot commented on Jan 12, 2025

36 remaining items

twisterdotcom commented on Feb 18, 2025

rojiphil commented on Feb 19, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

rojiphil commented on Feb 19, 2025

melvin-bot commented on Feb 19, 2025

mountiny commented on Feb 19, 2025

huult commented on Feb 19, 2025

rojiphil commented on Feb 19, 2025

twisterdotcom commented on Feb 19, 2025

garrettmknight commented on Feb 19, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions