Skip to content

[ON HOLD for Payment 2/24/25] [$250] Per diem - Quantity field shows error after selecting a subrate #55399

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.87-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+29302392@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace has per diem rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Submit expense > Per diem.
  4. Select destination > Next.
  5. Select time > Next.
  6. Click Subrate.
  7. Select a subrate.

Expected Result:

Quantity field will not show error after selecting a subrate (production behavior).

Actual Result:

Quantity field shows error after selecting a subrate.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021883939320560472623
  • Upwork Job ID: 1883939320560472623
  • Last Price Increase: 2025-01-27
  • Automatic offers:
    • FitseTLT | Contributor | 105977085
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 17, 2025
  2. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 17, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. vincdargento commented on Jan 17, 2025

    @vincdargento
    Author

    @CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. neil-marcellini commented on Jan 17, 2025

    @neil-marcellini
    Contributor

    NAB, per diem is behind a beta

  8. 34 remaining items

  9. CortneyOfstad commented on Feb 11, 2025

    @CortneyOfstad
    Contributor

    PR is being actively worked on 👍

  10. mananjadhav commented on Feb 11, 2025

    @mananjadhav
    Collaborator

    Waiting for a review from @youssef-lr

  11. mananjadhav commented on Feb 18, 2025

    @mananjadhav
    Collaborator

    @CortneyOfstad The PR was deployed to production yesterday but the payout date isn't updated.

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Feb 19, 2025
  13. CortneyOfstad commented on Feb 19, 2025

    @CortneyOfstad
    Contributor

    @mananjadhav I sent you an offer to the job here — can you let me know once you accept?

    Also, can you confirm if a regression test is needed?

  14. changed the title [-][$250] Per diem - Quantity field shows error after selecting a subrate[/-] [+][ON HOLD for Payment 2/24/25] [$250] Per diem - Quantity field shows error after selecting a subrate[/+] on Feb 19, 2025
  15. mananjadhav commented on Feb 19, 2025

    @mananjadhav
    Collaborator

    @CortneyOfstad I'll be raising the request on NewDot. I've declined the offer on Upwork. Posting the checklist in the next comment.

  16. mananjadhav commented on Feb 19, 2025

    @mananjadhav
    Collaborator

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Beta is enabled Workspace has per diem rates.

    Test:

    1. Go to workspace chat.
    2. Click + Submit expense Per diem.
    3. Select destination Next.
    4. Select time Next.
    5. Click Subrate.
    6. Select a subrate.
    7. Verify Quantity field is focused and will not show error after selecting a substrate.
    8. Enter a quantity value and tap outside of the text input to remove the focus
    9. Refocus on the text input by clicking it and delete the value you entered so that the text input will be empty
    10. Verify that field is required error appears

    Do we agree 👍 or 👎

  17. CortneyOfstad commented on Feb 24, 2025

    @CortneyOfstad
    Contributor

    Payment Summary

    @FitseTLT — paid $250 via Upwork
    @mananjadhav — to be paid $250 via NewDot

    Regression Test

    https://github.com/Expensify/Expensify/issues/473909

  18. garrettmknight commented on Feb 28, 2025

    @garrettmknight
    Contributor

    $250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions