You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[ON HOLD for Payment 2/24/25] [$250] Per diem - Quantity field shows error after selecting a subrate #55399
Version Number: 9.0.87-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+29302392@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Workspace has per diem rates.
Go to staging.new.expensify.com
Go to workspace chat.
Click + > Submit expense > Per diem.
Select destination > Next.
Select time > Next.
Click Subrate.
Select a subrate.
Expected Result:
Quantity field will not show error after selecting a subrate (production behavior).
Actual Result:
Quantity field shows error after selecting a subrate.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][$250] Per diem - Quantity field shows error after selecting a subrate[/-][+][ON HOLD for Payment 2/24/25] [$250] Per diem - Quantity field shows error after selecting a subrate[/+]on Feb 19, 2025
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Beta is enabled Workspace has per diem rates.
Test:
Go to workspace chat.
Click + Submit expense Per diem.
Select destination Next.
Select time Next.
Click Subrate.
Select a subrate.
Verify Quantity field is focused and will not show error after selecting a substrate.
Enter a quantity value and tap outside of the text input to remove the focus
Refocus on the text input by clicking it and delete the value you entered so that the text input will be empty
Activity
melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @youssef-lr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 17, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 17, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
vincdargento commentedon Jan 17, 2025
@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
neil-marcellini commentedon Jan 17, 2025
NAB, per diem is behind a beta
34 remaining items
CortneyOfstad commentedon Feb 11, 2025
PR is being actively worked on 👍
mananjadhav commentedon Feb 11, 2025
Waiting for a review from @youssef-lr
mananjadhav commentedon Feb 18, 2025
@CortneyOfstad The PR was deployed to production yesterday but the payout date isn't updated.
CortneyOfstad commentedon Feb 19, 2025
@mananjadhav I sent you an offer to the job here — can you let me know once you accept?
Also, can you confirm if a regression test is needed?
[-][$250] Per diem - Quantity field shows error after selecting a subrate[/-][+][ON HOLD for Payment 2/24/25] [$250] Per diem - Quantity field shows error after selecting a subrate[/+]mananjadhav commentedon Feb 19, 2025
@CortneyOfstad I'll be raising the request on NewDot. I've declined the offer on Upwork. Posting the checklist in the next comment.
mananjadhav commentedon Feb 19, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
CortneyOfstad commentedon Feb 24, 2025
Payment Summary
@FitseTLT — paid $250 via Upwork
@mananjadhav — to be paid $250 via NewDot
Regression Test
https://github.com/Expensify/Expensify/issues/473909
garrettmknight commentedon Feb 28, 2025
$250 approved for @mananjadhav