You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-02-24][$250] Unmask tooltip copy for Fullstory #55425
if we want to unmask all the tooltips, then we need to also update the base tooltip component to include this one, but i guess here we are updating only the tooltips we get at the start of a new user
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
No tests, this is fullstory related.
What alternative solutions did you explore? (Optional)
Please re-state the problem that we are trying to solve in this issue.
Allow capturing tooltip text/copy using Fullstory by making all tooltips unmasked.
What is the root cause of that problem?
Tooltip components do not have a fs-unmask class, which is required to capture text contents of a component according to Fullstory docs.
What changes do you think we should make in order to solve the problem?
The issue can be resolved by adding a fs-unmask class to tooltip components. Since all tooltips extend BaseGenericTooltip, the class can be added to this component by default.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can test that BaseGenericTooltip on render has the fs-unmask class. Since other tooltips extend this component, we probably don't need to write tests for every type of tooltip.
What alternative solutions did you explore? (Optional)
Fullstory has convenience functions to programmatically unmask elements. That approach will be beneficial if we needed to conditionally unmask some components. But in this case since we want to unmask all tooltips, using a class is a simpler and recommended solution. Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
📣 @ranjan-purbey! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
changed the title [-][$250] Unmask tooltip copy for Fullstory[/-][+][HOLD for payment 2025-02-24][$250] Unmask tooltip copy for Fullstory[/+]on Feb 18, 2025
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.twilight2294 commentedon Jan 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unmask tooltip copy for Fullstory
What is the root cause of that problem?
Feature request, we should add
fsClass="fs-unmaskto unmask the tooltip text.What changes do you think we should make in order to solve the problem?
We need to update any of the following
Viewelement:App/src/components/ProductTrainingContext/index.tsx
Line 185 in d50b5ae
App/src/components/ProductTrainingContext/index.tsx
Line 179 in d50b5ae
We will add
fsClass="fs-unmask"to theViewelement, like we did for the display names:App/src/pages/home/HeaderView.tsx
Lines 230 to 231 in d50b5ae
if we want to unmask all the tooltips, then we need to also update the base tooltip component to include this one, but i guess here we are updating only the tooltips we get at the start of a new user
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
No tests, this is fullstory related.
What alternative solutions did you explore? (Optional)
N/A
[-]Unmask tooltip copy for Fullstory[/-][+][$250] Unmask tooltip copy for Fullstory[/+]melvin-bot commentedon Jan 17, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021880350559975789433
melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)ranjan-purbey commentedon Jan 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Allow capturing tooltip text/copy using Fullstory by making all tooltips unmasked.
What is the root cause of that problem?
Tooltip components do not have a
fs-unmaskclass, which is required to capture text contents of a component according to Fullstory docs.What changes do you think we should make in order to solve the problem?
The issue can be resolved by adding a
fs-unmaskclass to tooltip components. Since all tooltips extendBaseGenericTooltip, the class can be added to this component by default.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can test that
BaseGenericTooltipon render has thefs-unmaskclass. Since other tooltips extend this component, we probably don't need to write tests for every type of tooltip.What alternative solutions did you explore? (Optional)
Fullstory has convenience functions to programmatically unmask elements. That approach will be beneficial if we needed to conditionally unmask some components. But in this case since we want to unmask all tooltips, using a class is a simpler and recommended solution.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jan 18, 2025
📣 @ranjan-purbey! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
ranjan-purbey commentedon Jan 18, 2025
Contributor details
Your Expensify account email: ranjan.purbey@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017b42573fd7c0f12b
19 remaining items
twilight2294 commentedon Feb 18, 2025
Can someone put a pending payment label here ? The PR is in production from yesterday
[-][$250] Unmask tooltip copy for Fullstory[/-][+][HOLD for payment 2025-02-24][$250] Unmask tooltip copy for Fullstory[/+]melvin-bot commentedon Feb 20, 2025
This issue has not been updated in over 15 days. @puneetlath, @slafortune, @jjcoffee, @twilight2294 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
jjcoffee commentedon Feb 20, 2025
@puneetlath Would you mind switching back to weekly so this doesn't get missed for payment 🙇
jjcoffee commentedon Feb 24, 2025
@slafortune This is due for payment now. I don't think any checklist is required as this is a feature, also I don't think QA can test fullstory.
slafortune commentedon Feb 24, 2025
@jjcoffee Role C+ is due $250 via NewDot
@twilight2294 Role Contributor was paid $250 via Upworks
garrettmknight commentedon Mar 1, 2025
$250 approved for @jjcoffee