Skip to content

[HOLD for payment 2025-02-24][$250] Unmask tooltip copy for Fullstory #55425

Closed

Description

@flaviadefaria

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.comCopy to clipboard to request to join our Slack channel!

Problem

We don't want tooltips copy to be masked

Solution

Unmask all tooltips

The contributor who works on this will need to add the fsClass="fs-unmask" property in the elements to be unmasked.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021880350559975789433
  • Upwork Job ID: 1880350559975789433
  • Last Price Increase: 2025-01-17
  • Automatic offers:
    • twilight2294 | Contributor | 105774913
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 17, 2025
  2. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. twilight2294 commented on Jan 17, 2025

    @twilight2294
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Unmask tooltip copy for Fullstory

    What is the root cause of that problem?

    Feature request, we should add fsClass="fs-unmask to unmask the tooltip text.

    What changes do you think we should make in order to solve the problem?

    We need to update any of the following View element:

    <Text style={[styles.productTrainingTooltipText, styles.textWrap, styles.mw100]}>

    <View style={[styles.alignItemsCenter, styles.flexRow, styles.justifyContentCenter, styles.flexWrap, styles.textAlignCenter, styles.gap3, styles.p2]}>

    We will add fsClass="fs-unmask" to the View element, like we did for the display names:

    <View
    fsClass="fs-unmask"

    if we want to unmask all the tooltips, then we need to also update the base tooltip component to include this one, but i guess here we are updating only the tooltips we get at the start of a new user

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    No tests, this is fullstory related.

    What alternative solutions did you explore? (Optional)

    N/A

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 17, 2025
  5. changed the title [-]Unmask tooltip copy for Fullstory[/-] [+][$250] Unmask tooltip copy for Fullstory[/+] on Jan 17, 2025
  6. melvin-bot commented on Jan 17, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 17, 2025
  8. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  9. ranjan-purbey commented on Jan 18, 2025

    @ranjan-purbey

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Allow capturing tooltip text/copy using Fullstory by making all tooltips unmasked.

    What is the root cause of that problem?

    Tooltip components do not have a fs-unmask class, which is required to capture text contents of a component according to Fullstory docs.

    What changes do you think we should make in order to solve the problem?

    The issue can be resolved by adding a fs-unmask class to tooltip components. Since all tooltips extend BaseGenericTooltip, the class can be added to this component by default.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    We can test that BaseGenericTooltip on render has the fs-unmask class. Since other tooltips extend this component, we probably don't need to write tests for every type of tooltip.

    What alternative solutions did you explore? (Optional)

    Fullstory has convenience functions to programmatically unmask elements. That approach will be beneficial if we needed to conditionally unmask some components. But in this case since we want to unmask all tooltips, using a class is a simpler and recommended solution.
    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  10. melvin-bot commented on Jan 18, 2025

    @melvin-bot

    📣 @ranjan-purbey! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  11. ranjan-purbey commented on Jan 18, 2025

    @ranjan-purbey

    Contributor details
    Your Expensify account email: ranjan.purbey@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~017b42573fd7c0f12b

  12. 19 remaining items

  13. twilight2294 commented on Feb 18, 2025

    @twilight2294
    Contributor

    Can someone put a pending payment label here ? The PR is in production from yesterday

  14. changed the title [-][$250] Unmask tooltip copy for Fullstory[/-] [+][HOLD for payment 2025-02-24][$250] Unmask tooltip copy for Fullstory[/+] on Feb 18, 2025
  15. melvin-bot commented on Feb 20, 2025

    @melvin-bot

    This issue has not been updated in over 15 days. @puneetlath, @slafortune, @jjcoffee, @twilight2294 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  16. jjcoffee commented on Feb 20, 2025

    @jjcoffee
    Contributor

    @puneetlath Would you mind switching back to weekly so this doesn't get missed for payment 🙇

  17. jjcoffee commented on Feb 24, 2025

    @jjcoffee
    Contributor

    @slafortune This is due for payment now. I don't think any checklist is required as this is a feature, also I don't think QA can test fullstory.

  18. slafortune commented on Feb 24, 2025

    @slafortune
    Contributor

    @jjcoffee Role C+ is due $250 via NewDot
    @twilight2294 Role Contributor was paid $250 via Upworks

  19. moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrateon Feb 24, 2025
  20. garrettmknight commented on Mar 1, 2025

    @garrettmknight
    Contributor

    $250 approved for @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions