Repository navigation
[Due for payment 2025-05-30] [$600] Workspace - Category and Tag "Required" switch is enabled and locked evenif all tags are disable #55431
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.87-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause - Internal Team
Component: Workspace Settings
Action Performed:
- Navigate to https://staging.new.expensify.com/
- Create WS and enable Tag
- Add some tags and enable "Members must tag all expenses" toggle
- Navigate to Category and enable "Members must categorize all expenses" toggle
- Select all Category and disable all category.
- Navigate to setting and note that the toggle is is disabled and locked
- Go back and navigate again and note that the toggle is enabled and locked
- Navigate to Tag and Select all tags.
- Disable all tags and navigate to setting and note that the toggle is enabled and locked
Expected Result:
The toggle is disabled and locked when all tags and categories are disabled
Actual Result:
The toggle is enabled and locked when all tags and categories are disabled
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6717031_1737140837036.bandicam_2025-01-17_21-46-17-653.mp4
Issue Owner
Current Issue Owner: @alexpensifyUpwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021896598139956436446
- Upwork Job ID: 1896598139956436446
- Last Price Increase: 2025-05-28
- Automatic offers:
- twilight2294 | Contributor | 106381697
Activity
melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.gijoe0295 commentedon Jan 17, 2025
The second
OpenPolicyCategoriesPagecall when we dismiss the RHP returns policy'srequiresCategoryastruewhich is not correct, while the first same call returnsfalse. This is BE related.allgandalf commentedon Jan 18, 2025
@alexpensify this is a
BEissue, please use Internal labelmelvin-bot commentedon Jan 21, 2025
@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
alexpensify commentedon Jan 22, 2025
I'm adding
Hot Pick,but I'm still reviewing which wave to associate with this one to get more attention.alexpensify commentedon Jan 25, 2025
Update: Hot Pick
124 remaining items
melvin-bot commentedon May 23, 2025
@s77rt @alexpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
twilight2294 commentedon May 23, 2025
@alexpensify @mollfpr can the compensation for this issue be increased here?. saying so cause the scope of the issue was vast, we did all the following in the PR:
Requires categories & tagstoggle turning off when all are disabled/delted.Considering the wide scope, i think the compensation for this issue should be increased
s77rt commentedon May 25, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: fix: categorize all expense switch is not disabled #39036 (no comment as it's not clear what went wrong, we decided to choose another approach regardless)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, we have added UI tests already
mallenexpensify commentedon May 27, 2025
cc @tgolen too as you're the assigned engineer. Details and reasoning above
s77rt commentedon May 28, 2025
👋 Regarding the compensation, I think $600 would be fair.
$50 as this is very straightforward task
$250 for handling category
$250 for handling tag
$50 because this is already a part of the tag work but it was kinda hidden
cc @mallenexpensify @twilight2294
[-][Due for payment 2025-05-30] [$250] Workspace - Category and Tag "Required" switch is enabled and locked evenif all tags are disable[/-][+][Due for payment 2025-05-30] [$600] Workspace - Category and Tag "Required" switch is enabled and locked evenif all tags are disable[/+]melvin-bot commentedon May 28, 2025
Upwork job price has been updated to $600
mallenexpensify commentedon May 28, 2025
Thanks for the breakdown @s77rt, it makes it much easier to come to consensus on the job amount. I agree with $600 and updated the title to reflect the price 🚀
tgolen commentedon May 28, 2025
Yeah, sounds like a good price breakdown. Thanks for raising it @twilight2294!
alexpensify commentedon May 30, 2025
Payment Summary
Contributor: @twilight2294 paid $600 via Upwork
Contributor+: @s77rt due $600 via NewDot-- please submit a request in Chat, thanks!
JmillsExpensify commentedon Jun 9, 2025
$600 approved for @s77rt