Skip to content

[Due for payment 2025-02-18] Per diem - Tax fields are absent on confirmation page but present in transaction thread #55450

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.87-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component: Money Requests

Action Performed:

Precondition:

  • Workspace has per diem rates
  • Workspace has tax rates
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Click + > Submit expense > Per diem
  4. Reach the confirmation page
  5. Note that confirmation page does not have tax rate and tax amount fields
  6. Create the per diem expense
  7. Go to transaction thread
  8. Note that transaction thread shows tax rate and tax amount fields

Expected Result:

There should be consistency in showing tax fields on confirmation page and transaction thread

Actual Result:

Tax fields are absent on confirmation page but present in transaction thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6717393_1737188806339.bandicam_2025-01-18_16-22-15-567.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Jan 18, 2025

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Jan 18, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Jan 18, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 20, 2025
  5. Beamanator commented on Jan 20, 2025

    @Beamanator
    Contributor

    NAB, per diem is behind a beta

  6. melvin-bot commented on Jan 20, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  7. pecanoro commented on Jan 20, 2025

    @pecanoro
    Contributor

    @Beamanator Should I open this for external contributors?

  8. 10 remaining items

  9. mallenexpensify commented on Feb 4, 2025

    @mallenexpensify
    Contributor

    @shubham1206agra can you provide an update, as it appears your PR will fix this. Mainly need to know about payment. My guess is it's a payment on one of the two issues the PR fixes or no payment cuz it's rolled into a project budget.

  10. shubham1206agra commented on Feb 4, 2025

    @shubham1206agra
    Contributor

    @shubham1206agra can you provide an update, as it appears your PR will fix this. Mainly need to know about payment. My guess is it's a payment on one of the two issues the PR fixes or no payment cuz it's rolled into a project budget.

    @mallenexpensify There will be no payment here as it is being handled as part of per diem project.

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 11, 2025
  12. changed the title [-]Per diem - Tax fields are absent on confirmation page but present in transaction thread[/-] [+][Due for payment 2025-02-18] Per diem - Tax fields are absent on confirmation page but present in transaction thread[/+] on Feb 11, 2025
  13. melvin-bot commented on Feb 11, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Feb 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-18. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Feb 11, 2025

    @melvin-bot

    @shubham1206agra @mallenexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. shubham1206agra commented on Feb 11, 2025

    @shubham1206agra
    Contributor

    @mallenexpensify Please close this issue. No payment is required here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringNeeds ReproductionReproducible steps neededWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions