Skip to content

[Due for payment 2025-03-13] [$250] Attachments-PDF preview loads with delay, the grey line shown first #55671

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2654655
Issue reported by: Applause Internal Team
Device used: MacBook Air 14.1 Chrome
App Component: Chat Report View

Action Performed:

  1. Navigate to staging.new.expensify and sign in
  2. Open any chat and send PDF files
  3. Click on PDF thumbnail to open a preview

Expected Result:

PDF preview is opened without delays

Actual Result:

PDF preview loads with delay, the grey line shown first

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/26996e5f-8eb4-4e66-8ad0-1890d76162b4
https://github.com/user-attachments/assets/ac4dc41b-73f7-4ad8-9d29-dd1ee94bb6fa

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021883791423079955100
  • Upwork Job ID: 1883791423079955100
  • Last Price Increase: 2025-02-10
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 23, 2025
  2. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. dylanexpensify commented on Jan 24, 2025

    @dylanexpensify
    Contributor

    Unable to reproduce. Can you confirm @IuliiaHerets?

  4. IuliiaHerets commented on Jan 25, 2025

    @IuliiaHerets
    Author

    Hi, @dylanexpensify. QA team can still repro this issue, build - 89-5. Tester used Mac Chrome

    Recording.341.mp4
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 27, 2025
  6. melvin-bot commented on Jan 27, 2025

    @melvin-bot
  7. changed the title [-]Attachments-PDF preview loads with delay, the grey line shown first[/-] [+][$250] Attachments-PDF preview loads with delay, the grey line shown first[/+] on Jan 27, 2025
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 27, 2025
  9. melvin-bot commented on Jan 27, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

  10. 80 remaining items

  11. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.9-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @rezkiy37 does not require payment (Contractor)
    • @rayane-d requires payment through NewDot Manual Requests
  13. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    @rayane-d @dylanexpensify @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. rayane-d commented on Mar 8, 2025

    @rayane-d
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Simplify the PDF renderer for the Web #1521

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Prepare a PDF file with multiple pages to use it for the test

    Test:

    1. Open any chat and send the PDF file.
    2. Click on the PDF thumbnail to open a preview
    3. Verify that the PDF file has been loaded without any gray lines.
    4. Scroll fast or via the scrollbar.
    5. Verify that the PDF file pages have been loaded without any gray lines.

    Do we agree 👍 or 👎

  15. dylanexpensify commented on Mar 11, 2025

    @dylanexpensify
    Contributor

    Payment coming up!

  16. dylanexpensify commented on Mar 13, 2025

    @dylanexpensify
    Contributor

    Payment summary:

    Contributor+: @rayane-d $250 via NewDot

    Please apply/request!

  17. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 13, 2025
  18. rayane-d commented on Mar 18, 2025

    @rayane-d
    Contributor

    Requested in ND

  19. garrettmknight commented on Mar 24, 2025

    @garrettmknight
    Contributor

    $250 approved for @rayane-d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions