Repository navigation
[HOLD for payment 2021-12-06] [Hold for payment on 25th Nov] [$1000] Android/iOS - Changing orientation breaks layout #5591
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! https://www.upwork.com/jobs/~0130cf8bfe4742fbde
Action Performed:
- On an Android with a big screen
- Open the app
- On LHN, change the orientation to landscape
Expected Result:
Layout should not break
Actual Result:
Layout is broken after changing the orientation to landscape.
Workaround:
Closing and reopening the app removes the issue.
Platform:
Where is this issue occurring?
- Android
Version Number: 1.1.3-3
Reproducible in staging?: yes
Reproducible in production?: yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
layout.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1631730111364600
Activity
MelvinBot commentedon Sep 29, 2021
Triggered auto assignment to @laurenreidexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Sep 29, 2021
Triggered auto assignment to @MonilBhavsar (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.isagoico commentedon Sep 29, 2021
I was able to reproduce this issue in a Galaxy A52 (6.5-inch screen size)
MonilBhavsar commentedon Sep 30, 2021
Was able to reproduce the reported issue on Android simulator and iOS device...
... But looking more into screen orientation of our app, looks like we need to improve it a lot. In the app, on login page in landscape mode, the highlighted part of screen is responsive, Trying to scroll down by sideways makes one feel like app is unresponsive...
...We also need to improve transition when changing from landscape to portrait and vice versa.
RPReplay_Final1632986507.MP4
laurenreidexpensify commentedon Sep 30, 2021
Having some issues getting this on Upwork, will upload tomorrow
[-]Android - Changing orientation breaks layout[/-][+]Android/iOS - Changing orientation breaks layout[/+]67 remaining items
laurenreidexpensify commentedon Nov 25, 2021
I completely missed hiring Rajat in Upwork on this one, so making a daily so I make sure to pay as soon as he's accepted the offer
parasharrajat commentedon Nov 25, 2021
Just did @laurenreidexpensify.
laurenreidexpensify commentedon Nov 25, 2021
@parasharrajat paid!
@Santhosh-Sellavel I'll issue you a $250 bonus now
laurenreidexpensify commentedon Nov 26, 2021
Nearly finished with payment for Santhosh, will close after that
laurenreidexpensify commentedon Nov 26, 2021
Everyone has been paid - closing 👍🏽
[-][Hold for payment on 25th Nov] [$1000] Android/iOS - Changing orientation breaks layout[/-][+][HOLD for payment 2021-12-06] [Hold for payment on 25th Nov] [$1000] Android/iOS - Changing orientation breaks layout[/+]botify commentedon Nov 29, 2021
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2021-12-06. 🎊