You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-05] [$250] Web - Company cards - User stays on member profile tab instead Company cards page #56009
Version Number: v9.0.91-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/cases/view/3809610 Email or phone of affected tester (no customers):applausetester+ccardfeed@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Windows 11 / Chrome App Component: Workspace Settings
Action Performed:
Precondition: workspace with several members, with enabled Company cards. Some company cards are added.
Go to ws > Members
Click on member with already assigned company card (if no, assign card to member)
Click on 'New card'
Proceed to the 4th step 'Let’s double check that everything looks right.'
Click on Cardholder field
Select another ws member
Click 'Assign card'
Expected Result:
User lands to Company cards page, rather than the workspace member profile he was previously on (as you assigned the card to someone else)
🚨 Edited by proposal-police: This proposal was edited at 2025-01-30 01:09:50 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
User stays on member profile tab instead Company cards page
What is the root cause of that problem?
The navigation inconsistency stems from the use of the backTo parameter, which defaults to redirecting users to the originating page (e.g., a members page) instead of enforcing a consistent post-submission path to the company cards page.
⚠️@nyomanjyotisa Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
changed the title [-]Web - Company cards - User stays on member profile tab instead Company cards page[/-][+][$250] Web - Company cards - User stays on member profile tab instead Company cards page[/+]on Jan 30, 2025
Please re-state the problem that we are trying to solve in this issue.
User stays on member profile tab instead Company cards page
What is the root cause of that problem?
We are expected to go back to the members page if the card is assigned to the same member from whose profile page we clicked assign cards, but in the current navigation condition, we navigate to the members profile page regardless of the card being assigned to the same / different member:
There is not check to see if the same member was assigned the card.
What changes do you think we should make in order to solve the problem?
According to op:
User lands to Company cards page, rather than the workspace member profile he was previously on (as you assigned the card to someone else)
To achieve this, we need to compare the accountID from the backTo param to the currently selected users accountID:
Firstly in ConfirmationStep we need to extract the accountID from the backTo param to get the workspace member from where we initially navigated accountID:
changed the title [-][$250] Web - Company cards - User stays on member profile tab instead Company cards page[/-][+][Due for payment 2025-06-05] [$250] Web - Company cards - User stays on member profile tab instead Company cards page[/+]on May 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@s77rt@jliexpensify@s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, this is already came from a test
Activity
melvin-bot commentedon Jan 29, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Jan 29, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-01-30 01:09:50 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
User stays on member profile tab instead Company cards page
What is the root cause of that problem?
The navigation inconsistency stems from the use of the
backToparameter, which defaults to redirecting users to the originating page (e.g., a members page) instead of enforcing a consistent post-submission path to the company cards page.App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx
Lines 40 to 47 in 6670a4e
What changes do you think we should make in order to solve the problem?
Change the
submitfunction to always navigate toWORKSPACE_COMPANY_CARDSafter submissionWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
github-actions commentedon Jan 29, 2025
[-]Web - Company cards - User stays on member profile tab instead Company cards page[/-][+][$250] Web - Company cards - User stays on member profile tab instead Company cards page[/+]melvin-bot commentedon Jan 30, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021884789970763850893
melvin-bot commentedon Jan 30, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)twilight2294 commentedon Jan 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User stays on member profile tab instead Company cards page
What is the root cause of that problem?
We are expected to go back to the members page if the card is assigned to the same member from whose profile page we clicked assign cards, but in the current navigation condition, we navigate to the members profile page regardless of the card being assigned to the same / different member:
App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx
Lines 40 to 47 in 6670a4e
There is not check to see if the same member was assigned the card.
What changes do you think we should make in order to solve the problem?
According to op:
To achieve this, we need to compare the
accountIDfrom thebackToparam to thecurrently selected users accountID:ConfirmationStepwe need to extract theaccountIDfrom thebackToparam to get the workspace member from where we initially navigatedaccountID:App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx
Line 30 in acd7a79
App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx
Line 38 in acd7a79
submitstep:App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx
Line 40 in acd7a79
The above conditions can be improved including the extraction of
workspaceMemberAccountIDduring PR phaseWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A this is a navigation bug
What alternative solutions did you explore? (Optional)
s77rt commentedon Jan 30, 2025
Hi! Thanks for the proposals. I think we need to align on the expected behaviour first and whether this is something we need to actually fix.
Here a slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1738245718538879
59 remaining items
[-][$250] Web - Company cards - User stays on member profile tab instead Company cards page[/-][+][Due for payment 2025-06-05] [$250] Web - Company cards - User stays on member profile tab instead Company cards page[/+]melvin-bot commentedon May 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 29, 2025
@s77rt @jliexpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
s77rt commentedon May 31, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [No QA] [Workspace Feeds] Clean up for workspace feeds #48323 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, this is already came from a test
jliexpensify commentedon Jun 1, 2025
Payment Summary
NEW UPWORKS JOB - https://www.upwork.com/jobs/~021929048197297762019
twilight2294 commentedon Jun 1, 2025
@jliexpensify I accepted the offer
jliexpensify commentedon Jun 6, 2025
Paid in Upworks!
JmillsExpensify commentedon Jun 9, 2025
$250 approved for @s77rt