You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-13] Cancellation policy is being shown as NON_REFUNDABLE instead of plain text Non Refundable #56067
Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@shubham1206agra Slack conversation (hyperlinked to channel name): travel
Action Performed:
Navigate to a hotel booking details
Click on View trip details
Expected Result:
The cancellation policy may be listed as one of the following: UNKNOWN, NON-REFUNDABLE, FREE CANCELLATION UNTIL a specified date, or PARTIALLY REFUNDABLE.
Actual Result:
Cancellation policy is being shown as NON_REFUNDABLE instead of plain text Non Refundable
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
No extra tests are required as this was a translation issue.
Activity
melvin-bot commentedon Jan 30, 2025
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Jan 30, 2025
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
m-natarajan commentedon Jan 30, 2025
@blazejkustra Tagging you as per this comment
blazejkustra commentedon Jan 30, 2025
Thanks @m-natarajan, commenting for assigment!
blazejkustra commentedon Jan 30, 2025
You need to make a reservation that is not refundable, then you'd see NON_REFUNDABLE in the details page.
PR with a fix is up, and I was able to reproduce this bug.
OfstadC commentedon Jan 30, 2025
Thanks @blazejkustra !
21 remaining items
OfstadC commentedon Feb 18, 2025
Unable to issue payment until steps are completed
OfstadC commentedon Feb 20, 2025
Same - friendly bump @shubham1206agra
melvin-bot commentedon Feb 24, 2025
@OfstadC, @stitesExpensify, @blazejkustra, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!
OfstadC commentedon Feb 25, 2025
Moving to Weekly until the BZ checklist is completed - I can then issue payment
OfstadC commentedon Mar 3, 2025
No update - can't issue payment without BZ checklist complete
shubham1206agra commentedon Mar 3, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/52823/files#r1977770778
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
No extra tests are required as this was a translation issue.
Do we agree 👍 or 👎
OfstadC commentedon Mar 4, 2025
Thanks @shubham1206agra
Payment Summary
garrettmknight commentedon Apr 22, 2025
$250 approved for @shubham1206agra