Skip to content

[Due for payment 2025-02-13] Cancellation policy is being shown as NON_REFUNDABLE instead of plain text Non Refundable #56067

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation (hyperlinked to channel name): travel

Action Performed:

  1. Navigate to a hotel booking details
  2. Click on View trip details

Expected Result:

The cancellation policy may be listed as one of the following: UNKNOWN, NON-REFUNDABLE, FREE CANCELLATION UNTIL a specified date, or PARTIALLY REFUNDABLE.

Actual Result:

Cancellation policy is being shown as NON_REFUNDABLE instead of plain text Non Refundable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @shubham1206agra

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Jan 30, 2025
  2. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Jan 30, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. m-natarajan commented on Jan 30, 2025

    @m-natarajan
    Author

    @blazejkustra Tagging you as per this comment

  5. blazejkustra commented on Jan 30, 2025

    @blazejkustra
    Contributor

    Thanks @m-natarajan, commenting for assigment!

  6. blazejkustra commented on Jan 30, 2025

    @blazejkustra
    Contributor

    You need to make a reservation that is not refundable, then you'd see NON_REFUNDABLE in the details page.

    PR with a fix is up, and I was able to reproduce this bug.

  7. OfstadC commented on Jan 30, 2025

    @OfstadC
    Contributor

    Thanks @blazejkustra !

  8. 21 remaining items

  9. OfstadC commented on Feb 18, 2025

    @OfstadC
    Contributor

    Unable to issue payment until steps are completed

  10. OfstadC commented on Feb 20, 2025

    @OfstadC
    Contributor

    Same - friendly bump @shubham1206agra

  11. melvin-bot commented on Feb 24, 2025

    @melvin-bot

    @OfstadC, @stitesExpensify, @blazejkustra, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. added and removed on Feb 25, 2025
  13. OfstadC commented on Feb 25, 2025

    @OfstadC
    Contributor

    Moving to Weekly until the BZ checklist is completed - I can then issue payment

  14. OfstadC commented on Mar 3, 2025

    @OfstadC
    Contributor

    No update - can't issue payment without BZ checklist complete

  15. shubham1206agra commented on Mar 3, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/52823/files#r1977770778

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    No extra tests are required as this was a translation issue.

    Do we agree 👍 or 👎

  16. OfstadC commented on Mar 4, 2025

    @OfstadC
    Contributor

    Thanks @shubham1206agra

    Payment Summary

  17. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Needs ReproductionReproducible steps neededWeeklyKSv2retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions