Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.92-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Action Performed:
- Log into an account that does not have a saved address (this step is crucial to replicate the scenario).
- Navigate to "Settings" and access the "Private" section in Profile settings
- Click on "Address.”
Expected Result:
The country field in the form is auto selected and reflects the user's current location (as indicated in PR #23841)
Actual Result:
Country filed is not auto selected
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
bug.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021886553288864984378
- Upwork Job ID: 1886553288864984378
- Last Price Increase: 2025-02-03
- Automatic offers:
- dominictb | Reviewer | 106032491
- daledah | Contributor | 106032492
Issue Owner
Current Issue Owner: @dominictbMetadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
Activity
melvin-bot commentedon Jan 30, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon Jan 30, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-01-30 17:39:25 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Settings - Country is not auto selected in address
What is the root cause of that problem?
AddressPage.App/src/pages/AddressPage.tsx
Line 37 in 9af5444
What changes do you think we should make in order to solve the problem?
defaultCountryand and update the state touseState(address?.country ?? defaultCountry);.PersonalAddressPagewe can get the country usingconst [country] = useOnyx(ONYXKEYS.COUNTRY);and pass thecountrytodefaultCountryprop.AddressPagealso.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
getCurrentAddressto return the country when address is undefined.Result
Monosnap.screencast.2025-02-04.15-50-47.mp4
melvin-bot commentedon Feb 3, 2025
@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Web - Settings - Country is not auto selected in address[/-][+][$250] Web - Settings - Country is not auto selected in address[/+]melvin-bot commentedon Feb 3, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021886553288864984378
melvin-bot commentedon Feb 3, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (
External)CortneyOfstad commentedon Feb 3, 2025
Was able to recreate so getting eyes on this!
@dominictb — we have one proposal above for your review. Thank you!
14 remaining items
CortneyOfstad commentedon Feb 11, 2025
PR has great progress! 🎉
CortneyOfstad commentedon Feb 19, 2025
PR was pushed to production 2 days ago! For some reason the automatic payment switch didn't happen. Manually adjusting now!
[-][$250] Web - Settings - Country is not auto selected in address[/-][+][ON HOLD for Payment 2/24] [$250] Web - Settings - Country is not auto selected in address[/+]CortneyOfstad commentedon Feb 27, 2025
Payment Summary
@daledah — paid $250 via Upwork
@dominictb — paid $250 via Upwork