Skip to content

[Due for payment 2025-03-11] [$250] Android - Search - Search list can´t be scrolled when keyboard is opened. #56342

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.94-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Email or phone of affected tester (no customers): ibellicotest+231@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Search

Action Performed:

Prerequisite: Have between 7 and 9 chats available in the account.

  1. Open the Expensify app.
  2. Tap on the search icon on the top right corner.
  3. Open the keyboard if it´s not displayed yet.
  4. Try to scroll down to see the chats that are displayed behind the keyboard.

Expected Result:

Search section should be scrollable when some chats are displayed behind the keyboard.

Actual Result:

Search section can´t be scrolled when keyboard is opened and some chats are hidden behind it. This happens when the user has between seven and nine chats available in the account.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6733154_1738674045252.Search_Scroll.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892249905494610036
  • Upwork Job ID: 1892249905494610036
  • Last Price Increase: 2025-02-19
  • Automatic offers:
    • DylanDylann | Reviewer | 106272460
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 4, 2025
  2. melvin-bot commented on Feb 4, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. bernhardoj commented on Feb 4, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Search modal can't be scrolled when keyboard is shown.

    What is the root cause of that problem?

    When we have like 9 chats, the search list itself isn't scrollable even when the keyboard is shown. It's because we don't enable keyboard avoiding view on the modal, so the list still takes the whole screen height.

    return (
    <Modal
    type={modalType}
    isVisible={isSearchRouterDisplayed}
    popoverAnchorPosition={{right: 6, top: 6}}
    fullscreen
    propagateSwipe
    shouldHandleNavigationBack={Browser.isMobileChrome()}
    onClose={closeSearchRouter}
    onModalHide={() => setShouldHideInputCaret(isMobileSafari)}
    onModalShow={() => setShouldHideInputCaret(false)}
    >

    What changes do you think we should make in order to solve the problem?

    Enable keyboard avoiding by passing avoidKeyboard prop to the modal.

    return (
    <Modal
    type={modalType}
    isVisible={isSearchRouterDisplayed}
    popoverAnchorPosition={{right: 6, top: 6}}
    fullscreen
    propagateSwipe
    shouldHandleNavigationBack={Browser.isMobileChrome()}
    onClose={closeSearchRouter}
    onModalHide={() => setShouldHideInputCaret(isMobileSafari)}
    onModalShow={() => setShouldHideInputCaret(false)}
    >

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

  4. melvin-bot commented on Feb 10, 2025

    @melvin-bot

    @strepanier03 Eep! 4 days overdue now. Issues have feelings too...

  5. strepanier03 commented on Feb 10, 2025

    @strepanier03
    Contributor

    When I attempt to reproduce this and scroll through the chats hidden behind my Android keyboard, the list scrolls, and the keyboard automatically collapses.

    I'll try to repro via BrowserStack.

  6. strepanier03 commented on Feb 10, 2025

    @strepanier03
    Contributor

    Dang, can't repro this in browserstack either.

  7. melvin-bot commented on Feb 14, 2025

    @melvin-bot

    @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Feb 14, 2025
  9. MelvinBot commented on Feb 14, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  10. 39 remaining items

  11. mvtglobally commented on Mar 7, 2025

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  12. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@strepanier03)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1892249905494610036/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. strepanier03 commented on Mar 11, 2025

    @strepanier03
    Contributor

    @bernhardoj - As contributor you can use the payment summary above to request payment.

    @eh2077 - Please take care of the checklist and then you can also use the summary above to request payment. I'll make the reg test once the checklist is done.

  14. bernhardoj commented on Mar 12, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  15. JmillsExpensify commented on Mar 12, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

  16. eh2077 commented on Mar 12, 2025

    @eh2077
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/50143/files#r1992449863

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Have between 7 and 9 chats available in the account.

    Test:

    1. Test on mobile device as there's no keyboard on Web/Desktop
    2. Press the search icon on the top right corner.
    3. Open the keyboard if it´s not displayed yet.
    4. Verify you can scroll the list

    Do we agree 👍 or 👎

  17. eh2077 commented on Mar 12, 2025

    @eh2077
    Contributor

    @strepanier03 Checklist done

  18. strepanier03 commented on Mar 13, 2025

    @strepanier03
    Contributor

    @eh2077 - I've finished up on my end, feel free to put in your request!

  19. JmillsExpensify commented on Mar 17, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNeeds ReproductionReproducible steps neededretest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions