You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-11] [$250] Android - Search - Search list can´t be scrolled when keyboard is opened. #56342
Version Number: 9.0.94-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both Email or phone of affected tester (no customers):ibellicotest+231@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 App Component: Search
Action Performed:
Prerequisite: Have between 7 and 9 chats available in the account.
Open the Expensify app.
Tap on the search icon on the top right corner.
Open the keyboard if it´s not displayed yet.
Try to scroll down to see the chats that are displayed behind the keyboard.
Expected Result:
Search section should be scrollable when some chats are displayed behind the keyboard.
Actual Result:
Search section can´t be scrolled when keyboard is opened and some chats are hidden behind it. This happens when the user has between seven and nine chats available in the account.
Please re-state the problem that we are trying to solve in this issue.
Search modal can't be scrolled when keyboard is shown.
What is the root cause of that problem?
When we have like 9 chats, the search list itself isn't scrollable even when the keyboard is shown. It's because we don't enable keyboard avoiding view on the modal, so the list still takes the whole screen height.
When I attempt to reproduce this and scroll through the chats hidden behind my Android keyboard, the list scrolls, and the keyboard automatically collapses.
@bernhardoj - As contributor you can use the payment summary above to request payment.
@eh2077 - Please take care of the checklist and then you can also use the summary above to request payment. I'll make the reg test once the checklist is done.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Have between 7 and 9 chats available in the account.
Test:
Test on mobile device as there's no keyboard on Web/Desktop
Activity
melvin-bot commentedon Feb 4, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Feb 4, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Search modal can't be scrolled when keyboard is shown.
What is the root cause of that problem?
When we have like 9 chats, the search list itself isn't scrollable even when the keyboard is shown. It's because we don't enable keyboard avoiding view on the modal, so the list still takes the whole screen height.
App/src/components/Search/SearchRouter/SearchRouterModal.tsx
Lines 21 to 32 in bfb97c5
What changes do you think we should make in order to solve the problem?
Enable keyboard avoiding by passing
avoidKeyboardprop to the modal.App/src/components/Search/SearchRouter/SearchRouterModal.tsx
Lines 21 to 32 in bfb97c5
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
melvin-bot commentedon Feb 10, 2025
@strepanier03 Eep! 4 days overdue now. Issues have feelings too...
strepanier03 commentedon Feb 10, 2025
When I attempt to reproduce this and scroll through the chats hidden behind my Android keyboard, the list scrolls, and the keyboard automatically collapses.
I'll try to repro via BrowserStack.
strepanier03 commentedon Feb 10, 2025
Dang, can't repro this in browserstack either.
melvin-bot commentedon Feb 14, 2025
@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!
MelvinBot commentedon Feb 14, 2025
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
39 remaining items
mvtglobally commentedon Mar 7, 2025
Issue not reproducible during KI retests. (First week)
melvin-bot commentedon Mar 11, 2025
Payment Summary
Upwork Job
BugZero Checklist (@strepanier03)
strepanier03 commentedon Mar 11, 2025
@bernhardoj - As contributor you can use the payment summary above to request payment.
@eh2077 - Please take care of the checklist and then you can also use the summary above to request payment. I'll make the reg test once the checklist is done.
bernhardoj commentedon Mar 12, 2025
Requested in ND.
JmillsExpensify commentedon Mar 12, 2025
$250 approved for @bernhardoj
eh2077 commentedon Mar 12, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/50143/files#r1992449863
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
eh2077 commentedon Mar 12, 2025
@strepanier03 Checklist done
strepanier03 commentedon Mar 13, 2025
@eh2077 - I've finished up on my end, feel free to put in your request!
JmillsExpensify commentedon Mar 17, 2025
$250 approved for @eh2077