Skip to content

[Due for payment 2025-02-26] Bring the "done" report status filter to New Expensify #56488

Closed

Description

@MitchExpensify

Background:

In #wave-collect: Search v2 we introduced a done badge, which shows up within the paid status. We decided against a done or finished default state because the final state for IOUs is paid, and IOUs are not a feature that can be turned off. In a similar fashion for workspaces, the majority of our customers track or make payments (even if they don’t pay in product).

Problem:

The paid report status is confusing for closed reports in New Expensify in two scenarios;

  1. When reports without reimbursable expenses are considered paid upon submission.
  2. When reports with reimbursable expenses are considered paid upon submission before any payment has been actioned.

Solution:

Stop including closed expense reports that have no reimbursable expenses or reimbursement has not been actioned yet in the paid status filter, and house them in their own done status filter instead. Like Classic, done reports that have reimbursement action on them will move to the paid status filter.

Notes for completeness:

  • The status will be positioned between Approved and Paid
  • We'll only show the "Done" status if you are on a workspace with approvals disabled
  • We'll use this checkbox icon (Figgy for report mock / Figgy for working icons):

Image

Tests:

Preconditions: Use a workspace with approvals disabled

  1. Submit a report with 100% reimbursable expenses on it > Verify it enters the closed status
  2. Submit a report with 100% non-reimbursable expenses on it > Verify it enters the closed status
  3. Submit a report with both reimbursable and non-reimbursables on it > Verify it enters the closed status
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. melvin-bot commented on Feb 6, 2025

    @melvin-bot

    Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

  2. MitchExpensify commented on Feb 6, 2025

    @MitchExpensify
    ContributorAuthor

    I think what we need to decide first is what icon we want to use for closed @dannymcclain

    Image
  3. dannymcclain commented on Feb 6, 2025

    @dannymcclain
  4. MitchExpensify commented on Feb 6, 2025

    @MitchExpensify
    ContributorAuthor

    One thing I think is worth mentioning is that being closed is a positive thing in a sense, and maybe that might influence the icon we choose. In other words, when a report is closed, it has been submitted, which means it has progressed down the track toward either payment or export as a next step (depending on whether there are reimbursable expenses on the report or not). Those examples feel a little negative to me for want of a better observation

    Also, I think it makes sense to position Closed between Outstanding and Approved when you think about the flow:

    Approvals disabled:
    Draft > Closed > Paid

    Approvals enabled:
    Draft > Oustanding > Approved > Paid

  5. dannymcclain commented on Feb 6, 2025

    @dannymcclain
    Contributor

    Oh hmm I think that does change things 🤔

  6. trjExpensify commented on Feb 6, 2025

    @trjExpensify
    Contributor

    Will we only show this filter to people that have a workspace with submit&close, is that right?

  7. MitchExpensify commented on Feb 6, 2025

    @MitchExpensify
    ContributorAuthor

    Will we only show this filter to people that have a workspace with submit&close, is that right?

    Correct but someone could be a member of both types of workspaces so they could see both Closed and Approved

  8. trjExpensify commented on Feb 6, 2025

    @trjExpensify
    Contributor

    Yeah, in theory, though I'd still vote to put Closed after Approved as it's more of a final state. The delta being submit&closed + payments, but in that case Paid will be last.

  9. MitchExpensify commented on Feb 7, 2025

    @MitchExpensify
    ContributorAuthor

    Coming from this thread we landed on doing this: https://expensify.slack.com/archives/C03TME82F/p1738968491101599?thread_ts=1738884571.891239&cid=C03TME82F

    • We're naming the status "Done"
    • The status will be positioned between Approved and Paid
    • We'll only show the "Done" status if you are on a workspace with approvals disabled
    • We'll go with this checkbox icon :camera_with_flash:

    Image

  10. changed the title [-]Bring the closed report status filter to New Expensify[/-] [+]Bring the "done" report status filter to New Expensify[/+] on Feb 7, 2025
  11. 23 remaining items

  12. changed the title [-]Bring the "done" report status filter to New Expensify[/-] [+][Due for payment 2025-02-26] Bring the "done" report status filter to New Expensify[/+] on Feb 19, 2025
  13. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @thesahindia requires payment through NewDot Manual Requests
  15. melvin-bot commented on Feb 26, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @RachCHopkins you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  16. melvin-bot commented on Feb 26, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@RachCHopkins)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. RachCHopkins commented on Feb 28, 2025

    @RachCHopkins
    Contributor

    No Upwork job or offer needed.

    Payment Summary:

    • Contributor: @thesahindia to be paid $250 via NewDot manual request.
  18. RachCHopkins commented on Feb 28, 2025

    @RachCHopkins
    Contributor

    No Contributor to pay via Upwork, no contract to complete, and no Upwork post to close.

  19. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Design

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions