You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-26] Bring the "done" report status filter to New Expensify #56488
In #wave-collect: Search v2 we introduced a done badge, which shows up within the paid status. We decided against a done or finished default state because the final state for IOUs is paid, and IOUs are not a feature that can be turned off. In a similar fashion for workspaces, the majority of our customers track or make payments (even if they don’t pay in product).
Problem:
The paid report status is confusing for closed reports in New Expensify in two scenarios;
When reports without reimbursable expenses are considered paid upon submission.
When reports with reimbursable expenses are considered paid upon submission before any payment has been actioned.
Solution:
Stop including closed expense reports that have no reimbursable expenses or reimbursement has not been actioned yet in the paid status filter, and house them in their own done status filter instead. Like Classic, done reports that have reimbursement action on them will move to the paid status filter.
Notes for completeness:
The status will be positioned between Approved and Paid
We'll only show the "Done" status if you are on a workspace with approvals disabled
One thing I think is worth mentioning is that being closed is a positive thing in a sense, and maybe that might influence the icon we choose. In other words, when a report is closed, it has been submitted, which means it has progressed down the track toward either payment or export as a next step (depending on whether there are reimbursable expenses on the report or not). Those examples feel a little negative to me for want of a better observation
Also, I think it makes sense to position Closed between Outstanding and Approved when you think about the flow:
Yeah, in theory, though I'd still vote to put Closed after Approved as it's more of a final state. The delta being submit&closed + payments, but in that case Paid will be last.
changed the title [-]Bring the closed report status filter to New Expensify[/-][+]Bring the "done" report status filter to New Expensify[/+]on Feb 7, 2025
changed the title [-]Bring the "done" report status filter to New Expensify[/-][+][Due for payment 2025-02-26] Bring the "done" report status filter to New Expensify[/+]on Feb 19, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Issue is ready for payment but no BZ is assigned. @RachCHopkins you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
melvin-bot commentedon Feb 6, 2025
Triggered auto assignment to @dannymcclain (
Design), see these Stack Overflow questions for more details.MitchExpensify commentedon Feb 6, 2025
I think what we need to decide first is what icon we want to use for closed @dannymcclain
dannymcclain commentedon Feb 6, 2025
MitchExpensify commentedon Feb 6, 2025
One thing I think is worth mentioning is that being closed is a positive thing in a sense, and maybe that might influence the icon we choose. In other words, when a report is closed, it has been submitted, which means it has progressed down the track toward either payment or export as a next step (depending on whether there are reimbursable expenses on the report or not). Those examples feel a little negative to me for want of a better observation
Also, I think it makes sense to position Closed between Outstanding and Approved when you think about the flow:
Approvals disabled:
Draft > Closed > Paid
Approvals enabled:
Draft > Oustanding > Approved > Paid
dannymcclain commentedon Feb 6, 2025
Oh hmm I think that does change things 🤔
trjExpensify commentedon Feb 6, 2025
Will we only show this filter to people that have a workspace with submit&close, is that right?
MitchExpensify commentedon Feb 6, 2025
Correct but someone could be a member of both types of workspaces so they could see both Closed and Approved
trjExpensify commentedon Feb 6, 2025
Yeah, in theory, though I'd still vote to put
ClosedafterApprovedas it's more of a final state. The delta being submit&closed + payments, but in that casePaidwill be last.MitchExpensify commentedon Feb 7, 2025
Coming from this thread we landed on doing this: https://expensify.slack.com/archives/C03TME82F/p1738968491101599?thread_ts=1738884571.891239&cid=C03TME82F
[-]Bring the closed report status filter to New Expensify[/-][+]Bring the "done" report status filter to New Expensify[/+]23 remaining items
[-]Bring the "done" report status filter to New Expensify[/-][+][Due for payment 2025-02-26] Bring the "done" report status filter to New Expensify[/+]melvin-bot commentedon Feb 19, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 19, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 26, 2025
Issue is ready for payment but no BZ is assigned. @RachCHopkins you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Feb 26, 2025
Payment Summary
Upwork Job
BugZero Checklist (@RachCHopkins)
RachCHopkins commentedon Feb 28, 2025
No Upwork job or offer needed.
Payment Summary:
RachCHopkins commentedon Feb 28, 2025
No Contributor to pay via Upwork, no contract to complete, and no Upwork post to close.
garrettmknight commentedon Apr 22, 2025
$250 approved for @thesahindia