You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: V9.0.96-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both Issue reported by: Applause Internal Team Device used: Redmi note 10s android 13 App Component: Money Requests
Action Performed:
Precondition: The distance rates feature is enabled and has some distance rates
Launch app
Go to the workspace chat and create a distance request with a distance rate (not the default distance rate)
Delete the distance rate that is selected above
Go to the transaction detail and note the distance rate changes
Expected Result:
Distance rate must be changed to default distance rate and error must not be displayed below.
Actual Result:
On deleting selected distance rate, in expense created, the distance rate changed to default distance rate but an error is displayed below.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ikevin127@dylanexpensify@ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
the workspace distance rates feature is enabled
there are multiple custom distance rates added besides the default distance rate
Launch the application.
Navigate to the workspace chat and create a distance expense selecting one of the added distance rates.
Navigate to the workspace settings and delete the distance rate that was selected when creating the above expense.
Navigate to the created distance expense transaction details view.
Verify that Rate out of policy is displayed in the Rate field instead of the default rate.
Verify that the 🔴 Rate not valid for this workspace violation error is displayed under the Rate field.
Activity
melvin-bot commentedon Feb 11, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dylanexpensify commentedon Feb 12, 2025
reviewing today
melvin-bot commentedon Feb 17, 2025
@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...
[-]Distance-On deleting selected distance rate, error shown below default rate[/-][+][$250] Distance-On deleting selected distance rate, error shown below default rate[/+]melvin-bot commentedon Feb 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021892121878668365940
dylanexpensify commentedon Feb 19, 2025
thought I hit the button, my bad!
melvin-bot commentedon Feb 19, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)31 remaining items
[-][$250] Distance-On deleting selected distance rate, error shown below default rate[/-][+][Due for payment 2025-03-10] [$250] Distance-On deleting selected distance rate, error shown below default rate[/+]melvin-bot commentedon Mar 3, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 3, 2025
@ikevin127 @dylanexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
dylanexpensify commentedon Mar 5, 2025
Nice! Coming up!
ikevin127 commentedon Mar 9, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/38543/files#r1986391463.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Rate out of policyis displayed in the Rate field instead of the default rate.Rate not valid for this workspaceviolation error is displayed under the Rate field.Do we agree 👍 or 👎.
ikevin127 commentedon Mar 10, 2025
cc @dylanexpensify for payments
mallenexpensify commentedon Mar 11, 2025
Contributor: @huult paid $256 via Upwork
Contributor+: @ikevin127 paid $250 via Upwork
Test case
Thx!