Skip to content

[Due for payment 2025-03-10] [$250] Distance-On deleting selected distance rate, error shown below default rate #56674

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

Precondition: The distance rates feature is enabled and has some distance rates

  1. Launch app
  2. Go to the workspace chat and create a distance request with a distance rate (not the default distance rate)
  3. Delete the distance rate that is selected above
  4. Go to the transaction detail and note the distance rate changes

Expected Result:

Distance rate must be changed to default distance rate and error must not be displayed below.

Actual Result:

On deleting selected distance rate, in expense created, the distance rate changed to default distance rate but an error is displayed below.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6739537_1739275769670.screenrecorder-2025-02-11-11-29-07-954.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892121878668365940
  • Upwork Job ID: 1892121878668365940
  • Last Price Increase: 2025-02-19
  • Automatic offers:
    • ikevin127 | Reviewer | 106274049
    • huult | Contributor | 106274051
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 11, 2025
  2. melvin-bot commented on Feb 11, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. dylanexpensify commented on Feb 12, 2025

    @dylanexpensify
    Contributor

    reviewing today

  4. melvin-bot commented on Feb 17, 2025

    @melvin-bot

    @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 19, 2025
  6. changed the title [-]Distance-On deleting selected distance rate, error shown below default rate[/-] [+][$250] Distance-On deleting selected distance rate, error shown below default rate[/+] on Feb 19, 2025
  7. melvin-bot commented on Feb 19, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 19, 2025
  9. dylanexpensify commented on Feb 19, 2025

    @dylanexpensify
    Contributor

    thought I hit the button, my bad!

  10. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

  11. 31 remaining items

  12. changed the title [-][$250] Distance-On deleting selected distance rate, error shown below default rate[/-] [+][Due for payment 2025-03-10] [$250] Distance-On deleting selected distance rate, error shown below default rate[/+] on Mar 3, 2025
  13. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-10. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    @ikevin127 @dylanexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. dylanexpensify commented on Mar 5, 2025

    @dylanexpensify
    Contributor

    Nice! Coming up!

  17. ikevin127 commented on Mar 9, 2025

    @ikevin127
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/38543/files#r1986391463.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • the workspace distance rates feature is enabled
    • there are multiple custom distance rates added besides the default distance rate
    1. Launch the application.
    2. Navigate to the workspace chat and create a distance expense selecting one of the added distance rates.
    3. Navigate to the workspace settings and delete the distance rate that was selected when creating the above expense.
    4. Navigate to the created distance expense transaction details view.
    5. Verify that Rate out of policy is displayed in the Rate field instead of the default rate.
    6. Verify that the 🔴 Rate not valid for this workspace violation error is displayed under the Rate field.

    Do we agree 👍 or 👎.

  18. ikevin127 commented on Mar 10, 2025

    @ikevin127
    Contributor

    cc @dylanexpensify for payments

  19. mallenexpensify commented on Mar 11, 2025

    @mallenexpensify
    Contributor

    Contributor: @huult paid $256 via Upwork
    Contributor+: @ikevin127 paid $250 via Upwork

    Test case

    Thx!

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions