Skip to content

[Awaiting checklist] [$250] Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change #56697

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+232@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Workspace Settings

Action Performed:

  1. Open the Expensify app.
  2. Tap on "Settings" and select "Workspaces"
  3. Turn off internet connection on the device.
  4. Tap on "New Workspace"
  5. Tap on "Default Currency"
  6. Open the keyboard if it´s not opened yet.
  7. Check if the "You appear to be offline" message, is displayed above the keyboard when opening it.

Expected Result:

"You appear to be offline" message, should be moved above the keyboard, when opening it while changing default currency of a new workspace.

Actual Result:

"You appear to be offline" message is displayed hidden behind the keyboard while changing default currency of a new workspace while in offline mode. This behavior is experienced on new workspaces creation and not while changing currency of an existing workspace.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021889823380595087574
  • Upwork Job ID: 1889823380595087574
  • Last Price Increase: 2025-02-12
  • Automatic offers:
    • ishpaul777 | Contributor | 106185695
Issue OwnerCurrent Issue Owner: @rushatgabhane

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 11, 2025
  2. melvin-bot commented on Feb 11, 2025

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. ishpaul777 commented on Feb 11, 2025

    @ishpaul777
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "You appear to be offline" displayed behind keyboard on currency change

    What is the root cause of that problem?

    HERE IN CurrencyPicker we remove screenwrapper padding style and use Modal (parent component) padding style leading to this issue

    includePaddingTop={false}
    includeSafeAreaPaddingBottom

    What changes do you think we should make in order to solve the problem?

    we need to remove modal styles with shouldUseModalPaddingStyle and keep the screenwrapper padding styles

                    <ScreenWrapper
                        includePaddingTop
                        includeSafeAreaPaddingBottom

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    this is minor Ui issue, very hard to test with a automated test and easy to spot manually so I suggest we skip the automated tests

    What alternative solutions did you explore?

    we can fix this at other places where we use right docked Modal and Screenwrapper

    Image

    Demo:

    Screen.Recording.2025-02-12.at.2.03.34.AM.mov
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 12, 2025
  5. melvin-bot commented on Feb 12, 2025

    @melvin-bot
  6. changed the title [-]Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change[/-] [+][$250] Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change[/+] on Feb 12, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 12, 2025
  8. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  9. rushatgabhane commented on Feb 12, 2025

    @rushatgabhane
    Member

    @ishpaul777 's proposal LGTM 🎀👀🎀

    #56697 (comment)

  10. melvin-bot commented on Feb 12, 2025

    @melvin-bot

    Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  11. melvin-bot commented on Feb 18, 2025

    @melvin-bot

    @twisterdotcom, @youssef-lr, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

  12. 28 remaining items

  13. twisterdotcom commented on Mar 17, 2025

    @twisterdotcom
    Contributor

    Great, withdrew the upwork offer as accident and updated the Payment Summary.

  14. melvin-bot commented on Mar 19, 2025

    @melvin-bot

    @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. twisterdotcom commented on Mar 20, 2025

    @twisterdotcom
    Contributor
  16. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

  17. twisterdotcom commented on Mar 25, 2025

    @twisterdotcom
    Contributor
  18. rushatgabhane commented on Mar 26, 2025

    @rushatgabhane
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/54798/files#r2014006174

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Open the Expensify app.
    2. Tap on "Settings" and select "Workspaces"
    3. Turn off internet connection on the device.
    4. Tap on "New Workspace"
    5. Tap on "Default Currency"
    6. Open the keyboard if it´s not opened yet.
    7. Verify if the "You appear to be offline" message, is displayed above the keyboard when opening it.

    Do we agree 👍 or 👎

  19. twisterdotcom commented on Mar 26, 2025

    @twisterdotcom
    Contributor

    Summary updated: #56697 (comment)

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 26, 2025
  21. garrettmknight commented on Mar 31, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

  22. garrettmknight commented on May 2, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions