You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting checklist] [$250] Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change #56697
Version Number: 9.0.96-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):ibellicotest+232@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 App Component: Workspace Settings
Action Performed:
Open the Expensify app.
Tap on "Settings" and select "Workspaces"
Turn off internet connection on the device.
Tap on "New Workspace"
Tap on "Default Currency"
Open the keyboard if it´s not opened yet.
Check if the "You appear to be offline" message, is displayed above the keyboard when opening it.
Expected Result:
"You appear to be offline" message, should be moved above the keyboard, when opening it while changing default currency of a new workspace.
Actual Result:
"You appear to be offline" message is displayed hidden behind the keyboard while changing default currency of a new workspace while in offline mode. This behavior is experienced on new workspaces creation and not while changing currency of an existing workspace.
changed the title [-]Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change[/-][+][$250] Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change[/+]on Feb 12, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Feb 11, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.ishpaul777 commentedon Feb 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"You appear to be offline" displayed behind keyboard on currency change
What is the root cause of that problem?
HERE IN CurrencyPicker we remove screenwrapper padding style and use Modal (parent component) padding style leading to this issue
App/src/components/CurrencyPicker.tsx
Lines 80 to 81 in 402fc91
What changes do you think we should make in order to solve the problem?
we need to remove modal styles with
shouldUseModalPaddingStyleand keep the screenwrapper padding stylesWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
this is minor Ui issue, very hard to test with a automated test and easy to spot manually so I suggest we skip the automated tests
What alternative solutions did you explore?
we can fix this at other places where we use right docked Modal and Screenwrapper
Demo:
Screen.Recording.2025-02-12.at.2.03.34.AM.mov
melvin-bot commentedon Feb 12, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021889823380595087574
[-]Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change[/-][+][$250] Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change[/+]melvin-bot commentedon Feb 12, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)rushatgabhane commentedon Feb 12, 2025
@ishpaul777 's proposal LGTM 🎀👀🎀
#56697 (comment)
melvin-bot commentedon Feb 12, 2025
Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
melvin-bot commentedon Feb 18, 2025
@twisterdotcom, @youssef-lr, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...
28 remaining items
twisterdotcom commentedon Mar 17, 2025
Great, withdrew the upwork offer as accident and updated the Payment Summary.
melvin-bot commentedon Mar 19, 2025
@rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!
twisterdotcom commentedon Mar 20, 2025
Bump @rushatgabhane.
melvin-bot commentedon Mar 25, 2025
@rushatgabhane Eep! 4 days overdue now. Issues have feelings too...
twisterdotcom commentedon Mar 25, 2025
Bump @rushatgabhane
rushatgabhane commentedon Mar 26, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/54798/files#r2014006174
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/484710
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
twisterdotcom commentedon Mar 26, 2025
Summary updated: #56697 (comment)
garrettmknight commentedon Mar 31, 2025
$250 approved for @rushatgabhane
garrettmknight commentedon May 2, 2025
$250 approved for @ishpaul777