Repository navigation
Description
Context
Slack proposal/discussion: https://expensify.slack.com/archives/C05LX9D6E07/p1738873979343599
Profiling is a critical tool for debugging and optimizing application performance. It allows developers to identify bottlenecks, troubleshoot slowdowns, and ensure the app runs efficiently across all platforms. Without reliable profiling, developers may struggle to diagnose issues, leading to slower issue resolution and potential performance degradation.
Currently, Profiling is only fully functional on native iOS and Android, while other platforms experience incomplete traces, obfuscation issues, or outright failures. This prevents us from effectively diagnosing performance problems in non-native environments, delaying optimizations and making it harder to maintain a high-performing application.
Note: The Profiling option can be enabled/disabled in desktop/browsers by pressing CMD + D to access the Troubleshoot menu and then pressing the Use profiling toggle, and in mobile apps/mobile browsers by performing a four-finger tap in the screen to access the Troubleshoot menu and then pressing the Use profiling toggle.
Problem
- MacOS/iOS: Chrome/Safari
- Staging - ❌
- Profiling "works" but always result in a 48-byte file with empty traces.
- There's also this warning:
[Warning] Profiler is not available in this browser. Ignoring this profiler run....
- Production - ❌
- Profiling "works" but always result in a 48-byte file with empty traces.
- There's also this warning:
[Warning] Profiler is not available in this browser. Ignoring this profiler run....
- Staging - ❌
Action Items
- I did some research and it looks like all browsers in iOS are required to use the WebKit engine (so they are all "Safari" under the hood), so according to this Safari isn't supported yet, so let's consider hiding this option for Chrome/Safari if the platform is iOS and for Safari if the platform is MacOS.
- For a follow-up and if we agree that the effort is worth it, we can explore adding this support to the WebKit engine.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021891659093337244112
- Upwork Job ID: 1891659093337244112
- Last Price Increase: 2025-02-25
- Automatic offers:
- suneox | Reviewer | 106392734
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
[-][LOW] Investigate Profiling: iOS - Chrome/Safari and MacOS - Chrome[/-][+][LOW] Investigate Profiling: iOS - Chrome/Safari and MacOS - Safari[/+][-][LOW] Investigate Profiling: iOS - Chrome/Safari and MacOS - Safari[/-][+][$250] [LOW] Investigate Profiling: iOS - Chrome/Safari and MacOS - Safari[/+]melvin-bot commentedon Feb 18, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021891659093337244112
melvin-bot commentedon Feb 18, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)M00rish commentedon Feb 20, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-02-24 17:44:23 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
we're hiding profiling option for Chrome/Safari if the platform is iOS and for Safari if the platform is MacOS, because react profiler API lacks support for them
What is the root cause of that problem?
we're hiding profiling option for Chrome/Safari if the platform is iOS and for Safari if the platform is MacOS, because react profiler API lacks support for them
What changes do you think we should make in order to solve the problem?
we can add a new function to check platforms :
App/src/components/TestToolsModal.tsx
Line 42 in a4f62fa
Details
What alternative solutions did you explore? (Optional)
github-actions commentedon Feb 20, 2025
melvin-bot commentedon Feb 21, 2025
@suneox, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
fabioh8010 commentedon Feb 24, 2025
Checking the proposal
47 remaining items
melvin-bot commentedon Mar 29, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mallenexpensify commentedon Mar 29, 2025
Contributor: @M00rish owed $250 via Upwork
Contributor+: @suneox paid $250 via Upwork
@M00rish can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021891659093337244112
@abekkala I'm going to be OOO and offline for two weeks so I'm reassigning, will pick back up upon my return, thx
abekkala commentedon Mar 31, 2025
@M00rish bumping @mallenexpensify message above so we can pay this and close it out - thanks!
M00rish commentedon Mar 31, 2025
@abekkala, can you send me an offer for this job, I applied, but my application did not go through.
Thanks.
melvin-bot commentedon Apr 1, 2025
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
abekkala commentedon Apr 1, 2025
@M00rish OFFER sent
M00rish commentedon Apr 1, 2025
Accepted thanks
abekkala commentedon Apr 1, 2025
@M00rish payment sent and contract ended - thank you! 🎉