Repository navigation
[Due for payment 2025-03-17] [$250] [Due for payment 2025-03-13] [HybridApp] Improve the way of sending data between New and Old apps on mobile #56836
Description
Context
Currently, we use a single string (named url) to pass data from OldDot side to New app when necessary.
{
"url": "/home?
email=marcin.warchol+exp.ht@swmansion.com
&authToken=<REDACTED>
&accountID=16530855
&autoGeneratedLogin=<REDACTED>
&autoGeneratedPassword=<REDACTED>
&clearOnyxOnStart=false
&isSingleNewDotEntry=false
&completedHybridAppOnboarding=true
&primaryLogin=marcin.warchol+exp.ht@swmansion.com
&encryptedAuthToken=<REDACTED>"
}
Then on the ND side we need to parse this string to extract each field
const {
email,
authToken,
encryptedAuthToken,
accountID,
autoGeneratedLogin,
autoGeneratedPassword,
clearOnyxOnStart,
completedHybridAppOnboarding,
nudgeMigrationTimestamp,
isSingleNewDotEntry,
primaryLogin,
oldDotOriginalAccountEmail,
} = Object.fromEntries(
queryParams.split('&').map((param) => {
const [key, value] = param.split('=');
return [key, value];
}),
);Solution
To improve sending and receiving the data we can organize it as multiple fields and objects. This way we will have nice, typed and structured (easy to read and handle) data.
type HybridAppSettings = {
email: string;
authToken: string;
accountID: number;
autoGeneratedLogin: string;
autoGeneratedPassword: string;
clearOnyxOnStart: boolean;
completedHybridAppOnboarding: boolean;
isSingleNewDotEntry: boolean;
primaryLogin: string;
encryptedAuthToken: string;
nudgeMigrationTimestamp?: string;
oldDotOriginalAccountEmail?: string;
};Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021899160401413253155
- Upwork Job ID: 1899160401413253155
- Last Price Increase: 2025-03-17
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @hoangzinhMetadata
Metadata
Labels
Type
Projects
- Status
Activity
war-in commentedon Feb 13, 2025
cc @Julesssss
45 remaining items
melvin-bot commentedon Mar 13, 2025
@hoangzinh @Julesssss @sonialiap @war-in this issue is now 4 weeks old, please consider:
Thanks!
hoangzinh commentedon Mar 13, 2025
Not overdue, awaiting the regression period.
sonialiap commentedon Mar 13, 2025
As Vinh said, waiting until the 17th
melvin-bot commentedon Mar 17, 2025
Payment Summary
Upwork Job
BugZero Checklist (@sonialiap)
melvin-bot commentedon Mar 17, 2025
@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!
sonialiap commentedon Mar 17, 2025
Payment summary:
hoangzinh commentedon Mar 17, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No offending PR. It's just an improvement issue
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
No, It's just an improvement issue
hoangzinh commentedon Mar 17, 2025
Requested payment in ND
melvin-bot commentedon Mar 17, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
sonialiap commentedon Mar 18, 2025
No regression test needed, closing out
garrettmknight commentedon Mar 21, 2025
$250 approved for @hoangzinh